Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenAI] providing feedback in the form of a PR for the v2024_08_01_preview release #30749

Conversation

jpalvarezl
Copy link
Member

@jpalvarezl jpalvarezl commented Sep 26, 2024

Feedback for the v2024_08_01_preview release PR #30377

Note: we can skip the CI checks since this PR is opened against a feature branch. We can address everything together in the parent PR.

Copy link

openapi-pipeline-app bot commented Sep 26, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Sep 26, 2024

Copy link
Member

@trrwilson trrwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome, thank you!

@trrwilson trrwilson merged commit 88e9be0 into user/travisw/aoai-2024-08-01-preview Sep 27, 2024
21 of 28 checks passed
@trrwilson trrwilson deleted the jpalvarezl/v2024_08_01_preview_feedback branch September 27, 2024 02:01
lmazuel pushed a commit that referenced this pull request Oct 21, 2024
* inital baseline commit to introduce new label for diff

* non-uploads changes

* CI-uncovered fixes (primarily examples)

* uploads additions

* Update specification/cognitiveservices/OpenAI.Inference/models/completions/chat_messages.tsp

Co-authored-by: Shawn Fang <[email protected]>

* Update specification/cognitiveservices/OpenAI.Inference/models/completions/chat_messages.tsp

Co-authored-by: Jose Alvarez <[email protected]>

* [OpenAI] providing feedback in the form of a PR for the `v2024_08_01_preview` release (#30749)

* ci checks and compile

* Adding Completions/options fields

* fixed nullability

* Added missing refusal field

* Adding MongoDB index_name

* Changed types for bytes in upload object

* Adding visibility for new uploadFile Parts ops

* Added supression for mp/df op

* removing auto sample gen for java

* Restoring for older versions ChatMessageContent

* Adding nullability for refusal in response chat message

* Adding release entries in the  file

* Another past type correction to prevent unnecessary CI redflags

* Adding nullable refusal to check

* formatter

* Example corrections

* Added missing examples for new file operations

* renamed body field

* Added missing azure_block_id to part upload and corrected examples

* Specified UploadPurpose and corrected comment

* Adjusted documentation for CreateUploadRequestPurpose

* Ran formatters and re-compiled

* Moved authentication field out of OnYourDataCommonChatExtensionConfiguration

* Specified authetincation type for MongoDB

---------

Co-authored-by: Shawn Fang <[email protected]>
Co-authored-by: Jose Alvarez <[email protected]>
Co-authored-by: Jose Alvarez <[email protected]>
lmazuel pushed a commit that referenced this pull request Nov 14, 2024
…-01-preview service releases (#30909)

* inital baseline commit to introduce new label for diff

* non-uploads changes

* CI-uncovered fixes (primarily examples)

* uploads additions

* Update specification/cognitiveservices/OpenAI.Inference/models/completions/chat_messages.tsp

Co-authored-by: Shawn Fang <[email protected]>

* Update specification/cognitiveservices/OpenAI.Inference/models/completions/chat_messages.tsp

Co-authored-by: Jose Alvarez <[email protected]>

* [OpenAI] providing feedback in the form of a PR for the `v2024_08_01_preview` release (#30749)

* ci checks and compile

* Adding Completions/options fields

* fixed nullability

* Added missing refusal field

* Adding MongoDB index_name

* Changed types for bytes in upload object

* Adding visibility for new uploadFile Parts ops

* Added supression for mp/df op

* removing auto sample gen for java

* Restoring for older versions ChatMessageContent

* Adding nullability for refusal in response chat message

* Adding release entries in the  file

* Another past type correction to prevent unnecessary CI redflags

* Adding nullable refusal to check

* formatter

* Example corrections

* Added missing examples for new file operations

* renamed body field

* Added missing azure_block_id to part upload and corrected examples

* Specified UploadPurpose and corrected comment

* Adjusted documentation for CreateUploadRequestPurpose

* Ran formatters and re-compiled

* Moved authentication field out of OnYourDataCommonChatExtensionConfiguration

* Specified authetincation type for MongoDB

* Updated docs for max_tokens and added new max_completion_tokens

* Tsp compile

* Added deprecated directive to max_tokens field

* Added back streamOptions to completion and chatcompletion options

* Tsp compile

* added parallel_tool_calls field to ThreadRun and ChatCompletions

* tsp compile for assistants and inference

* Added parallel_tool_calls to all assistants classes

* Added changes for reasoning token in completion usage

* ran formatter

* Fixed optionality of inline model and deprecation typo

* ThreadRun.parallelToolCalls is mandatory in OpenAI

* Added examples and readme entry for Assistants for new version

* compiled assistants

* Corrected json

* Added examples for v2024-09-01-preview and readme entry inference

* Adding TSP project files

* TSP compile

* CI checks and readme entry for generated file

* Update specification/cognitiveservices/OpenAI.Inference/models/completions/azure_content_filtering.tsp

Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>

* TSP compile

* Removed default from response model

* ci check for tsp validation

* Added 2024-10-01-preview to assistants service version

* Added missing entry for 10-01-preview assistants

* Corrected readme file

* Update specification/ai/OpenAI.Assistants/main.tsp

Co-authored-by: Johan Stenberg (MSFT) <[email protected]>

---------

Co-authored-by: Travis Wilson <[email protected]>
Co-authored-by: Travis Wilson <[email protected]>
Co-authored-by: Shawn Fang <[email protected]>
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
Co-authored-by: Johan Stenberg (MSFT) <[email protected]>
haagha pushed a commit that referenced this pull request Nov 19, 2024
* inital baseline commit to introduce new label for diff

* non-uploads changes

* CI-uncovered fixes (primarily examples)

* uploads additions

* Update specification/cognitiveservices/OpenAI.Inference/models/completions/chat_messages.tsp

Co-authored-by: Shawn Fang <[email protected]>

* Update specification/cognitiveservices/OpenAI.Inference/models/completions/chat_messages.tsp

Co-authored-by: Jose Alvarez <[email protected]>

* [OpenAI] providing feedback in the form of a PR for the `v2024_08_01_preview` release (#30749)

* ci checks and compile

* Adding Completions/options fields

* fixed nullability

* Added missing refusal field

* Adding MongoDB index_name

* Changed types for bytes in upload object

* Adding visibility for new uploadFile Parts ops

* Added supression for mp/df op

* removing auto sample gen for java

* Restoring for older versions ChatMessageContent

* Adding nullability for refusal in response chat message

* Adding release entries in the  file

* Another past type correction to prevent unnecessary CI redflags

* Adding nullable refusal to check

* formatter

* Example corrections

* Added missing examples for new file operations

* renamed body field

* Added missing azure_block_id to part upload and corrected examples

* Specified UploadPurpose and corrected comment

* Adjusted documentation for CreateUploadRequestPurpose

* Ran formatters and re-compiled

* Moved authentication field out of OnYourDataCommonChatExtensionConfiguration

* Specified authetincation type for MongoDB

---------

Co-authored-by: Shawn Fang <[email protected]>
Co-authored-by: Jose Alvarez <[email protected]>
Co-authored-by: Jose Alvarez <[email protected]>
digvijaymali94 pushed a commit to digvijaymali94/azure-rest-api-specs that referenced this pull request Dec 17, 2024
* inital baseline commit to introduce new label for diff

* non-uploads changes

* CI-uncovered fixes (primarily examples)

* uploads additions

* Update specification/cognitiveservices/OpenAI.Inference/models/completions/chat_messages.tsp

Co-authored-by: Shawn Fang <[email protected]>

* Update specification/cognitiveservices/OpenAI.Inference/models/completions/chat_messages.tsp

Co-authored-by: Jose Alvarez <[email protected]>

* [OpenAI] providing feedback in the form of a PR for the `v2024_08_01_preview` release (Azure#30749)

* ci checks and compile

* Adding Completions/options fields

* fixed nullability

* Added missing refusal field

* Adding MongoDB index_name

* Changed types for bytes in upload object

* Adding visibility for new uploadFile Parts ops

* Added supression for mp/df op

* removing auto sample gen for java

* Restoring for older versions ChatMessageContent

* Adding nullability for refusal in response chat message

* Adding release entries in the  file

* Another past type correction to prevent unnecessary CI redflags

* Adding nullable refusal to check

* formatter

* Example corrections

* Added missing examples for new file operations

* renamed body field

* Added missing azure_block_id to part upload and corrected examples

* Specified UploadPurpose and corrected comment

* Adjusted documentation for CreateUploadRequestPurpose

* Ran formatters and re-compiled

* Moved authentication field out of OnYourDataCommonChatExtensionConfiguration

* Specified authetincation type for MongoDB

---------

Co-authored-by: Shawn Fang <[email protected]>
Co-authored-by: Jose Alvarez <[email protected]>
Co-authored-by: Jose Alvarez <[email protected]>
digvijaymali94 pushed a commit to digvijaymali94/azure-rest-api-specs that referenced this pull request Dec 17, 2024
…-01-preview service releases (Azure#30909)

* inital baseline commit to introduce new label for diff

* non-uploads changes

* CI-uncovered fixes (primarily examples)

* uploads additions

* Update specification/cognitiveservices/OpenAI.Inference/models/completions/chat_messages.tsp

Co-authored-by: Shawn Fang <[email protected]>

* Update specification/cognitiveservices/OpenAI.Inference/models/completions/chat_messages.tsp

Co-authored-by: Jose Alvarez <[email protected]>

* [OpenAI] providing feedback in the form of a PR for the `v2024_08_01_preview` release (Azure#30749)

* ci checks and compile

* Adding Completions/options fields

* fixed nullability

* Added missing refusal field

* Adding MongoDB index_name

* Changed types for bytes in upload object

* Adding visibility for new uploadFile Parts ops

* Added supression for mp/df op

* removing auto sample gen for java

* Restoring for older versions ChatMessageContent

* Adding nullability for refusal in response chat message

* Adding release entries in the  file

* Another past type correction to prevent unnecessary CI redflags

* Adding nullable refusal to check

* formatter

* Example corrections

* Added missing examples for new file operations

* renamed body field

* Added missing azure_block_id to part upload and corrected examples

* Specified UploadPurpose and corrected comment

* Adjusted documentation for CreateUploadRequestPurpose

* Ran formatters and re-compiled

* Moved authentication field out of OnYourDataCommonChatExtensionConfiguration

* Specified authetincation type for MongoDB

* Updated docs for max_tokens and added new max_completion_tokens

* Tsp compile

* Added deprecated directive to max_tokens field

* Added back streamOptions to completion and chatcompletion options

* Tsp compile

* added parallel_tool_calls field to ThreadRun and ChatCompletions

* tsp compile for assistants and inference

* Added parallel_tool_calls to all assistants classes

* Added changes for reasoning token in completion usage

* ran formatter

* Fixed optionality of inline model and deprecation typo

* ThreadRun.parallelToolCalls is mandatory in OpenAI

* Added examples and readme entry for Assistants for new version

* compiled assistants

* Corrected json

* Added examples for v2024-09-01-preview and readme entry inference

* Adding TSP project files

* TSP compile

* CI checks and readme entry for generated file

* Update specification/cognitiveservices/OpenAI.Inference/models/completions/azure_content_filtering.tsp

Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>

* TSP compile

* Removed default from response model

* ci check for tsp validation

* Added 2024-10-01-preview to assistants service version

* Added missing entry for 10-01-preview assistants

* Corrected readme file

* Update specification/ai/OpenAI.Assistants/main.tsp

Co-authored-by: Johan Stenberg (MSFT) <[email protected]>

---------

Co-authored-by: Travis Wilson <[email protected]>
Co-authored-by: Travis Wilson <[email protected]>
Co-authored-by: Shawn Fang <[email protected]>
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
Co-authored-by: Johan Stenberg (MSFT) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants