Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review request for RecoveryServices to add version stable/2024-10-01 #30681

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

singhabh27
Copy link
Contributor

@singhabh27 singhabh27 commented Sep 23, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2024-04-01 to stable/2024-10-01.
Copy link

openapi-pipeline-app bot commented Sep 23, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Sep 23, 2024

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/recoveryservices/armrecoveryservices There is no API change compared with the previous version
JavaScript @azure/arm-recoveryservices There is no API change compared with the previous version
.Net Azure.ResourceManager.RecoveryServices https://apiview.dev/Assemblies/Review/f173f6364fc040c69cc0fc9dc95599fd?revisionId=fe1a6cbab3414d39b92bd5523f6a27a6
Python azure-mgmt-recoveryservices https://apiview.dev/Assemblies/Review/3b90dde0094d442da969d2a4ddbc32c7?revisionId=ff96bd9dc4ca4331801dbf0029b2887d
Java azure-resourcemanager-recoveryservices https://apiview.dev/Assemblies/Review/a1abc0f600d74935b7603cd6bc16db28?revisionId=42bdcc167447498dbd26ff6ee1112682
Swagger Microsoft.RecoveryServices https://apiview.dev/Assemblies/Review/87cb55db6e9f4146a1f242e528aece8b?revisionId=7c39f55f76344b228bf0f4a52b3f3049

@ms-bogdan-rotaru
Copy link

ms-bogdan-rotaru commented Sep 24, 2024

@singhabh27 Perhaps I'm missing something, but I don't see any notable difference between the new version and 2024-04-01. Can you please point out the difference(s) for the new version?

@ms-bogdan-rotaru ms-bogdan-rotaru added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 25, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 25, 2024
@singhabh27
Copy link
Contributor Author

@ms-bogdan-rotaru, the above PR is created for swagger completeness purpose. If we create a new API Version for any of below RP for any feature: recoveryservices, recoveryservicesbackup, recoveryservicessiterecovery, for swagger completeness, we have to make change in other 2 Repos.
#30681
#30682
#30307

@singhabh27 singhabh27 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required DoNotMerge <valid label in PR review process> use to hold merge after approval and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Sep 30, 2024
Copy link
Member

@rkmanda rkmanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 4, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Oct 21, 2024
@singhabh27 singhabh27 removed the no-recent-activity There has been no recent activity on this issue. label Oct 21, 2024
@singhabh27 singhabh27 added PublishToCustomers Acknowledgement the changes will be published to Azure customers. and removed DoNotMerge <valid label in PR review process> use to hold merge after approval labels Nov 4, 2024
@singhabh27
Copy link
Contributor Author

singhabh27 commented Nov 5, 2024

@rkmanda / @ms-bogdan-rotaru, pl. merge this PR.

@singhabh27
Copy link
Contributor Author

/pr RequestMerge

@singhabh27 singhabh27 merged commit 8830ff2 into Azure:main Nov 8, 2024
29 of 30 checks passed
digvijaymali94 pushed a commit to digvijaymali94/azure-rest-api-specs that referenced this pull request Dec 17, 2024
…zure#30681)

* Copy files from stable/2024-04-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-10-01

Updated the API version from stable/2024-04-01 to stable/2024-10-01.

* Added tag for 2024-10-01 in readme file

* Swagger PrettierCheck fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test RecoveryServices resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants