Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing APIs to complete RP-ARM SLA #3031

Merged
merged 6 commits into from
May 10, 2018
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"parameters": {
"iotHubName": "testHub",
"resourceGroupName": "myResourceGroup",
"api-version": "2018-04-01",
"subscriptionId": "91d12660-3dec-467a-be2a-213b5544ddc0"
},
"responses": {
"200": {
"body": {
"value": [
{
"endpointId": "id1",
"healthStatus": "healthy"
},
{
"endpointId": "id2",
"healthStatus": "unknown"
}
]
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{
"parameters": {
"iotHubName": "testHub",
"resourceGroupName": "myResourceGroup",
"api-version": "2018-04-01",
"subscriptionId": "91d12660-3dec-467a-be2a-213b5544ddc0",
"input": {
"routingSource": "DeviceMessages",
"message": {
"body": "Body of message",
"appProperties": "App Properties",
"systemProperties": "System Properties"
}
}
},
"responses": {
"200": {
"body": {
"routes": [
{
"properties": {
"name": "Route id",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"source": "DeviceMessages",
"endpointNames": ["id1", "id2"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response. Here is another issue I found - this array is defined to have max length of 1: https://github.com/Azure/azure-rest-api-specs/pull/3031/files#diff-54dafbe4198f749bac837b913372bcddR2417

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch !

"isEnabled": true
}
}
]
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
{
"parameters": {
"iotHubName": "testHub",
"resourceGroupName": "myResourceGroup",
"api-version": "2018-04-01",
"subscriptionId": "91d12660-3dec-467a-be2a-213b5544ddc0",
"input": {
"message": {
"body": "Body of message",
"appProperties": "App Properties",
"systemProperties": "System Properties"
},
"route": {
"name": "Route id",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

"source": "DeviceMessages",
"endpointNames": [
"id1",
"id2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comment - please also fix it here.

],
"isEnabled": true
}
}
},
"responses": {
"200": {
"body": {
"result": "false",
"details": {
"compilationErrors": [
{
"message": "string response",
"severity": "error",
"location": {
"start": {
"line": 12,
"column": 12
},
"end": {
"line": 12,
"column": 24
}
}
}
]
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"parameters": {
"api-version": "2018-04-01",
"subscriptionId": "91d12660-3dec-467a-be2a-213b5544ddc0"
},
"responses": {
"200": {
"body": {
"value": [
{
"id" : "/subscription/91d12660-3dec-467a-be2a-213b5544ddc0/providers/Microsoft.Devices/usages/freeHubCount",
"type": "/subscription/91d12660-3dec-467a-be2a-213b5544ddc0/providers/Microsoft.Devices/usages",
"unit": "count",
"currentValue": 1,
"limit": 1,
"name": {
"value": "FreeHubCount",
"localizedValue": "Free Hub Count"
}
}
]
}
}
}
}
Loading