Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFactory] blob events trigger #3008

Merged
merged 3 commits into from
May 16, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,65 @@
"typeProperties"
]
},
"BlobEventsTrigger":
{
"description": "Trigger that runs everytime a Blob event occurs.",
"type": "object",
"allOf": [
{
"$ref": "#/definitions/MultiplePipelineTrigger"
}
],
"properties": {
"typeProperties":
{
"description": "Blob Events Trigger properties",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add dot at the end of description. The linter catches these as errors.

"x-ms-client-flatten": true,
"properties": {
"blobPath": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marstr This property will be changed, please do not merge yet.

"description": "path to container, folder, blob, or file extension for which events can trigger the pipeline.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start the description with upper case

"type": "string"
},
"events": {
"description": "the type of events for which we want to trigger the pipeline.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upper case

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe: "The type of events that cause this trigger to fire."

"$ref": "#/definitions/BlobEventTypes"
},
"scope": {
"description": "the resource id of the Storage Account.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upper case. "ARM resource ID" instead of "resource id"

"type": "string"
},
"maxConcurrency": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add validation for this - should be more than 0 at least, and do you have max for this value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added minimum of 1. Max is configurable, so not specifying.

"description": "the max number of parallel events to handle when it is triggered.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upper case. "when triggered."

"type": "integer"
}
},
"required": [
"blobPath",
"events",
"scope",
"maxConcurrency"
]
}
},
"required": [
"typeProperties"
]
},
"BlobEventTypes": {
"type": "array",
"items": {
"type": "string",
"enum": [
"blobCreated",
"blobDeleted"
],
"x-ms-enum": {
"name": "BlobEventTypes",
"modelAsString": true
}
},
"description": "blob event types"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upper case and dot.

},
"TumblingWindowTrigger": {
"description": "Trigger that schedules pipeline runs for all fixed time interval windows from a start time without gaps and also supports backfill scenarios (when start time is in the past).",
"type": "object",
Expand Down