-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added x-ms-azure-resource for TrackedResource, and added default values for 2 enums. #2953
Conversation
… of 2018-01-01 version.
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-libraries-for-javaNothing to generate for azure-libraries-for-java |
Automation for azure-sdk-for-nodeA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
AutoRest linter results for SDK Related Validation Errors/WarningsThese errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns. File: specification/eventgrid/resource-manager/readme.md
|
AutoRest linter results for ARM Related Validation Errors/WarningsThese errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns. File: specification/eventgrid/resource-manager/readme.md
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified that this PR does not introduce any new linter errors:
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/371706779
@kalyanaj reached out offline with some context, mentioning that these changes are derived from an earlier PR. Before further review, I'd like to see the earlier conversation so as not to duplicate any conversations around how the default
property is added here.
Ready for me to merge, @kalyanaj? |
Thanks @marstr for the review. Yes, this is ready to merge. |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger