sdk, tspconfig / client.tsp for vmware #29308
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
Swagger Generation Artifacts
|
Generated ApiView
|
weidongxu-microsoft
force-pushed
the
java_tsp-conf_vmware
branch
from
289651e to
80423b0
Compare
weidongxu-microsoft
changed the title
AzureRestAPISpecReview
removed
BreakingChangeReviewRequired
markcowl
reviewed
Aug 7, 2024
|
|
||
| // flatten | ||
| #suppress "deprecated" "property flatten for SDK backward compatibility" | ||
| @@flattenProperty(Azure.ResourceManager.TrackedResource.properties); |
There was a problem hiding this comment.
You should just turn on flattening for the spec rather than having all of these.
There was a problem hiding this comment.
I assume the flattening on the spec only apply to the Swagger output? Does it add @flattenProperty decorate (which is the only one recognized by TCGC).
markcowl
requested changes
Aug 7, 2024
| update is ArmCustomPatchAsync<WorkloadNetworkSegment, WorkloadNetworkSegment>; | ||
| @tag("WorkloadNetworkSegments") | ||
| @autoRoute | ||
| updateSegments is ArmCustomPatchAsync< |
There was a problem hiding this comment.
This can be replaced with ArmResourcePatchAsync<WorkloadNetworkSegment, WorkloadNetworkSegmentProperties>;
There was a problem hiding this comment.
I can do this in a follow-up PR.
Here I've reverted everything in routes.tsp that not critical to typespec emitter. The only remaining change is LocationHeader -> ArmLroLocationHeader, which is critical for LroMetadata.
weidongxu-microsoft
force-pushed
the
java_tsp-conf_vmware
branch
from
e3adfef to
fcf7f36
Compare
weidongxu-microsoft
changed the title
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remaining issue
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.