Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency @azure-tools/typespec-azure-portal-core #29071

Merged
merged 4 commits into from
May 14, 2024

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder commented May 10, 2024

  • Specs may start using this package in their TSP sources
  • Versions and ships the same as other packages in typespec-azure
  • Introduces no new dependencies

Copy link

openapi-pipeline-app bot commented May 10, 2024

PR validation pipeline restarted successfully. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

Copy link

openapi-pipeline-app bot commented May 10, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️⌛Automated merging requirements met pending [Detail]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 10, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@mikeharder mikeharder requested review from markcowl and removed request for konrad-jamrozik and weshaggard May 10, 2024 22:09
Copy link

openapi-pipeline-app bot commented May 10, 2024

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@markcowl
Copy link
Member

@mikeharder We will want to do this in the RPSaaSMaster / RPSaaSDev branches too

@mikeharder
Copy link
Member Author

@mikeharder We will want to do this in the RPSaaSMaster / RPSaaSDev branches too

All changes to common files (like package.json) are automatically synced between public/main and RPSaaSMaster and RPSaaSDev. The merge PRs are created once a day (or manually triggered), and need to be approved by someone (feel free to review and approve yourself anytime).

@mikeharder mikeharder merged commit e07876f into Azure:main May 14, 2024
34 of 40 checks passed
@mikeharder mikeharder deleted the typespec-azure-portal-core branch May 14, 2024 07:05
Francisco-Gamino pushed a commit to Francisco-Gamino/azure-rest-api-specs that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants