Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Security: fix bad chars with 2023-12-01-preview #28984

Conversation

Nessya123
Copy link
Contributor

@Nessya123 Nessya123 commented May 6, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • fix a minor bug with description text that was with bad chars:

image

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented May 6, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented May 6, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
Compared specs (v0.10.8) new version base version
automations.json 2023-12-01-preview(c1fd7ff) 2023-12-01-preview(main)
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-composite-v3 package-composite-v3(c1fd7ff) package-composite-v3(main)

The following errors/warnings exist before current PR submission:

Rule Message
ResourceNameRestriction The resource name parameter 'automationName' should be defined with a 'pattern' restriction.
Location: Microsoft.Security/preview/2023-12-01-preview/automations.json#L118
ResourceNameRestriction The resource name parameter 'automationName' should be defined with a 'pattern' restriction.
Location: Microsoft.Security/preview/2023-12-01-preview/automations.json#L298
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-12-01-preview/automations.json#L49
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-12-01-preview/automations.json#L88
⚠️ RequiredReadOnlySystemData The response of operation:'Automations_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Security/preview/2023-12-01-preview/automations.json#L119
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-12-01-preview/automations.json#L130
⚠️ RequiredReadOnlySystemData The response of operation:'Automations_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Security/preview/2023-12-01-preview/automations.json#L159
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-12-01-preview/automations.json#L176
⚠️ RequiredReadOnlySystemData The response of operation:'Automations_Update' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Security/preview/2023-12-01-preview/automations.json#L214
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-12-01-preview/automations.json#L225
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-12-01-preview/automations.json#L268
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-12-01-preview/automations.json#L310
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Security/preview/2023-12-01-preview/automations.json#L406
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Security/preview/2023-12-01-preview/automations.json#L607
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Security/preview/2023-12-01-preview/automations.json#L745
️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/security/resource-manager/readme.md
tag: specification/security/resource-manager/readme.md#tag-package-composite-v3
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 6, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from ba1062b54f9017ef01b3eab4bb60247945e49ea4. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.SecurityCenter [Preview SDK Changes]
    • Azure.ResourceManager.SecurityCenter.1.2.0-alpha.20240507.1.nupkg
    info	[Changelog]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from ba1062b54f9017ef01b3eab4bb60247945e49ea4. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/security/armsecurity [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Function `*ContactsClient.Create` parameter(s) have been changed from `(context.Context, string, Contact, *ContactsClientCreateOptions)` to `(context.Context, SecurityContactName, Contact, *ContactsClientCreateOptions)`
    info	[Changelog] - Function `*ContactsClient.Delete` parameter(s) have been changed from `(context.Context, string, *ContactsClientDeleteOptions)` to `(context.Context, SecurityContactName, *ContactsClientDeleteOptions)`
    info	[Changelog] - Function `*ContactsClient.Get` parameter(s) have been changed from `(context.Context, string, *ContactsClientGetOptions)` to `(context.Context, SecurityContactName, *ContactsClientGetOptions)`
    info	[Changelog] - Type of `ContactPropertiesNotificationsByRole.Roles` has been changed from `[]*Roles` to `[]*SecurityContactRole`
    info	[Changelog] - Type of `DefenderCspmAwsOfferingVMScanners.Configuration` has been changed from `*DefenderCspmAwsOfferingVMScannersConfiguration` to `*VMScannersBaseConfiguration`
    info	[Changelog] - Type of `DefenderCspmGcpOfferingVMScanners.Configuration` has been changed from `*DefenderCspmGcpOfferingVMScannersConfiguration` to `*VMScannersBaseConfiguration`
    info	[Changelog] - Type of `DefenderFoDatabasesAwsOfferingArcAutoProvisioning.Configuration` has been changed from `*DefenderFoDatabasesAwsOfferingArcAutoProvisioningConfiguration` to `*ArcAutoProvisioningConfiguration`
    info	[Changelog] - Type of `DefenderForDatabasesGcpOfferingArcAutoProvisioning.Configuration` has been changed from `*DefenderForDatabasesGcpOfferingArcAutoProvisioningConfiguration` to `*ArcAutoProvisioningConfiguration`
    info	[Changelog] - Type of `DefenderForServersAwsOfferingArcAutoProvisioning.Configuration` has been changed from `*DefenderForServersAwsOfferingArcAutoProvisioningConfiguration` to `*ArcAutoProvisioningConfiguration`
    info	[Changelog] - Type of `DefenderForServersAwsOfferingVMScanners.Configuration` has been changed from `*DefenderForServersAwsOfferingVMScannersConfiguration` to `*VMScannersBaseConfiguration`
    info	[Changelog] - Type of `DefenderForServersGcpOfferingArcAutoProvisioning.Configuration` has been changed from `*DefenderForServersGcpOfferingArcAutoProvisioningConfiguration` to `*ArcAutoProvisioningConfiguration`
    info	[Changelog] - Type of `DefenderForServersGcpOfferingVMScanners.Configuration` has been changed from `*DefenderForServersGcpOfferingVMScannersConfiguration` to `*VMScannersBaseConfiguration`
    info	[Changelog] - `OfferingTypeDefenderForDevOpsAzureDevOps`, `OfferingTypeDefenderForDevOpsGitLab`, `OfferingTypeDefenderForDevOpsGithub`, `OfferingTypeInformationProtectionAws` from enum `OfferingType` has been removed
    info	[Changelog] - Enum `Roles` has been removed
    info	[Changelog] - Function `NewCenterClient` has been removed
    info	[Changelog] - Function `*CenterClient.GetSensitivitySettings` has been removed
    info	[Changelog] - Function `*CenterClient.UpdateSensitivitySettings` has been removed
    info	[Changelog] - Function `*ClientFactory.NewCenterClient` has been removed
    info	[Changelog] - Function `*DefenderForDevOpsAzureDevOpsOffering.GetCloudOffering` has been removed
    info	[Changelog] - Function `*DefenderForDevOpsGitLabOffering.GetCloudOffering` has been removed
    info	[Changelog] - Function `*DefenderForDevOpsGithubOffering.GetCloudOffering` has been removed
    info	[Changelog] - Function `*InformationProtectionAwsOffering.GetCloudOffering` has been removed
    info	[Changelog] - Struct `ContactPropertiesAlertNotifications` has been removed
    info	[Changelog] - Struct `DefenderCspmAwsOfferingVMScannersConfiguration` has been removed
    info	[Changelog] - Struct `DefenderCspmGcpOfferingVMScannersConfiguration` has been removed
    info	[Changelog] - Struct `DefenderFoDatabasesAwsOfferingArcAutoProvisioningConfiguration` has been removed
    info	[Changelog] - Struct `DefenderForContainersAwsOfferingContainerVulnerabilityAssessment` has been removed
    info	[Changelog] - Struct `DefenderForContainersAwsOfferingContainerVulnerabilityAssessmentTask` has been removed
    info	[Changelog] - Struct `DefenderForContainersAwsOfferingKubernetesScubaReader` has been removed
    info	[Changelog] - Struct `DefenderForDatabasesGcpOfferingArcAutoProvisioningConfiguration` has been removed
    info	[Changelog] - Struct `DefenderForDevOpsAzureDevOpsOffering` has been removed
    info	[Changelog] - Struct `DefenderForDevOpsGitLabOffering` has been removed
    info	[Changelog] - Struct `DefenderForDevOpsGithubOffering` has been removed
    info	[Changelog] - Struct `DefenderForServersAwsOfferingArcAutoProvisioningConfiguration` has been removed
    info	[Changelog] - Struct `DefenderForServersAwsOfferingVMScannersConfiguration` has been removed
    info	[Changelog] - Struct `DefenderForServersGcpOfferingArcAutoProvisioningConfiguration` has been removed
    info	[Changelog] - Struct `DefenderForServersGcpOfferingVMScannersConfiguration` has been removed
    info	[Changelog] - Struct `InformationProtectionAwsOffering` has been removed
    info	[Changelog] - Struct `InformationProtectionAwsOfferingInformationProtection` has been removed
    info	[Changelog] - Field `AlertNotifications` of struct `ContactProperties` has been removed
    info	[Changelog] - Field `AutoProvisioning`, `ContainerVulnerabilityAssessment`, `ContainerVulnerabilityAssessmentTask`, `EnableContainerVulnerabilityAssessment`, `KubernetesScubaReader`, `ScubaExternalID` of struct `DefenderForContainersAwsOffering` has been removed
    info	[Changelog] - Field `AuditLogsAutoProvisioningFlag`, `DefenderAgentAutoProvisioningFlag`, `PolicyAgentAutoProvisioningFlag` of struct `DefenderForContainersGcpOffering` has been removed
    info	[Changelog] - Field `SystemData` of struct `ResourceAutoGenerated2` has been removed
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `EventSourceAttackPaths`, `EventSourceAttackPathsSnapshot` added to enum type `EventSource`
    info	[Changelog] - New enum type `MinimalRiskLevel` with values `MinimalRiskLevelCritical`, `MinimalRiskLevelHigh`, `MinimalRiskLevelLow`, `MinimalRiskLevelMedium`
    info	[Changelog] - New enum type `SecurityContactName` with values `SecurityContactNameDefault`
    info	[Changelog] - New enum type `SecurityContactRole` with values `SecurityContactRoleAccountAdmin`, `SecurityContactRoleContributor`, `SecurityContactRoleOwner`, `SecurityContactRoleServiceAdmin`
    info	[Changelog] - New enum type `SourceType` with values `SourceTypeAlert`, `SourceTypeAttackPath`
    info	[Changelog] - New function `*AutomationsClient.Update(context.Context, string, string, AutomationUpdateModel, *AutomationsClientUpdateOptions) (AutomationsClientUpdateResponse, error)`
    info	[Changelog] - New function `*SensitivitySettingsClient.CreateOrUpdate(context.Context, UpdateSensitivitySettingsRequest, *SensitivitySettingsClientCreateOrUpdateOptions) (SensitivitySettingsClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*SensitivitySettingsClient.Get(context.Context, *SensitivitySettingsClientGetOptions) (SensitivitySettingsClientGetResponse, error)`
    info	[Changelog] - New function `*NotificationsSource.GetNotificationsSource() *NotificationsSource`
    info	[Changelog] - New function `*NotificationsSourceAlert.GetNotificationsSource() *NotificationsSource`
    info	[Changelog] - New function `*NotificationsSourceAttackPath.GetNotificationsSource() *NotificationsSource`
    info	[Changelog] - New struct `ArcAutoProvisioning`
    info	[Changelog] - New struct `ArcAutoProvisioningAws`
    info	[Changelog] - New struct `ArcAutoProvisioningConfiguration`
    info	[Changelog] - New struct `ArcAutoProvisioningGcp`
    info	[Changelog] - New struct `AutomationUpdateModel`
    info	[Changelog] - New struct `DefenderForContainersAwsOfferingKubernetesDataCollection`
    info	[Changelog] - New struct `DefenderForContainersAwsOfferingVMScanners`
    info	[Changelog] - New struct `DefenderForContainersGcpOfferingVMScanners`
    info	[Changelog] - New struct `DevOpsCapability`
    info	[Changelog] - New struct `NotificationsSourceAlert`
    info	[Changelog] - New struct `NotificationsSourceAttackPath`
    info	[Changelog] - New struct `VMScannersAws`
    info	[Changelog] - New struct `VMScannersBase`
    info	[Changelog] - New struct `VMScannersBaseConfiguration`
    info	[Changelog] - New struct `VMScannersGcp`
    info	[Changelog] - New field `IsTrustedServiceEnabled` in struct `AutomationActionEventHub`
    info	[Changelog] - New field `IsEnabled`, `NotificationsSources` in struct `ContactProperties`
    info	[Changelog] - New field `CloudRoleArn` in struct `DefenderCspmAwsOfferingVMScanners`
    info	[Changelog] - New field `DataCollectionExternalID`, `EnableAuditLogsAutoProvisioning`, `EnableDefenderAgentAutoProvisioning`, `EnablePolicyAgentAutoProvisioning`, `KubernetesDataCollection`, `VMScanners` in struct `DefenderForContainersAwsOffering`
    info	[Changelog] - New field `EnableAuditLogsAutoProvisioning`, `EnableDefenderAgentAutoProvisioning`, `EnablePolicyAgentAutoProvisioning`, `VMScanners` in struct `DefenderForContainersGcpOffering`
    info	[Changelog] - New field `CloudRoleArn` in struct `DefenderForServersAwsOfferingVMScanners`
    info	[Changelog] - New field `Capabilities` in struct `DevOpsConfigurationProperties`
    info	[Changelog] - New field `SystemData` in struct `ResourceAutoGenerated`
    info	[Changelog]
    info	[Changelog] Total 63 breaking change(s), 62 additive change(s).
    Present SDK breaking changes suppressions
    No suppression file added.
    Absent SDK breaking changes suppressions
    - Enum `Roles` has been removed
    - Field `AlertNotifications` of struct `ContactProperties` has been removed
    - Field `AuditLogsAutoProvisioningFlag`, `DefenderAgentAutoProvisioningFlag`, `PolicyAgentAutoProvisioningFlag` of struct `DefenderForContainersGcpOffering` has been removed
    - Field `AutoProvisioning`, `ContainerVulnerabilityAssessment`, `ContainerVulnerabilityAssessmentTask`, `EnableContainerVulnerabilityAssessment`, `KubernetesScubaReader`, `ScubaExternalID` of struct `DefenderForContainersAwsOffering` has been removed
    - Field `SystemData` of struct `ResourceAutoGenerated2` has been removed
    - Function `*CenterClient.GetSensitivitySettings` has been removed
    - Function `*CenterClient.UpdateSensitivitySettings` has been removed
    - Function `*ClientFactory.NewCenterClient` has been removed
    - Function `*ContactsClient.Create` parameter(s) have been changed from `(context.Context, string, Contact, *ContactsClientCreateOptions)` to `(context.Context, SecurityContactName, Contact, *ContactsClientCreateOptions)`
    - Function `*ContactsClient.Delete` parameter(s) have been changed from `(context.Context, string, *ContactsClientDeleteOptions)` to `(context.Context, SecurityContactName, *ContactsClientDeleteOptions)`
    - Function `*ContactsClient.Get` parameter(s) have been changed from `(context.Context, string, *ContactsClientGetOptions)` to `(context.Context, SecurityContactName, *ContactsClientGetOptions)`
    - Function `*DefenderForDevOpsAzureDevOpsOffering.GetCloudOffering` has been removed
    - Function `*DefenderForDevOpsGitLabOffering.GetCloudOffering` has been removed
    - Function `*DefenderForDevOpsGithubOffering.GetCloudOffering` has been removed
    - Function `*InformationProtectionAwsOffering.GetCloudOffering` has been removed
    - Function `NewCenterClient` has been removed
    - Struct `ContactPropertiesAlertNotifications` has been removed
    - Struct `DefenderCspmAwsOfferingVMScannersConfiguration` has been removed
    - Struct `DefenderCspmGcpOfferingVMScannersConfiguration` has been removed
    - Struct `DefenderFoDatabasesAwsOfferingArcAutoProvisioningConfiguration` has been removed
    - Struct `DefenderForContainersAwsOfferingContainerVulnerabilityAssessmentTask` has been removed
    - Struct `DefenderForContainersAwsOfferingContainerVulnerabilityAssessment` has been removed
    - Struct `DefenderForContainersAwsOfferingKubernetesScubaReader` has been removed
    - Struct `DefenderForDatabasesGcpOfferingArcAutoProvisioningConfiguration` has been removed
    - Struct `DefenderForDevOpsAzureDevOpsOffering` has been removed
    - Struct `DefenderForDevOpsGitLabOffering` has been removed
    - Struct `DefenderForDevOpsGithubOffering` has been removed
    - Struct `DefenderForServersAwsOfferingArcAutoProvisioningConfiguration` has been removed
    - Struct `DefenderForServersAwsOfferingVMScannersConfiguration` has been removed
    - Struct `DefenderForServersGcpOfferingArcAutoProvisioningConfiguration` has been removed
    - Struct `DefenderForServersGcpOfferingVMScannersConfiguration` has been removed
    - Struct `InformationProtectionAwsOfferingInformationProtection` has been removed
    - Struct `InformationProtectionAwsOffering` has been removed
    - Type of `ContactPropertiesNotificationsByRole.Roles` has been changed from `[]*Roles` to `[]*SecurityContactRole`
    - Type of `DefenderCspmAwsOfferingVMScanners.Configuration` has been changed from `*DefenderCspmAwsOfferingVMScannersConfiguration` to `*VMScannersBaseConfiguration`
    - Type of `DefenderCspmGcpOfferingVMScanners.Configuration` has been changed from `*DefenderCspmGcpOfferingVMScannersConfiguration` to `*VMScannersBaseConfiguration`
    - Type of `DefenderFoDatabasesAwsOfferingArcAutoProvisioning.Configuration` has been changed from `*DefenderFoDatabasesAwsOfferingArcAutoProvisioningConfiguration` to `*ArcAutoProvisioningConfiguration`
    - Type of `DefenderForDatabasesGcpOfferingArcAutoProvisioning.Configuration` has been changed from `*DefenderForDatabasesGcpOfferingArcAutoProvisioningConfiguration` to `*ArcAutoProvisioningConfiguration`
    - Type of `DefenderForServersAwsOfferingArcAutoProvisioning.Configuration` has been changed from `*DefenderForServersAwsOfferingArcAutoProvisioningConfiguration` to `*ArcAutoProvisioningConfiguration`
    - Type of `DefenderForServersAwsOfferingVMScanners.Configuration` has been changed from `*DefenderForServersAwsOfferingVMScannersConfiguration` to `*VMScannersBaseConfiguration`
    - Type of `DefenderForServersGcpOfferingArcAutoProvisioning.Configuration` has been changed from `*DefenderForServersGcpOfferingArcAutoProvisioningConfiguration` to `*ArcAutoProvisioningConfiguration`
    - Type of `DefenderForServersGcpOfferingVMScanners.Configuration` has been changed from `*DefenderForServersGcpOfferingVMScannersConfiguration` to `*VMScannersBaseConfiguration`
    - `OfferingTypeDefenderForDevOpsAzureDevOps`, `OfferingTypeDefenderForDevOpsGitLab`, `OfferingTypeDefenderForDevOpsGithub`, `OfferingTypeInformationProtectionAws` from enum `OfferingType` has been removed
    Parse Suppression File Errors
    No suppression file added.
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from ba1062b54f9017ef01b3eab4bb60247945e49ea4. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh]  notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
    cmderr	[automation_init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
    cmderr	[automation_init.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-security [Preview SDK Changes] Breaking Change Detected
    • azure-mgmt-security-6.0.0.zip
    • azure_mgmt_security-6.0.0-py3-none-any.whl
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation HealthReportsOperations.get
    info	[Changelog]   - Added operation PricingsOperations.delete
    info	[Changelog]   - Added operation group AzureDevOpsOrgsOperations
    info	[Changelog]   - Added operation group AzureDevOpsProjectsOperations
    info	[Changelog]   - Added operation group AzureDevOpsReposOperations
    info	[Changelog]   - Added operation group DevOpsConfigurationsOperations
    info	[Changelog]   - Added operation group DevOpsOperationResultsOperations
    info	[Changelog]   - Added operation group GitHubOwnersOperations
    info	[Changelog]   - Added operation group GitHubReposOperations
    info	[Changelog]   - Added operation group GitLabGroupsOperations
    info	[Changelog]   - Added operation group GitLabProjectsOperations
    info	[Changelog]   - Added operation group GitLabSubgroupsOperations
    info	[Changelog]   - Added operation group SensitivitySettingsOperations
    info	[Changelog]   - Added operation group ServerVulnerabilityAssessmentsSettingsOperations
    info	[Changelog]   - Model AwsEnvironmentData has a new parameter scan_interval
    info	[Changelog]   - Model DefenderCspmAwsOffering has a new parameter ciem
    info	[Changelog]   - Model DefenderCspmAwsOffering has a new parameter mdc_containers_agentless_discovery_k8_s
    info	[Changelog]   - Model DefenderCspmAwsOffering has a new parameter mdc_containers_image_assessment
    info	[Changelog]   - Model DefenderCspmGcpOffering has a new parameter ciem_discovery
    info	[Changelog]   - Model DefenderCspmGcpOffering has a new parameter data_sensitivity_discovery
    info	[Changelog]   - Model DefenderCspmGcpOffering has a new parameter mdc_containers_agentless_discovery_k8_s
    info	[Changelog]   - Model DefenderCspmGcpOffering has a new parameter mdc_containers_image_assessment
    info	[Changelog]   - Model DefenderCspmGcpOffering has a new parameter vm_scanners
    info	[Changelog]   - Model DefenderForContainersAwsOffering has a new parameter mdc_containers_agentless_discovery_k8_s
    info	[Changelog]   - Model DefenderForContainersAwsOffering has a new parameter mdc_containers_image_assessment
    info	[Changelog]   - Model DefenderForContainersGcpOffering has a new parameter mdc_containers_agentless_discovery_k8_s
    info	[Changelog]   - Model DefenderForContainersGcpOffering has a new parameter mdc_containers_image_assessment
    info	[Changelog]   - Model GcpProjectEnvironmentData has a new parameter scan_interval
    info	[Changelog]   - Model HealthReport has a new parameter affected_defenders_sub_plans
    info	[Changelog]   - Model HealthReport has a new parameter report_additional_data
    info	[Changelog]   - Model Pricing has a new parameter enforce
    info	[Changelog]   - Model Pricing has a new parameter inherited
    info	[Changelog]   - Model Pricing has a new parameter inherited_from
    info	[Changelog]   - Model Pricing has a new parameter resources_coverage_status
    info	[Changelog]   - Model Status has a new parameter last_scanned_date
    info	[Changelog]   - Model Status has a new parameter reason
    info	[Changelog]   - Operation PricingsOperations.list has a new optional parameter filter
    info	[Changelog]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog]   - Operation PricingsOperations.get has a new required parameter scope_id
    info	[Changelog]   - Operation PricingsOperations.list has a new required parameter scope_id
    info	[Changelog]   - Operation PricingsOperations.update has a new required parameter scope_id
    info	[Changelog]   - Removed operation group IngestionSettingsOperations
    Present SDK breaking changes suppressions
    No suppression file added.
    Absent SDK breaking changes suppressions
    - Operation PricingsOperations.get has a new required parameter scope_id
    - Operation PricingsOperations.list has a new required parameter scope_id
    - Operation PricingsOperations.update has a new required parameter scope_id
    - Removed operation group IngestionSettingsOperations
    Parse Suppression File Errors
    No suppression file added.
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from ba1062b54f9017ef01b3eab4bb60247945e49ea4. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-security [Preview SDK Changes]
    • azure-arm-security-6.0.0-beta.5.tgz
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from ba1062b54f9017ef01b3eab4bb60247945e49ea4. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-security [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-security-1.0.0-beta.7.jar
    • azure-resourcemanager-security-1.0.0-beta.7-sources.jar
️❌ azure-resource-manager-schemas failed [Detail]
  • Failed in generating from ba1062b54f9017ef01b3eab4bb60247945e49ea4. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh]
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    warn	No file changes detected after generation
  • security/resource-manager
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning in generating from ba1062b54f9017ef01b3eab4bb60247945e49ea4. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.security.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@msyyc
Copy link
Member

msyyc commented May 6, 2024

Approved for python since the breakings are not related with this PR

@madhura-np madhura-np added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 6, 2024
@kazrael2119
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@madhura-np madhura-np merged commit 8eb53a9 into main May 8, 2024
29 of 32 checks passed
@madhura-np madhura-np deleted the Nessya123-security-Microsoft.Security-2023-12-01-preview-update branch May 8, 2024 14:52
Francisco-Gamino pushed a commit to Francisco-Gamino/azure-rest-api-specs that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Go-Sdk BreakingChange-Go-Sdk-Approved BreakingChange-Python-Sdk BreakingChange-Python-Sdk-Approved ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants