adding MessageAnalysisCompletedEvent to EG SDk #28912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
| Compared specs (v0.10.12) | new version | base version |
|---|---|---|
| AzureCommunicationServices.json | 2018-01-01(b2f9dcb) | 2018-01-01(main) |
| SystemEvents.json | 2024-01-01(b2f9dcb) | 2024-01-01(main) |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 12 Errors, 0 Warnings failed [Detail]
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
"tag":"package-2023-06-01-preview", "details":"Semantic violation: Discriminator must be a required property. (components > schemas > MediaJobOutput) discriminator: propertyName: \u001b[32m'@odata.type'\u001b[39m " |
|
|
"tag":"package-2023-06-01-preview", "details":"Process() cancelled due to failure" |
|
|
"tag":"package-2023-06-01-preview", "details":"!Error: Semantic validation failed. There was some errors" |
|
|
"tag":"package-2023-06-01-preview", "details":"Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing." |
|
|
"tag":"package-2023-10-01-preview", "details":"Semantic violation: Discriminator must be a required property. (components > schemas > MediaJobOutput) discriminator: propertyName: \u001b[32m'@odata.type'\u001b[39m " |
|
|
"tag":"package-2023-10-01-preview", "details":"Process() cancelled due to failure" |
|
|
"tag":"package-2023-10-01-preview", "details":"!Error: Semantic validation failed. There was some errors" |
|
|
"tag":"package-2023-10-01-preview", "details":"Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing." |
|
|
"tag":"package-2018-01", "details":"Semantic violation: Discriminator must be a required property. (components > schemas > MediaJobOutput) discriminator: propertyName: \u001b[32m'@odata.type'\u001b[39m " |
|
|
"tag":"package-2018-01", "details":"Process() cancelled due to failure" |
|
|
"tag":"package-2018-01", "details":"!Error: Semantic validation failed. There was some errors" |
|
|
"tag":"package-2018-01", "details":"Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing." |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌SpellCheck: 8 Errors, 0 Warnings failed [Detail]
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
| }, | ||
| "confidenceScore": { | ||
| "description": "The confidence score of the language detected", | ||
| "type": "string" |
There was a problem hiding this comment.
Why is this being defined as a string? The example shows a number.
There was a problem hiding this comment.
I think its because it can either long or int format
There was a problem hiding this comment.
The example does not show a string. Please investigate whether it should be a string or a number.
There was a problem hiding this comment.
also this will be something better answered/discussed on the review day
There was a problem hiding this comment.
If it is meant to be a string, can you please update the example?
|
We no longer accept swagger PRs for system events. Instead, all new events need to be written in Typespec. For ACS, that would mean updating this file https://github.com/Azure/azure-rest-api-specs/blob/main/specification/eventgrid/Azure.Messaging.EventGrid.SystemEvents/Microsoft.Communication/AzureCommunicationServices.tsp |
| @@ -1673,6 +1673,68 @@ | |||
| } | |||
| } | |||
| }, | |||
| "AcsMessageAnalysisCompleted": { | |||
There was a problem hiding this comment.
This needs to end with EventData
...entgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json
Show resolved
Hide resolved
| "$ref": "#/definitions/AcsMessageLanguageDetection", | ||
| "type": "object" | ||
| }, | ||
| "sentiments": { |
| "description": "The intent of the analysed message", | ||
| "type": "string" | ||
| }, | ||
| "keyPhraseExtraction": { |
…MessageAnalysisCompletedEvents
l0lawrence
reviewed
Jun 21, 2024
| /** Schema of the Data property of an EventGridEvent for a Microsoft.Communication.AdvancedMessageAnalysisCompleted event. */ | ||
| interface AcsMessageAnalysisCompletedEventData extends AcsMessageEventData { | ||
| /** The original message received. */ | ||
| originalMessage: string; |
There was a problem hiding this comment.
Just checking -> Are these properties all required?
There was a problem hiding this comment.
*edit: I'm asking if each property key is required in the event - (i.e can you send the event without the intentAnalysis key in the json payload)
| @@ -1160,6 +1160,28 @@ model AcsMessageReceivedEventData extends AcsMessageEventData { | |||
| interactive: AcsMessageInteractiveContent; | |||
| } | |||
|
|
|||
| /** Schema of the Data property of an EventGridEvent for a Microsoft.Communication.AdvancedMessageAnalysisCompleted event. */ | |||
| interface AcsMessageAnalysisCompletedEventData extends AcsMessageEventData { | |||
| /** The description of the analysis. */ | ||
| description: string; | ||
| } | ||
|
|
There was a problem hiding this comment.
Thanks for the TypeSpec! Would you please also compile the TypeSpec and add the generated SystemEvents.json to this PR: following the instructions here
sarangan12
reviewed
Jun 21, 2024
| /** Message Analysis Sentiment */ | ||
| model AcsMessageSentiment { | ||
| /** The score of the analysis. */ | ||
| score: number; |
There was a problem hiding this comment.
I do not think this should be number. It is not allowed. It should be int32
sarangan12
reviewed
Jun 21, 2024
| @@ -1160,6 +1160,28 @@ model AcsMessageReceivedEventData extends AcsMessageEventData { | |||
| interactive: AcsMessageInteractiveContent; | |||
| } | |||
|
|
|||
| /** Schema of the Data property of an EventGridEvent for a Microsoft.Communication.AdvancedMessageAnalysisCompleted event. */ | |||
| interface AcsMessageAnalysisCompletedEventData extends AcsMessageEventData { | |||
There was a problem hiding this comment.
The following lines need to be added to the client.tsp file also for successful generation
@@usage(Microsoft.EventGrid.SystemEvents.AcsMessageAnalysisCompletedEventData,
Usage.output
);
@@access(Microsoft.EventGrid.SystemEvents.AcsMessageAnalysisCompletedEventData,
Access.public
);
@l0lawrence can provide further clarification
sarangan12
reviewed
Jun 21, 2024
| originalMessage: string; | ||
|
|
||
| /** The analysed message channel kind. */ | ||
| channelKind: "whatsapp"; |
There was a problem hiding this comment.
In the swagger file (in this PR), the data type is mentioned as AcsMessageChannelKind. Which could be 'whatsapp` or any string. Here it is mentioned just as 'whatsapp'. This should be changed.
...zure.Messaging.EventGrid.SystemEvents/Microsoft.Communication/AzureCommunicationServices.tsp
Outdated
Show resolved
Hide resolved
...entgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json
Show resolved
Hide resolved
...zure.Messaging.EventGrid.SystemEvents/Microsoft.Communication/AzureCommunicationServices.tsp
Show resolved
Hide resolved
...entgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json
Outdated
Show resolved
Hide resolved
…ble/2018-01-01/AzureCommunicationServices.json
JoshLove-msft
approved these changes
Jul 10, 2024
JoshLove-msft
added a commit
that referenced
this pull request
Jul 10, 2024
This reverts commit 0117e47.
lmazuel
pushed a commit
that referenced
this pull request
Jul 10, 2024
zaowang-ms
pushed a commit
to zaowang-ms/azure-rest-api-specs-public
that referenced
this pull request
Jul 22, 2024
* adding MessageAnalysisCompletedEvent to EG SDk * adding event to communication tps * generating spec * generating spec * removing sentiment * removing sentiment * removing sentiment * more changes * addressing comments * updating the analysis events * updating the analysis events * updating the analysis events * Update specification/eventgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json * tsp format --------- Co-authored-by: JoshLove-msft <[email protected]> Co-authored-by: l0lawrence <[email protected]>
zaowang-ms
pushed a commit
to zaowang-ms/azure-rest-api-specs-public
that referenced
this pull request
Jul 22, 2024
…Azure#29789) This reverts commit 0117e47.
raych1
added a commit
to test-repo-billy/azure-rest-api-specs
that referenced
this pull request
Jul 24, 2024
* fix spread for purview datamap and translation document (Azure#29707) * update * update * update * update translation * update * fix ai document translation * fix wrong change and regen * fix * update swagger * update * format * change to use @Body * update * format --------- Co-authored-by: tadelesh <[email protected]> * fix body spread breaking change (Azure#29723) * fix face * fix communication messages * regen swagger * fix casing * rollback face * fix face * fix tsp * add java * fix easm * [communication] Update examples to use string for retry-after (Azure#29739) - Required by autorest schema for examples * [DevOpsInfrastructure] Add ".Management" suffix to TypeSpec folder name (Azure#29737) * move directive to readme.md to avoid unnecessary breaking changes for… (Azure#29742) * move directive to readme.md to avoid unnecessary breaking changes for all languages * update suppressions --------- Co-authored-by: Qiaoqiao Zhang <[email protected]> * Update fields description (Azure#28483) * Microsoft.Fabric - Fix Delete & Update Status Codes. (Azure#29721) * fix status codes and corresponding examples * fix update exmaple * Update mfe.json to fix out of order gen issue (Azure#29634) * [ServiceBus]: Api version 2023-01-01-preview to support data disaster recovery (Azure#29315) * Base commit * New Api Version 2023/01/01/preview * Readme Updated with new version * Failover API with Example * Minor folder correction * Updates * Updates' * Add new API version (2024-06-01), and nxdomainRedirect property to VirtualNetworkLink resource (Azure#29470) * Add nxdomainRedirect property to VirtualNetworkLink resource * Updated readme files and fixed various warnings/errors * Review request for Microsoft.ContainerService/aks to add version stable/2024-05-01 (Azure#29535) * Adds base for updating Microsoft.ContainerService/aks from version stable/2024-02-01 to version 2024-05-01 * Updates readme * Updates API version in new specs and examples * remove osOptions from AKS 2024-05-01 API (Azure#29422) Co-authored-by: Charlie Li <[email protected]> * add SecurityPatch to NodeOsUpgradeChannel (Azure#29468) * Adding Daemonset related flags to May 2024 GA (Azure#29579) * update sdk-suppressions.yaml * Update sdk-suppressions.yaml * Update sdk-suppressions.yaml * add value 'none' for networkPolicy field (Azure#29653) --------- Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Ye Wang [msft] <[email protected]> Co-authored-by: Youn Jae Kim <[email protected]> Co-authored-by: Alancere <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: robogatikov <[email protected]> * Change default deployment for Msteam channel to CommercialDeployment (Azure#28741) * [Monitor] Add .Management suffix to TypeSpec folder name (Azure#29740) * [VerifiedId] Add ".Management" suffix to TypeSpec folder name (Azure#29747) * disable flatten for informatica (Azure#29755) * Update readme.md * Update readme.python.md * Update tspconfig.yaml * Update readme.python.md (Azure#29769) * tsp, BodyParameter, fix a few missing op (Azure#29770) * tsp, loadtesting, remove empty visibility from FileInfo.fileName (Azure#29521) * Enable stream-style-serialization (Azure#29768) * [OpenAI-Assistants] Fixing examples and avocado related CI issues (Azure#29499) * cleaned up config file * reverted name * Restored names and verified example adding behaviour for openapi2 emitter * Added example JSON files and the readme file * Added examples for past releases * Added more documentation to the script * Readme corrections * More readme corrections * Renamed retrieveAssistants examples to getAssistants to match TSP definition * Removed some swagger files * create_assistants json corrections * wip * Get Assistants * WIP * File operations * Files JSON examples * wip * wip * More various fixes * wip * wip * wip * removing bodyRoot decorator * Checking if things are actually fixed * Made expandable nullable enum into 'null' instead of null * Revert "Made expandable nullable enum into 'null' instead of null" This reverts commit 03d2bf5. * WIP * wip * Possible solution to bad @Body usage * Found better solution for version added mismatch createMessage * wip * WIP * Started with vector store stuff * More fixes for vector store stuff * More fixes * Last fixes for vector store batch files * Using string 'null' instread of JSON null * Revert "Using string 'null' instread of JSON null" This reverts commit 39fdbc6. * Corrected operationId * trying out null as a string * Revert "trying out null as a string" This reverts commit ab876a1. * Stringified nulls to make CI happy * Changed the value of instructions for ThreadRun examples. Field not nullable nor optional * Addressing metadata issue * Revert "Stringified nulls to make CI happy" This reverts commit 3dbb723. * Reverting left over stuff * TSP formatter * Prettified JSON * Added suppresion to work around bug * Removed unnecessary example files * Removed convenience scripts * Using bodyRoot again * Revert "Using bodyRoot again" This reverts commit a31f2a0. * Using BodyParameter in createMessage op * The CI seems stuck * [TypeSpec] Upgrade typespec-apiview to 0.4.9 (Azure#29783) * Fix casing of timestamp properties (Azure#29675) * Fix casing of timestamp properties * Fix examples * more examples * property overrides * regen swagger * adding MessageAnalysisCompletedEvent to EG SDk (Azure#28912) * adding MessageAnalysisCompletedEvent to EG SDk * adding event to communication tps * generating spec * generating spec * removing sentiment * removing sentiment * removing sentiment * more changes * addressing comments * updating the analysis events * updating the analysis events * updating the analysis events * Update specification/eventgrid/data-plane/Microsoft.Communication/stable/2018-01-01/AzureCommunicationServices.json * tsp format --------- Co-authored-by: JoshLove-msft <[email protected]> Co-authored-by: l0lawrence <[email protected]> * Revert "adding MessageAnalysisCompletedEvent to EG SDk (Azure#28912)" (Azure#29789) This reverts commit 0117e47. * Added examples for new api version - 2024-04-05 in GuestConfigurationRP (Azure#29166) * Copy files from stable/2022-01-25 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-04-05 Updated the API version from stable/2022-01-25 to stable/2024-04-05. * Added tag for 2024-04-05 in readme file * Fixing swagger PrettierCheck * Prettier changes * Add changes for Api * Prettier scan fix * Fixing failing net sdk * Revert of previous change. * java update automation config (Azure#29777) * java update automation config * format * rename property name for python sdk (Azure#29793) * [Oracle Database@Azure] Add new preview and stable API versions for 2024-06-01 (Azure#29585) * add new preview and stable API versions * remove unnecessary add decorator * re-compile after merging with main --------- Co-authored-by: zhuoyun wang <[email protected]> * [vmware] Add ".Management" suffix to TypeSpec folder name (Azure#29748) * [Informatica.DataManagement] Add .Management suffix to TypeSpec folder name (Azure#29738) * Fix acronym casing (Azure#29797) * Fix acronym casing * tsp format * Add Typespec conversion option to intake template (Azure#29616) * Add Typespec converstion option to intake template Intake form needs an option to indicate the author is converting swagger to Typespec. This change adds a checkbox for that option and indicates it should not be combined with adding a new API version. * Update control_plane_template.md Update text and add link to TypeSpec conversion docs per feedback. * Update control_plane_template.md * Update control_plane_template.md Update help link for TypeSpec conversion --------- Co-authored-by: Konrad Jamrozik <[email protected]> * Update powerbidedicated.json (Azure#29322) Updated based on this doc bug: https://dev.azure.com/msft-skilling/Content/_workitems/edit/154565 * Add tsp-client to root package.json (Azure#29803) - Allows devs to run `npx tsp-client` after `npm ci`, with no additional installs - Pins versions of `tsp-client` and its deps in the root package-lock.json - Fixes Azure#29686 * Add 2024-05-15-preview of SpeechToText API (CognitiveServices) (Azure#29804) * Add preview GA as base * Updates for new preview version * Update readme.md * Added required ttl to examples * Add description * Add missing example * Keep latest GA latest * [tsp-client] Add acceptance tests (Azure#29811) * Make union types required in 2024 service version (Azure#29832) * Make union types required in 2024 service version * pass api version * Fixes * Add examples directory * Update readme to point to new swagger * Add Generated tag * Exclude whatsapp * [tsp-client] Upgrade to 0.9.3 (Azure#29837) - Adds autorest and plugins as dependencies - Runs the packages from their install folders, to guarantee the versions don't change after install * remove-track2-for-python (Azure#29814) * java mgmt, dataprotection, hide auth headers (Azure#29838) java mgmt, dataprotection, hide auth headers * update compute typescript.md (Azure#24529) * update compute typescript.md * Update sdk-suppressions.yaml --------- Co-authored-by: Qiaoqiao Zhang <[email protected]> * easm, java sdk, tspconfig api-version=2023-03-01-preview, fix 1 BodyParameter (Azure#29839) * easm, java sdk, tspconfig api-version 2023-03-01-preview * BodyParameter * [Oracle.Database] Add .Management suffix to TypeSpec folder name (Azure#29746) * Add stub `specs-model` tool (Azure#29820) * (squashed) Add stub specs-model tool Co-authored-by: Mike Harder <[email protected]> * Fix operation id (Azure#29840) * [TypeSpecValidation] Enforce ".Management" suffix (Azure#29663) - Fixes Azure#29654 * [tsp-client] Only run test action for PRs targeting main (Azure#29843) - Only branch guaranteed to have specs used for testing * Compute: DiskRP 2024-03-02 version (Azure#29399) * Create new version folder by copying last version * update version references * update readme.md * Consolidated DiskRP swagger changes for api version 2024-03-02 (Azure#29602) * Update diskRestorePoint.json with logicalSectorSize property under "DiskRestorePointProperties" * Update DiskRestorePoint_Get.json with logicalSectorSize property * Update DiskRestorePoint_Get_WhenSourceResourceIsFromDifferentRegion.json with logicalSectorSize property * Update DiskRestorePoint_ListByVmRestorePoint.json with logicalSectorSize property * Updated diskRestorePoint.json to add format. * update default readme tag * update version references in examples --------- Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: kbaibhavgithub <[email protected]> * fix example api version (Azure#29525) Co-authored-by: Alon Pelled <[email protected]> * [NetAppFiles] Release netapp microsoft.net app 2024 03 01 preview (Azure#29682) * Copy files from preview/2023-11-01-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-03-01-preview Updated the API version from preview/2023-11-01-preview to preview/2024-03-01-preview. * Added tag for 2024-03-01-preview in readme file * update api-version 2023-03-01-preview * Spelling and location header * Spelling * arm-id missing * arm-id missing * multiple in description * api-version in example * api-version in example * external replication descriptions * Remove Get GlobalCommunicationsSite API from Orbital AODG APIs (Azure#29716) * Remove Get GlobalCommunicationsSite API from Orbital AODG Apis since it utilized unsupported ARM function resulting in an error * remove examples for apis * [EG] update utc datetime to optional (Azure#29762) * update utc datetime to optional * missed one * use madeRequired * add examples * update * remove * rebase * [suppressions] Add end-to-end tests (Azure#29858) * Refactor Batch TypeSpec to be standardized (Azure#29252) * Refactor client and routes tsp to be standardized * Fixed refactoring * Renamed example files for clarity and consistency * Update operationsIds in all examples to be correct * Fixed interface name * Regenerate swagger and examples * Fix spelling error in client * Format client tsp file * Add BatchNodeReimageContent model back * Pluralize interface names and tags * Fix pluralization mistakes * Group overrides by language * Refactor Java client name overrides * Correctly format TypeSpec * Rename client interface from Batch to BatchClient * Add OperationIdNounVerb suppression * Fix minor spelling error * tsp, openai-assistants, refactor BodyParameter (Azure#29749) * tsp, openai, refactor BodyParameter (Azure#29743) * Initial Creation of Azure.Health.Deidentification Dataplane API Typespec (Azure#29745) * Updates HealthDataAiService.Deid with feedback from SDK Review Team (Azure#29036) * Generate new Service for deidentification * [data-plane] Initial Creation of HealthDataAiServices.Deid 2 (Azure#27563) Initial Creation of HealthDataAIServices Deid Service Spec. --------- Co-authored-by: Graham Thomas <[email protected]> * Adds errorCode and explanation; Replaces pagination with continuationToken (Azure#28061) * Adds errorCode and explanation; Replaces pagination with continuationToken * Updates to use standard Azure Foundation Error --------- Co-authored-by: Graham Thomas <[email protected]> * Updated CompletedAt to LastUpdatedAt for all terminal states (Azure#28349) * Updated CompletedAt to LastUpdatedAt for all terminal states * Updates examples; Moves error order * Set examples to more realistic value * Updates File model for future expansion * Adds Input FileLocation --------- Co-authored-by: Graham Thomas <[email protected]> * Updates parameter validators/defaults/nullability; Replaces checksum with etag (Azure#28528) * Updates minor tweaks * Updates examples --------- Co-authored-by: Graham Thomas <[email protected]> * Updates HealthDataAiService.Deid with feedback from SDK Review Team * Updates TSPconfig for c# * Adds CSharp special * Updates version to match live version * Updates java package name * Fix java namespace name * Updates python package name * Updates to match version service is currently using * Updates package names * Removes update in cspell * Updates java namespace * Fixes cspell.json * Test1 * Convert to diff long running operation * Adds client config * Attempt base LRO * Updated naming and LRO config * Stash merge * Linter fixes; SDK related Updates * SDK Related Updates * Changes ordering of parameters; Fixes StringIndexType enum values * Removes script update * Updates examples * Don't update vscode settings * Updates examples * Fixes linter issues * Fixes documentDataType enum value to match casing within service * fix documentDataType enum value * change name of js package * changing property continuationToken because of a conflict in java * revert changes for continuationToken * Adding post processing for java --------- Co-authored-by: Graham Thomas <[email protected]> Co-authored-by: Daniel Szaniszlo <[email protected]> * Updates linter extends value * Updates typespec with new validations for 0.57 * Fixing namespace suppression * Fixing namespace suppression 2 * Fixing namespace suppression 3 * Fixing namespace suppression 4 * Fixes formatting * Updates how StringIndices are handled * Update docstring to contain languages * Makes etag optional for PhiTaggerResult on realtime requests * Removes redundant read decorator on etag * Regenerates with new docs * Fixes formatting * Removes @secret on location * Team review updates * Renames folder to match namespace change * Updates client name after namespace change * Makes fields with defaults optional --------- Co-authored-by: Graham Thomas <[email protected]> Co-authored-by: Daniel Szaniszlo <[email protected]> * Review request for Microsoft.ContainerService/aks to add version preview/2024-05-02-preview (Azure#29774) * Adds base for updating Microsoft.ContainerService/aks from version preview/2024-04-02-preview to version 2024-05-02-preview * Updates readme * Updates API version in new specs and examples * remove osOptions from AKS 2024-05-02-preview API (Azure#29421) Co-authored-by: Charlie Li <[email protected]> * fix ComponentsByRelease (Azure#29426) * fix definition of ComponentsByRelease * add x-ms-identifiers * update securityPatch description (Azure#29530) --------- Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Shaoru Hu <[email protected]> Co-authored-by: Ye Wang [msft] <[email protected]> * [OpenAI] Added missing GA service versions, 2024-02-01 and 2024-06-01 (Azure#29424) * added a missing GA service version * add the generated.json 2024-02-01 but looks different to inference.json * add the 2024-06-01 service API version * remove self introudced new generated.json from 2024-02-01 * added operation id * Update specification/ai/Face/tspconfig.yaml * Ran npx tsv command * copied from previous examples * added generated swagger version into readme * fixed "Missing required property: deployment-id" * run tsp compile * generated.json with generated_ prefix json file. * revert the data-plane changes for inference.json * add generated.json updates * suppress spellcheck failures --------- Co-authored-by: Jose Alvarez <[email protected]> * [Batch] Switch contentLength from int64 to string (Azure#29656) This is a breaking change, but accurately reflects what the Batch service has always returned for this property. * rerun npx tsv specification/cognitiveservices/OpenAI.Inference (Azure#29872) * Upgrade to TypeSpec 0.58 (Azure#29863) * Update PR templates: fix typo in hyperlink (Azure#29876) * Update data_plane_template.md: fix typo in hyperlink * Update control_plane_template.md * Remove unused customization-class from tspconfig (Azure#29873) * Update readme.python.md (Azure#29881) * Update readme.python.md * Update readme.python.md * update --------- Co-authored-by: msyyc <[email protected]> * Update readme.python.md (Azure#29886) * Remove unsupported If-Match header value for Blob Immutability Policy operations (Azure#29632) * Remove references to unsupported If-Match header value * Update description * Update etag description * Update description with double quotes * Microsoft.HealthDataAIServices: New API version 2024-02-28-preview (Azure#29659) * adding spec * update tsp * update * fix * validation * fix structure * fix readme swagger path * fix lintdiff error * fix provisioningState readonly * fix example * add java readme * Update tspconfig.yaml * add emitters * add azure-sdk-for-net-track2 * remove .net from tspconfig * Update specification/healthdataaiservices/resource-manager/Microsoft.HealthDataAIServices/readme.md * move readmes * fix swagger path * add .net to tspconfig * update readme * fix * remove net track 1 * update python config --------- Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> * Add listRegistrationToken endpoint to latest stable and preview versions (Azure#29676) * add listRegistrationToken endpoint to latest stable and preview versions * typo * update example to have correct resourceId format * resolve comments * use x-ms-secret * rename registrationInfoList * rename registrationInfoMinimalg * [DataFactory]Support ‘domain’ Property In Dynamics Family (Azure#29709) * Support ‘domain’ Property In Dynamics Family * add * Tag Updated (Azure#29775) * Fix HealthDataAiService (Azure#29909) * Update readme.python.md (Azure#29888) * Remove VM image that no longer functions (Azure#29870) * Remove useref and Fleet update changes (Azure#29493) * Remove useref and Fleet update changes * Remove useref * fix spell check * Fix validation errors * suppress casing errors * Fix formatting * Refactor * Remove Fleet Forbidden values * Add additional property suppression. * edit suppressions * Add Suppression for camel casing * Make confidential fields to have create and update visibility only. * update docs * remove format decorator and use url type * Address comments * revert settings change as it is visible. * Address comments * configReference is visible in response. * Add arm-id format to resource ids * Address comments * update provisioningState in examples * update examples * Update location in examples * Update example * Update security posture reference to the latest compute api version. * Fix merge conflicts * Update and add more examples --------- Co-authored-by: Sahil Arora <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> * Support MI Auth for Azure Table (Azure#29702) * support mi auth for azure table connector * add synapse changes * update sdk-suppressions.yaml --------- Co-authored-by: Alancere <[email protected]> * Update specificationRepositoryConfiguration.json (Azure#29926) There is no need to keep `-track2` since all the Python SDK is already track2 SDK now. * Update GenerateOutputSchema.json (Azure#29865) * Update GenerateOutputSchema.json Sync the schema with the latest code. * Cognitive Services 2024-06-01-preview (Azure#29228) * Copy files from preview/2024-04-01-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-06-01-preview Updated the API version from preview/2024-04-01-preview to preview/2024-06-01-preview. * Added tag for 2024-06-01-preview in readme file * RAI API changes * fix check errors * fix old versions RAI content filters * Revert "fix old versions RAI content filters" This reverts commit 9d3087f. * Add "description" * Add CalculateModelCapacity API * fix Swagger LintDiff * fix * reverted changes of old API version * address comments * fix lint error * Updated ModelCapacityCalculatorWorkload * Address comments * fix Mode Validation * fix linter * address comments * fix swagger lint errors * Adding SCVMM API Version 2024-06-01 (Azure#29568) * Base commit. Adding copy of the existing api version * Updating readme.md * Updating main.tsp and models.tsp * Updating scvmm.json * Updating examples for api version 2024-06-01 * Resolving Comments. Adding privatelinkscoperesourceid in get and list and update osprofilepropeties in virtualmachine instance get and list. * Making productKey a secret. * addding missing examples (Azure#29753) * tspconfig, java, eventgrid, exclude preview from ServiceVersion (Azure#29928) * exclude preview in eventgrid * remove namer * Review request for Microsoft.DocumentDB to modify description of burst capacity feature (Azure#29892) * modified description of burst capacity feature * added keyvaultkeyuri to cSpell --------- Co-authored-by: Venu Sivanadham <[email protected]> * Swagger changes to support Vertica V2 in ADF (Azure#29652) * support Vertica V2 in ADF * Update LinkedService.json in synapse * updating password * Update LinkedService.json * Update LinkedService.json * Update LinkedService.json * Update LinkedService.json * Update LinkedService.json * Update LinkedService.json * Update LinkedService.json * Update LinkedService.json * Support MI Auth for Azure File (Azure#29779) Co-authored-by: Shenwang Zeng <[email protected]> Co-authored-by: Razvan Badea <[email protected]> * Move Computeschedule from private to public preview (Azure#29660) * initial commit to clone computeschedule to public repo * changes to fix merge requirement errors * change to address spellcheck * added rpaas to the readme file to meet the RP quality checklist for rpaas RPs * made changes to address comments * address validation failure * changes to address validation of armid errors * made changes to address guid validation errors * removed older versions * added more example files to match private preview * trigger re-run of checks --------- Co-authored-by: Razvan Badea <[email protected]> * fix fleet pageable operation (Azure#29939) * [NetApp] Release netapp microsoft.net app 2024 03 01 (Azure#29725) * Copy files from stable/2023-11-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-03-01 Updated the API version from stable/2023-11-01 to stable/2024-03-01. * Added tag for 2024-03-01 in readme file * update specs * arm-id missing * api-version in example, desciption update * merge fix * usageThreshold min in patch to match put * update readme * swagger lintdiff * swagger lintdiff * update readme --------- Co-authored-by: Dapeng Zhang <[email protected]> Co-authored-by: tadelesh <[email protected]> Co-authored-by: Nate Kimball <[email protected]> Co-authored-by: Mike Harder <[email protected]> Co-authored-by: ZiWei Chen <[email protected]> Co-authored-by: Qiaoqiao Zhang <[email protected]> Co-authored-by: Pamela Fox <[email protected]> Co-authored-by: Badea Marjieh <[email protected]> Co-authored-by: ragovada <[email protected]> Co-authored-by: schaudhari6254888 <[email protected]> Co-authored-by: Pranav Nair <[email protected]> Co-authored-by: FumingZhang <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Ye Wang [msft] <[email protected]> Co-authored-by: Youn Jae Kim <[email protected]> Co-authored-by: Alancere <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> Co-authored-by: robogatikov <[email protected]> Co-authored-by: Kunal K Singh <[email protected]> Co-authored-by: ChenxiJiang333 <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: Shawn Fang <[email protected]> Co-authored-by: Jose Alvarez <[email protected]> Co-authored-by: JoshLove-msft <[email protected]> Co-authored-by: Osahumen Uyi Aghasomwan <[email protected]> Co-authored-by: l0lawrence <[email protected]> Co-authored-by: ameyaiam3 <[email protected]> Co-authored-by: Xiaofei Cao <[email protected]> Co-authored-by: zhuoyunwang <[email protected]> Co-authored-by: zhuoyun wang <[email protected]> Co-authored-by: Chris Stackhouse <[email protected]> Co-authored-by: Konrad Jamrozik <[email protected]> Co-authored-by: Kesem Sharabi <[email protected]> Co-authored-by: Ralf Beckers <[email protected]> Co-authored-by: Hong Li(MSFT) <[email protected]> Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: kbaibhavgithub <[email protected]> Co-authored-by: alonzop <[email protected]> Co-authored-by: Alon Pelled <[email protected]> Co-authored-by: Auðunn <[email protected]> Co-authored-by: Nathan M Kennedy <[email protected]> Co-authored-by: Sanjana Kapur <[email protected]> Co-authored-by: Graham Thomas <[email protected]> Co-authored-by: Graham Thomas <[email protected]> Co-authored-by: Daniel Szaniszlo <[email protected]> Co-authored-by: Shaoru Hu <[email protected]> Co-authored-by: Jose Alvarez <[email protected]> Co-authored-by: David Watrous <[email protected]> Co-authored-by: Timothee Guerin <[email protected]> Co-authored-by: danielszaniszlo <[email protected]> Co-authored-by: msyyc <[email protected]> Co-authored-by: Abhishek Krishna <[email protected]> Co-authored-by: asmahmoo <[email protected]> Co-authored-by: ryanosh <[email protected]> Co-authored-by: Jingshu918 <[email protected]> Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: Adam Sandor <[email protected]> Co-authored-by: Sahil Arora <[email protected]> Co-authored-by: Sahil Arora <[email protected]> Co-authored-by: Yao Kou <[email protected]> Co-authored-by: tianxinliu <[email protected]> Co-authored-by: Kartik Verma <[email protected]> Co-authored-by: kanil4664 <[email protected]> Co-authored-by: Richa Sharma <[email protected]> Co-authored-by: Venu Sivanadham <[email protected]> Co-authored-by: ms-kanikagupta <[email protected]> Co-authored-by: 触动心灵 <[email protected]> Co-authored-by: Shenwang Zeng <[email protected]> Co-authored-by: Razvan Badea <[email protected]> Co-authored-by: Nneka Okeke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API - Pull Request
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Checks stuck in `queued` state?
If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`. This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.