Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HealthInsights] Update header ordering #28589

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder commented Apr 4, 2024

@mikeharder mikeharder requested a review from a team as a code owner April 4, 2024 21:35
@mikeharder mikeharder requested review from scgbear and marclerwick and removed request for a team April 4, 2024 21:35
Copy link

openapi-pipeline-app bot commented Apr 4, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see https://aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Apr 4, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
Compared specs (v0.10.7) new version base version
openapi.json 2024-04-01(2ff86d6) 2024-04-01(main)
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.0) new version base version
default default(2ff86d6) default(main)

The following errors/warnings exist before current PR submission:

Rule Message
⚠️ OperationId OperationId for put method should contain both 'Create' and 'Update'
Location: HealthInsights/stable/2024-04-01/openapi.json#L126
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: HealthInsights/stable/2024-04-01/openapi.json#L988
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: HealthInsights/stable/2024-04-01/openapi.json#L1195
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: HealthInsights/stable/2024-04-01/openapi.json#L1316
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: HealthInsights/stable/2024-04-01/openapi.json#L1965
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: HealthInsights/stable/2024-04-01/openapi.json#L1992
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: HealthInsights/stable/2024-04-01/openapi.json#L2028
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: HealthInsights/stable/2024-04-01/openapi.json#L2032
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: HealthInsights/stable/2024-04-01/openapi.json#L2036
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: HealthInsights/stable/2024-04-01/openapi.json#L2040
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: HealthInsights/stable/2024-04-01/openapi.json#L2067
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: HealthInsights/stable/2024-04-01/openapi.json#L2071
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: HealthInsights/stable/2024-04-01/openapi.json#L2075
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: HealthInsights/stable/2024-04-01/openapi.json#L2782
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: HealthInsights/stable/2024-04-01/openapi.json#L2787
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Apr 4, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Apr 4, 2024

Generated ApiView

Language Package Name ApiView Link
Swagger HealthInsights https://apiview.dev/Assemblies/Review/0aef26c4ab2c438db6b3089e208c348c?revisionId=c63c4070c47145569ab315ea68ce760f

@mikeharder mikeharder enabled auto-merge (squash) April 4, 2024 21:39
@AzureRestAPISpecReview AzureRestAPISpecReview added data-plane TypeSpec Authored with TypeSpec labels Apr 4, 2024
@mikeharder mikeharder merged commit 08f7f27 into Azure:main Apr 4, 2024
32 checks passed
@mikeharder mikeharder deleted the ai-header-ordering branch April 4, 2024 23:49
wiboris pushed a commit to wiboris/azure-rest-api-specs that referenced this pull request May 7, 2024
- Introduced in Azure#27614
- Check TSV was not re-run after TSP was updated in main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-plane TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants