-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigate API public preview #28191
Navigate API public preview #28191
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Generation Artifacts
|
Generated ApiView
|
b344efc
to
31732dc
Compare
5decedd
to
c0db5b9
Compare
9fbbec2
to
9e73296
Compare
Preview Azure Board review meeting notes: #26429 |
I am OK with the API. But all those error in "Breaking Change(Cross-Version)" need to be approved separately. My recommendation is go with the typespec. |
...ew/data-plane/Azure.Analytics.Purview.DataMap/preview/2024-03-01-preview/purviewdatamap.json
Outdated
Show resolved
Hide resolved
...ew/data-plane/Azure.Analytics.Purview.DataMap/preview/2024-03-01-preview/purviewdatamap.json
Outdated
Show resolved
Hide resolved
...ew/data-plane/Azure.Analytics.Purview.DataMap/preview/2024-03-01-preview/purviewdatamap.json
Show resolved
Hide resolved
...ew/data-plane/Azure.Analytics.Purview.DataMap/preview/2024-03-01-preview/purviewdatamap.json
Outdated
Show resolved
Hide resolved
...ew/data-plane/Azure.Analytics.Purview.DataMap/preview/2024-03-01-preview/purviewdatamap.json
Show resolved
Hide resolved
...ew/data-plane/Azure.Analytics.Purview.DataMap/preview/2024-03-01-preview/purviewdatamap.json
Outdated
Show resolved
Hide resolved
3a16945
to
f3f1ca8
Compare
f3f1ca8
to
2f5ff98
Compare
e1c9a80
to
3d21068
Compare
3d21068
to
dd9aae3
Compare
...ew/data-plane/Azure.Analytics.Purview.DataMap/preview/2024-03-01-preview/purviewdatamap.json
Outdated
Show resolved
Hide resolved
"items": { | ||
"$ref": "#/definitions/ContactSearchResultValue" | ||
} | ||
}, | ||
"assetType": { | ||
"type": "array", | ||
"description": "The asset types of the asset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Model with only additionalProperties
should be used with caution.
Is there nothing you have on its schema?
The LintDiff CI seems not working as expected. I've opened an issue for this Azure/azure-sdk-tools#8165 |
6c92f5a
to
ac2c689
Compare
Ignore the LintDiff, as error is about |
* generate base from 2023-09-01 * add navigate API * update example * update ErrorResponse to AtlasErrorResponse * update example
Data Plane API - Pull Request
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Checks stuck in `queued` state?
If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`. This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.