Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Agent Jobs and Login migration for SQL to MI public preview scenario #2770

Merged
merged 3 commits into from
Mar 29, 2018
Merged

Conversation

hitenjava
Copy link
Member

@hitenjava hitenjava commented Mar 29, 2018

Approved PR for private repo - https://github.com/Azure/azure-rest-api-specs-pr/pull/427

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Mar 29, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2071

@AutorestCI
Copy link

AutorestCI commented Mar 29, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1474

@AutorestCI
Copy link

AutorestCI commented Mar 29, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Mar 29, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on a change to an operation ID, it's not blocking though.
Have these APIs been reviewed by ARM and the API review board and are they deployed?

"Standard operation",
"GET"
],
"operationId": "ResourceSkus_ListSkus",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the name to ResourceSkus_List since Skus is already in the operation group, else you'd end up with a method like this.

ResourceSkus.ListSkus()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhendrixMSFT - If you look only at 2nd commit, you'll see the diff of what is new in this api-version. The previous version is already in public preview. This wasn't really changed in this version, it has been present even in the previous version.

Yes, the APIs have been reviewed and deployed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks for pointing this out. If this is ready for building SDKs I will push an update to the README to include this for Go, does that work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this can be published.
I've been updating the azure-sdk-for-net repo after this (for previous changes), not sure about the Go part.

@jhendrixMSFT jhendrixMSFT merged commit f8e623c into Azure:master Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants