-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Agent Jobs and Login migration for SQL to MI public preview scenario #2770
Conversation
…reparation for adding new api version.
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-libraries-for-javaNothing to generate for azure-libraries-for-java |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment on a change to an operation ID, it's not blocking though.
Have these APIs been reviewed by ARM and the API review board and are they deployed?
"Standard operation", | ||
"GET" | ||
], | ||
"operationId": "ResourceSkus_ListSkus", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change the name to ResourceSkus_List since Skus is already in the operation group, else you'd end up with a method like this.
ResourceSkus.ListSkus()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jhendrixMSFT - If you look only at 2nd commit, you'll see the diff of what is new in this api-version. The previous version is already in public preview. This wasn't really changed in this version, it has been present even in the previous version.
Yes, the APIs have been reviewed and deployed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh thanks for pointing this out. If this is ready for building SDKs I will push an update to the README to include this for Go, does that work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this can be published.
I've been updating the azure-sdk-for-net repo after this (for previous changes), not sure about the Go part.
Approved PR for private repo - https://github.com/Azure/azure-rest-api-specs-pr/pull/427
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger