Mjmadhu playwrighttesting microsoft.azure playwright service 2023 10 01 preview cp #27611

mjmadhu · 2024-02-01T03:44:16Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- As mentioned in this thread. We got the stable version merged a day ago which is not yet added in the ARM manifest, we got the intimation that the GA of the service might be delayed with indefinite date as of today so we don't want to maintain a stable version unnecessarily, hence moving it back to preview.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-02-01T03:44:20Z

Next Steps to Merge

✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2024-02-01T03:44:20Z

Swagger Validation Report

️❌BreakingChange: 20 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
playwrighttesting.json	2024-02-01(1778657)	2024-02-01(main)

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.AzurePlaywrightService/operations' removed or restructured? Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L56:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AzurePlaywrightService/accounts' removed or restructured? Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L92:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AzurePlaywrightService/checkNameAvailability' removed or restructured? Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L131:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AzurePlaywrightService/locations/{location}/quotas' removed or restructured? Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L176:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AzurePlaywrightService/locations/{location}/quotas/{quotaName}' removed or restructured? Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L222:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzurePlaywrightService/accounts' removed or restructured? Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L286:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzurePlaywrightService/accounts/{accountName}' removed or restructured? Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L328:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzurePlaywrightService/accounts/{accountName}/quotas' removed or restructured? Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L571:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzurePlaywrightService/accounts/{accountName}/quotas/{quotaName}' removed or restructured? Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L623:5
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'Account' removed or renamed? New: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L56:3 Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L694:3
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'AccountProperties' removed or renamed? New: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L56:3 Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L694:3
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'AccountUpdate' removed or renamed? New: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L56:3 Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L694:3
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'AccountUpdateProperties' removed or renamed? New: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L56:3 Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L694:3
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'EnablementStatus' removed or renamed? New: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L56:3 Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L694:3
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'ProvisioningState' removed or renamed? New: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L56:3 Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L694:3
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'systemData' removed or renamed? New: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L56:3 Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L694:3
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'CheckNameAvailabilityRequest' removed or renamed? New: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L56:3 Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L694:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupNameParameter' removed or renamed? New: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L57:3 Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L1092:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'SubscriptionIdParameter' removed or renamed? New: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L57:3 Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L1092:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'ApiVersionParameter' removed or renamed? New: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L57:3 Old: Microsoft.AzurePlaywrightService/stable/2024-02-01/playwrighttesting.json#L1092:3

️⚠️Breaking Change(Cross-Version): 34 Warnings warning [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
playwrighttesting.json	2024-02-01-preview(1778657)	2024-02-01(main)
playwrighttesting.json	2024-02-01-preview(1778657)	2023-10-01-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Only 30 items are listed, please refer to log for more details.

Rule	Message
⚠️ 1009 - RemovedRequiredParameter	The required parameter 'name' was removed in the new version. Old: Microsoft.AzurePlaywrightService/preview/2023-10-01-preview/playwrighttesting.json#L195:11
⚠️ 1009 - RemovedRequiredParameter	The required parameter 'name' was removed in the new version. Old: Microsoft.AzurePlaywrightService/preview/2023-10-01-preview/playwrighttesting.json#L297:11
⚠️ 1009 - RemovedRequiredParameter	The required parameter 'name' was removed in the new version. Old: Microsoft.AzurePlaywrightService/preview/2023-10-01-preview/playwrighttesting.json#L344:11
⚠️ 1009 - RemovedRequiredParameter	The required parameter 'name' was removed in the new version. Old: Microsoft.AzurePlaywrightService/preview/2023-10-01-preview/playwrighttesting.json#L417:11
⚠️ 1009 - RemovedRequiredParameter	The required parameter 'name' was removed in the new version. Old: Microsoft.AzurePlaywrightService/preview/2023-10-01-preview/playwrighttesting.json#L473:11
⚠️ 1010 - AddingRequiredParameter	The required parameter 'quotaName' was added in the new version. New: Microsoft.AzurePlaywrightService/preview/2024-02-01-preview/playwrighttesting.json#L243:11
⚠️ 1010 - AddingRequiredParameter	The required parameter 'accountName' was added in the new version. New: Microsoft.AzurePlaywrightService/preview/2024-02-01-preview/playwrighttesting.json#L345:11
⚠️ 1010 - AddingRequiredParameter	The required parameter 'accountName' was added in the new version. New: Microsoft.AzurePlaywrightService/preview/2024-02-01-preview/playwrighttesting.json#L392:11
⚠️ 1010 - AddingRequiredParameter	The required parameter 'accountName' was added in the new version. New: Microsoft.AzurePlaywrightService/preview/2024-02-01-preview/playwrighttesting.json#L465:11
⚠️ 1010 - AddingRequiredParameter	The required parameter 'accountName' was added in the new version. New: Microsoft.AzurePlaywrightService/preview/2024-02-01-preview/playwrighttesting.json#L521:11
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: common-types/resource-management/v5/types.json#L413:9 Old: common-types/resource-management/v3/types.json#L411:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AzurePlaywrightService/preview/2024-02-01-preview/playwrighttesting.json#L99:9 Old: Microsoft.AzurePlaywrightService/preview/2023-10-01-preview/playwrighttesting.json#L96:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AzurePlaywrightService/preview/2024-02-01-preview/playwrighttesting.json#L183:9 Old: Microsoft.AzurePlaywrightService/preview/2023-10-01-preview/playwrighttesting.json#L135:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AzurePlaywrightService/preview/2024-02-01-preview/playwrighttesting.json#L229:9 Old: Microsoft.AzurePlaywrightService/preview/2023-10-01-preview/playwrighttesting.json#L181:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AzurePlaywrightService/preview/2024-02-01-preview/playwrighttesting.json#L293:9 Old: Microsoft.AzurePlaywrightService/preview/2023-10-01-preview/playwrighttesting.json#L245:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AzurePlaywrightService/preview/2024-02-01-preview/playwrighttesting.json#L335:9 Old: Microsoft.AzurePlaywrightService/preview/2023-10-01-preview/playwrighttesting.json#L287:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AzurePlaywrightService/preview/2024-02-01-preview/playwrighttesting.json#L382:9 Old: Microsoft.AzurePlaywrightService/preview/2023-10-01-preview/playwrighttesting.json#L334:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AzurePlaywrightService/preview/2024-02-01-preview/playwrighttesting.json#L455:9 Old: Microsoft.AzurePlaywrightService/preview/2023-10-01-preview/playwrighttesting.json#L407:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AzurePlaywrightService/preview/2024-02-01-preview/playwrighttesting.json#L511:9 Old: Microsoft.AzurePlaywrightService/preview/2023-10-01-preview/playwrighttesting.json#L463:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: common-types/resource-management/v5/types.json#L632:5 Old: common-types/resource-management/v3/types.json#L622:5
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: common-types/resource-management/v5/types.json#L204:9 Old: common-types/resource-management/v3/types.json#L204:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: common-types/resource-management/v5/types.json#L210:9 Old: common-types/resource-management/v3/types.json#L209:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: common-types/resource-management/v5/types.json#L14:9 Old: common-types/resource-management/v3/types.json#L14:9
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'createdAt' renamed or removed? New: Microsoft.AzurePlaywrightService/preview/2024-02-01-preview/playwrighttesting.json#L934:7 Old: Microsoft.AzurePlaywrightService/preview/2023-10-01-preview/playwrighttesting.json#L663:7

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.7)	new version	base version
package-2024-02-01-preview	package-2024-02-01-preview(1778657)	default(main)

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'location'. Location: Microsoft.AzurePlaywrightService/preview/2024-02-01-preview/playwrighttesting.json#L191
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'location'. Location: Microsoft.AzurePlaywrightService/preview/2024-02-01-preview/playwrighttesting.json#L237

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-02-01T03:44:21Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/playwrighttesting/armplaywrighttesting - Approved - 0.3.0

+	Field `AllocatedValue`, `CreatedAt`, `ExpiryAt`, `PercentageUsed`, `UsedValue` of struct `FreeTrialProperties` has been removed

❌azure-sdk-for-js - @azure/arm-playwrighttesting - Approved - 1.0.0-beta.2

+	Interface FreeTrialProperties no longer has parameter allocatedValue
+	Interface FreeTrialProperties no longer has parameter createdAt
+	Interface FreeTrialProperties no longer has parameter expiryAt
+	Interface FreeTrialProperties no longer has parameter percentageUsed
+	Interface FreeTrialProperties no longer has parameter usedValue

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 70688bc4d3bf0b1ef56efbff23f51faef4d9d158. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
warn		specification/playwrighttesting/PlaywrightTesting.Management/tspconfig.yaml skipped due to azure-sdk-for-python-track2 not found in tspconfig.yaml
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh]  New minor version of npm available! 10.2.3 -> 10.4.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-playwrighttesting [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation AccountsOperations.check_name_availability
info	[Changelog]   - Added operation group AccountQuotasOperations
info	[Changelog]   - Model Account has a new parameter properties
info	[Changelog]   - Model AccountUpdate has a new parameter properties
info	[Changelog]   - Model Quota has a new parameter properties
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model Account no longer has parameter dashboard_uri
info	[Changelog]   - Model Account no longer has parameter provisioning_state
info	[Changelog]   - Model Account no longer has parameter regional_affinity
info	[Changelog]   - Model Account no longer has parameter reporting
info	[Changelog]   - Model Account no longer has parameter scalable_execution
info	[Changelog]   - Model AccountUpdate no longer has parameter regional_affinity
info	[Changelog]   - Model AccountUpdate no longer has parameter reporting
info	[Changelog]   - Model AccountUpdate no longer has parameter scalable_execution
info	[Changelog]   - Model FreeTrialProperties no longer has parameter allocated_value
info	[Changelog]   - Model FreeTrialProperties no longer has parameter created_at
info	[Changelog]   - Model FreeTrialProperties no longer has parameter expiry_at
info	[Changelog]   - Model FreeTrialProperties no longer has parameter percentage_used
info	[Changelog]   - Model FreeTrialProperties no longer has parameter used_value
info	[Changelog]   - Model Quota no longer has parameter free_trial
info	[Changelog]   - Model Quota no longer has parameter provisioning_state
info	[Changelog]   - Operation AccountsOperations.begin_create_or_update has a new required parameter account_name
info	[Changelog]   - Operation AccountsOperations.begin_create_or_update no longer has parameter name
info	[Changelog]   - Operation AccountsOperations.begin_delete has a new required parameter account_name
info	[Changelog]   - Operation AccountsOperations.begin_delete no longer has parameter name
info	[Changelog]   - Operation AccountsOperations.get has a new required parameter account_name
info	[Changelog]   - Operation AccountsOperations.get no longer has parameter name
info	[Changelog]   - Operation AccountsOperations.update has a new required parameter account_name
info	[Changelog]   - Operation AccountsOperations.update no longer has parameter name
info	[Changelog]   - Operation QuotasOperations.get has a new required parameter quota_name
info	[Changelog]   - Operation QuotasOperations.get no longer has parameter name

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 70688bc4d3bf0b1ef56efbff23f51faef4d9d158. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
cmderr	[init.sh] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     05k      0 --:--:-- --:--:-- --:--:-- 1295k
cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
cmderr	[init.sh] ######################################### 100.0%
cmderr	[init.sh] Computing checksum with sha256sum
cmderr	[init.sh] Checksums matched!
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-playwrighttesting [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 70688bc4d3bf0b1ef56efbff23f51faef4d9d158. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
warn		specification/playwrighttesting/PlaywrightTesting.Management/tspconfig.yaml skipped due to azure-sdk-for-go not found in tspconfig.yaml
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/playwrighttesting/armplaywrighttesting [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Field `AllocatedValue`, `CreatedAt`, `ExpiryAt`, `PercentageUsed`, `UsedValue` of struct `FreeTrialProperties` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `FreeTrialStateNotEligible`, `FreeTrialStateNotRegistered` added to enum type `FreeTrialState`
info	[Changelog] - New value `ProvisioningStateCreating` added to enum type `ProvisioningState`
info	[Changelog] - New enum type `CheckNameAvailabilityReason` with values `CheckNameAvailabilityReasonAlreadyExists`, `CheckNameAvailabilityReasonInvalid`
info	[Changelog] - New function `NewAccountQuotasClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AccountQuotasClient, error)`
info	[Changelog] - New function `*AccountQuotasClient.Get(context.Context, string, string, QuotaNames, *AccountQuotasClientGetOptions) (AccountQuotasClientGetResponse, error)`
info	[Changelog] - New function `*AccountQuotasClient.NewListByAccountPager(string, string, *AccountQuotasClientListByAccountOptions) *runtime.Pager[AccountQuotasClientListByAccountResponse]`
info	[Changelog] - New function `*AccountsClient.CheckNameAvailability(context.Context, CheckNameAvailabilityRequest, *AccountsClientCheckNameAvailabilityOptions) (AccountsClientCheckNameAvailabilityResponse, error)`
info	[Changelog] - New function `*ClientFactory.NewAccountQuotasClient() *AccountQuotasClient`
info	[Changelog] - New struct `AccountFreeTrialProperties`
info	[Changelog] - New struct `AccountQuota`
info	[Changelog] - New struct `AccountQuotaListResult`
info	[Changelog] - New struct `AccountQuotaProperties`
info	[Changelog] - New struct `CheckNameAvailabilityRequest`
info	[Changelog] - New struct `CheckNameAvailabilityResponse`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 23 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 70688bc4d3bf0b1ef56efbff23f51faef4d9d158. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-playwrighttesting [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-playwrighttesting-1.0.0-beta.2.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group AccountQuotas
info	[Changelog]   - Added operation Accounts.checkNameAvailability
info	[Changelog]   - Added Interface AccountFreeTrialProperties
info	[Changelog]   - Added Interface AccountProperties
info	[Changelog]   - Added Interface AccountQuota
info	[Changelog]   - Added Interface AccountQuotaListResult
info	[Changelog]   - Added Interface AccountQuotaProperties
info	[Changelog]   - Added Interface AccountQuotasGetOptionalParams
info	[Changelog]   - Added Interface AccountQuotasListByAccountNextOptionalParams
info	[Changelog]   - Added Interface AccountQuotasListByAccountOptionalParams
info	[Changelog]   - Added Interface AccountsCheckNameAvailabilityOptionalParams
info	[Changelog]   - Added Interface AccountUpdateProperties
info	[Changelog]   - Added Interface CheckNameAvailabilityRequest
info	[Changelog]   - Added Interface CheckNameAvailabilityResponse
info	[Changelog]   - Added Interface QuotaProperties
info	[Changelog]   - Added Type Alias AccountQuotasGetResponse
info	[Changelog]   - Added Type Alias AccountQuotasListByAccountNextResponse
info	[Changelog]   - Added Type Alias AccountQuotasListByAccountResponse
info	[Changelog]   - Added Type Alias AccountsCheckNameAvailabilityResponse
info	[Changelog]   - Added Type Alias CheckNameAvailabilityReason
info	[Changelog]   - Interface Account has a new optional parameter properties
info	[Changelog]   - Interface AccountUpdate has a new optional parameter properties
info	[Changelog]   - Interface Quota has a new optional parameter properties
info	[Changelog]   - Added Enum KnownCheckNameAvailabilityReason
info	[Changelog]   - Enum KnownFreeTrialState has a new value NotEligible
info	[Changelog]   - Enum KnownFreeTrialState has a new value NotRegistered
info	[Changelog]   - Enum KnownProvisioningState has a new value Creating
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface Account no longer has parameter dashboardUri
info	[Changelog]   - Interface Account no longer has parameter provisioningState
info	[Changelog]   - Interface Account no longer has parameter regionalAffinity
info	[Changelog]   - Interface Account no longer has parameter reporting
info	[Changelog]   - Interface Account no longer has parameter scalableExecution
info	[Changelog]   - Interface AccountUpdate no longer has parameter regionalAffinity
info	[Changelog]   - Interface AccountUpdate no longer has parameter reporting
info	[Changelog]   - Interface AccountUpdate no longer has parameter scalableExecution
info	[Changelog]   - Interface FreeTrialProperties no longer has parameter allocatedValue
info	[Changelog]   - Interface FreeTrialProperties no longer has parameter createdAt
info	[Changelog]   - Interface FreeTrialProperties no longer has parameter expiryAt
info	[Changelog]   - Interface FreeTrialProperties no longer has parameter percentageUsed
info	[Changelog]   - Interface FreeTrialProperties no longer has parameter usedValue
info	[Changelog]   - Interface Quota no longer has parameter freeTrial
info	[Changelog]   - Interface Quota no longer has parameter provisioningState

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 70688bc4d3bf0b1ef56efbff23f51faef4d9d158. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.3 -> 10.4.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0>
cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️playwrighttesting [View full logs] [Preview Schema Changes]

️⚠️ azure-powershell warning [Detail]

⚠️Warning [Logs] Generate from 70688bc4d3bf0b1ef56efbff23f51faef4d9d158. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
warn		specification/playwrighttesting/PlaywrightTesting.Management/tspconfig.yaml skipped due to azure-powershell not found in tspconfig.yaml
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

⚠️Az.playwrighttesting.DefaultTag [View full logs] [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-02-01T03:44:22Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/playwrighttesting/armplaywrighttesting	https://apiview.dev/Assemblies/Review/b7335bf36fde4a55b601579a922966cd?revisionId=3dabfb6c7e9a4ea9b168964a667ef017
Java	azure-resourcemanager-playwrighttesting	https://apiview.dev/Assemblies/Review/1bd459ec74cb4a53a4d19cdb7e9db406?revisionId=79055701d8b94ce8960b8e5380882770
JavaScript	@azure/arm-playwrighttesting	https://apiview.dev/Assemblies/Review/3a5ef77675cd496b8ea7476458ea8d4b?revisionId=8c587b7b5df748359200b44ce7f0a64d
TypeSpec	PlaywrightTesting.Management	https://apiview.dev/Assemblies/Review/8d7e4b8460bd4874b59430d6790390d8?revisionId=7b4059a5adfa45c68eee029ec3d92f53

mjmadhu · 2024-02-01T03:47:53Z

This is the PR merged a day ago which we have just moved back to preview version due to GA delay.

openapi-workflow-bot · 2024-02-01T03:50:25Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

openapi-workflow-bot · 2024-02-01T03:50:25Z

Hi @mjmadhu! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

rkmanda · 2024-02-01T05:39:19Z

Adding breaking change approval label as the author confirmed there are no customers onboarded

visingla-ms · 2024-02-02T12:19:00Z

/azp run

azure-pipelines · 2024-02-02T12:19:18Z

Azure Pipelines successfully started running 4 pipeline(s).

mjmadhu · 2024-02-04T05:27:02Z

/pr RequestMerge

mjmadhu · 2024-02-05T03:28:08Z

/pr RequestMerge

mjmadhu · 2024-02-05T15:47:52Z

/pr RequestMerge

mjmadhu added 2 commits February 1, 2024 09:03

Base commit to add new version folders

65b6ae3

Moving unrequired stable version back to preview

1778657

mjmadhu added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 1, 2024

azure-sdk mentioned this pull request Feb 1, 2024

[AutoPR sdk/resourcemanager/playwrighttesting/armplaywrighttesting] Mjmadhu playwrighttesting microsoft.azure playwright service 2023 10 01 preview cp azure-sdk/azure-sdk-for-go#8730

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Feb 1, 2024

azure-sdk mentioned this pull request Feb 1, 2024

[AutoPR playwrighttesting] Mjmadhu playwrighttesting microsoft.azure playwright service 2023 10 01 preview cp azure-sdk/azure-resource-manager-schemas#4050

Draft

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Feb 1, 2024

mjmadhu added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed CI-BreakingChange-JavaScript CI-MissingBaseCommit labels Feb 1, 2024

openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 1, 2024

azure-sdk mentioned this pull request Feb 1, 2024

[AutoPR azure-resourcemanager-playwrighttesting] Mjmadhu playwrighttesting microsoft.azure playwright service 2023 10 01 preview cp azure-sdk/azure-sdk-for-java#9153

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Feb 1, 2024

rkmanda added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 1, 2024

AzureRestAPISpecReview added CI-MissingBaseCommit ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test labels Feb 2, 2024

visingla-ms added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 2, 2024

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 2, 2024

msyyc added the Approved-SdkBreakingChange-Python label Feb 4, 2024

Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Feb 4, 2024

microsoft-github-policy-service bot added the MergeRequested label Feb 4, 2024

kazrael2119 added the Approved-SdkBreakingChange-JavaScript label Feb 4, 2024

mjmadhu removed the MergeRequested label Feb 5, 2024

microsoft-github-policy-service bot added the MergeRequested label Feb 5, 2024

mentat9 approved these changes Feb 5, 2024

View reviewed changes

mentat9 merged commit abb30bf into main Feb 5, 2024
31 checks passed

mentat9 deleted the mjmadhu-playwrighttesting-Microsoft.AzurePlaywrightService-2023-10-01-preview-cp branch February 5, 2024 18:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mjmadhu playwrighttesting microsoft.azure playwright service 2023 10 01 preview cp #27611

Mjmadhu playwrighttesting microsoft.azure playwright service 2023 10 01 preview cp #27611

mjmadhu commented Feb 1, 2024

openapi-pipeline-app bot commented Feb 1, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2024 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Feb 1, 2024 •

edited

Loading

mjmadhu commented Feb 1, 2024

openapi-workflow-bot bot commented Feb 1, 2024

openapi-workflow-bot bot commented Feb 1, 2024

rkmanda commented Feb 1, 2024

visingla-ms commented Feb 2, 2024

azure-pipelines bot commented Feb 2, 2024

mjmadhu commented Feb 4, 2024

mjmadhu commented Feb 5, 2024

mjmadhu commented Feb 5, 2024

Mjmadhu playwrighttesting microsoft.azure playwright service 2023 10 01 preview cp #27611

Mjmadhu playwrighttesting microsoft.azure playwright service 2023 10 01 preview cp #27611

Conversation

mjmadhu commented Feb 1, 2024

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Breaking changes review (Diagram Step 1)

ARM API changes review (Diagram Step 2)

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented Feb 1, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Feb 1, 2024 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 1, 2024 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Feb 1, 2024 • edited Loading

Generated ApiView

mjmadhu commented Feb 1, 2024

openapi-workflow-bot bot commented Feb 1, 2024

openapi-workflow-bot bot commented Feb 1, 2024

rkmanda commented Feb 1, 2024

visingla-ms commented Feb 2, 2024

azure-pipelines bot commented Feb 2, 2024

mjmadhu commented Feb 4, 2024

mjmadhu commented Feb 5, 2024

mjmadhu commented Feb 5, 2024

openapi-pipeline-app bot commented Feb 1, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2024 •

edited

Loading

openapi-pipeline-app bot commented Feb 1, 2024 •

edited

Loading