Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System component added as azure arc profile. #27519

Merged
merged 8 commits into from
Jan 27, 2024

Keeping the default same stable

3e606e0
Select commit
Loading
Failed to load commit list.
Merged

System component added as azure arc profile. #27519

Keeping the default same stable
3e606e0
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / ~[NotRequired_Staging] Swagger LintDiff succeeded Jan 26, 2024 in 3m 9s

~[NotRequired_Staging] Swagger LintDiff succeeded

ppe/LintDiff
View Azure DevOps build log for more details.

Details

compared tags (via openapi-validator vbeta) new version base version
package-preview-2024-02-01 package-preview-2024-02-01(3e606e0) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L883
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L876


The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L695
❌ IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L592
❌ SystemDataDefinitionsCommonTypes System data references must utilize common types.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L522
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L516
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L491
❌ OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L407
❌ OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Kubernetes/operations' does not match the ARM specification. Please standardize the schema.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L406
❌ SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L308
❌ SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L247
❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L247
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L228
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L198
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L186
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L142
❌ PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L129
❌ PatchPropertiesCorrespondToPutProperties azureHybridBenefit property in patch body is not present in the corresponding put body. A patch request body must only contain properties present in the corresponding put request body, and must contain at least one of the properties.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L116
❌ PatchPropertiesCorrespondToPutProperties distributionVersion property in patch body is not present in the corresponding put body. A patch request body must only contain properties present in the corresponding put request body, and must contain at least one of the properties.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L116
❌ PatchPropertiesCorrespondToPutProperties distribution property in patch body is not present in the corresponding put body. A patch request body must only contain properties present in the corresponding put request body, and must contain at least one of the properties.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L116
❌ PatchPropertiesCorrespondToPutProperties tags property in patch body is not present in the corresponding put body. A patch request body must only contain properties present in the corresponding put request body, and must contain at least one of the properties.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L116
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L85
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L79
❌ SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L31
❌ ResourceNameRestriction The resource name parameter 'clusterName' should be defined with a 'pattern' restriction.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L31
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L1015
⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L996
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L838
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L529
⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L459
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L413
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L400
⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L392
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L382
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L369
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L366
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L354
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L342
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L329
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L326
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L323
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L311
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L302
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L277
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L274
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L271
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L250
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L237
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L218
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L215
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L212
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ConnectedClusterModel'. Consider using the plural form of 'ConnectedCluster' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.Kubernetes/preview/2024-02-01-preview/connectedClusters.json#L200
View more details on openapi-pipeline-app