Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving 2023-05-01 swagger validation errors for Azure Firewall examples. #27403

Merged
merged 4 commits into from
Feb 7, 2024

Ran prettier against azureFirewall.json

d78477f
Select commit
Loading
Failed to load commit list.
Merged

Resolving 2023-05-01 swagger validation errors for Azure Firewall examples. #27403

Ran prettier against azureFirewall.json
d78477f
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / ~[NotRequired_Staging] Swagger LintDiff succeeded Jan 18, 2024 in 15m 25s

~[NotRequired_Staging] Swagger LintDiff succeeded

ppe/LintDiff
View Azure DevOps build log for more details.

Details

compared tags (via openapi-validator vbeta) new version base version
package-2023-05 package-2023-05(d78477f) package-2023-05(main)

The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ MissingTypeObject The schema 'AzureFirewallSku' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L1184
❌ MissingTypeObject The schema 'AzureFirewallRCAction' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L1136
❌ MissingTypeObject The schema 'AzureFirewallNetworkRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L1074
❌ MissingTypeObject The schema 'AzureFirewallNetworkRuleCollection' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L1050
❌ MissingTypeObject The schema 'AzureFirewallNetworkRuleCollectionPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L1020
❌ MissingTypeObject The schema 'AzureFirewallNatRCAction' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L999
❌ MissingTypeObject The schema 'AzureFirewallNatRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L939
❌ MissingTypeObject The schema 'AzureFirewallNatRuleCollection' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L915
❌ MissingTypeObject The schema 'AzureFirewallNatRuleCollectionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L885
❌ MissingTypeObject The schema 'AzureFirewallApplicationRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L837
❌ MissingTypeObject The schema 'AzureFirewallApplicationRuleProtocol' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L819
❌ MissingTypeObject The schema 'AzureFirewallApplicationRuleCollection' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L795
❌ MissingTypeObject The schema 'AzureFirewallApplicationRuleCollectionPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L765
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L758
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L733
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L733
❌ MissingTypeObject The schema 'AzureFirewallListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L729
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L704
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L704
❌ MissingTypeObject The schema 'AzureFirewall' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L702
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L695
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L632
❌ MissingTypeObject The schema 'AzureFirewallPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L631
❌ MissingTypeObject The schema 'HubIPAddresses' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L611
❌ MissingTypeObject The schema 'HubPublicIPAddresses' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L594
❌ MissingTypeObject The schema 'AzureFirewallIpGroups' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L579
❌ MissingTypeObject The schema 'AzureFirewallPublicIPAddress' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L570
❌ MissingTypeObject The schema 'AzureFirewallIPConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L541
❌ MissingTypeObject The schema 'AzureFirewallIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L518
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L426
❌ ResourceNameRestriction The resource name parameter 'azureFirewallName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L393
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L281
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L38
❌ ResourceNameRestriction The resource name parameter 'azureFirewallName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L37
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L1035
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L900
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L854
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L780
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L596
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L454
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L397
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'learnedipprefixes' in:'AzureFirewalls_ListLearnedPrefixes'. Consider updating the operationId
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L395
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L315
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L249
⚠️ RequiredReadOnlySystemData The response of operation:'AzureFirewalls_UpdateTags' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L243
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L165
⚠️ RequiredReadOnlySystemData The response of operation:'AzureFirewalls_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L159
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L105
⚠️ RequiredReadOnlySystemData The response of operation:'AzureFirewalls_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L99
⚠️ PageableOperation Based on the response model schema, operation 'AzureFirewalls_Get' might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.Network/stable/2023-05-01/azureFirewall.json#L99
View more details on openapi-pipeline-app