Update the PR spec template with information about how to get help from the ARM API reviewer in the absence of the PR assignee #27362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he ARM API reviewer
rkmanda
requested review from
weshaggard,
mikeharder and
konrad-jamrozik
as code owners
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
Swagger Generation Artifacts
|
|
PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
rkmanda
changed the title
rkmanda
assigned konrad-jamrozik and weshaggard and unassigned konrad-jamrozik, weshaggard and rkmanda
|
@rkmanda let's not add such large amount of text to the PR description: we were constantly running into the problem of having too much text which nobody reads, hence we are quite strict on the amount of text we are willing to put into a PR description. I will create a separate PR to do this update and offload most of this information into a dedicated aka.ms link in aka.ms/azsdkdocs. I will use this PR of yours for info what to write. Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going forward, the PR assignee for each control plane PR will be left empty. This is an intentional change to streamline the collaboration between the PR author and the ARM reviewers. We now ask the authors to reserve an ARM office hours slot to discuss any questions they might have about their PR or if they need to get unblocked.
Relevant issue: