Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update duration properties with "x-ms-format" : "duration-constant" #27337

Merged
merged 2 commits into from
Jan 17, 2024
Merged

update duration properties with "x-ms-format" : "duration-constant" #27337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04c903f
update duration properties with format
mwesigwaguma Jan 10, 2024
1795a7c
fix prettier error
mwesigwaguma Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...source-manager/Microsoft.ServiceFabric/preview/2023-12-01-preview/managedapplication.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1827,10 +1827,12 @@
},
"HealthCheckStableDuration": {
"type": "string",
"x-ms-format": "duration-constant",
"description": "The amount of time that the application or cluster must remain healthy before the upgrade proceeds to the next upgrade domain. It is interpreted as a string representing an ISO 8601 duration with following format \"hh:mm:ss.fff\"."
},
"HealthCheckWaitDuration": {
"type": "string",
"x-ms-format": "duration-constant",
"description": "The amount of time to wait after completing an upgrade domain before applying health policies. It is interpreted as a string representing an ISO 8601 duration with following format \"hh:mm:ss.fff\"."
},
"ManagedIdentity": {
Expand Down
2 changes: 2 additions & 0 deletions ...s/resource-manager/Microsoft.ServiceFabric/preview/2023-12-01-preview/managedcluster.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,10 +992,12 @@
"properties": {
"healthCheckWaitDuration": {
"type": "string",
"x-ms-format": "duration-constant",
Copy link
Member

@mentat9 mentat9 Jan 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"x-ms-format": "duration-constant"

Is this change due to a backend change in validation on these properties, or is it to make the spec match the existing backend? If it's the former, it requires breaking change review and might need a new API version. If it's the latter, then it should be fine. #Resolved

Copy link
Member Author

@mwesigwaguma mwesigwaguma Jan 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the latter. No changes in our backend.

"description": "The length of time to wait after completing an upgrade domain before performing health checks. The duration can be in either hh:mm:ss or in d.hh:mm:ss.ms format."
},
"healthCheckStableDuration": {
"type": "string",
"x-ms-format": "duration-constant",
"description": "The amount of time that the application or cluster must remain healthy before the upgrade proceeds to the next upgrade domain. The duration can be in either hh:mm:ss or in d.hh:mm:ss.ms format."
},
"healthCheckRetryTimeout": {
Expand Down