Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trusted Launch fields to AgentPoolSecurityProfile #26850

Merged
merged 4 commits into from
Nov 30, 2023

fix link to docs

6216da5
Select commit
Loading
Failed to load commit list.
Merged

Add Trusted Launch fields to AgentPoolSecurityProfile #26850

fix link to docs
6216da5
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / ~[NotRequired_Staging] Swagger LintDiff succeeded Nov 28, 2023 in 2m 56s

~[NotRequired_Staging] Swagger LintDiff succeeded

ppe/LintDiff
View more details.

Details

compared tags (via openapi-validator vbeta) new version base version
package-preview-2023-11 package-preview-2023-11(6216da5) package-preview-2023-11(FumingZhang-containerservice-Microsoft.ContainerService-2023-11-02-preview)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L7154
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L7150


The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L9151
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L9151
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L9151
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L8995
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L8979
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L8861
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L8856
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L8851
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L8835
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L8835
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L8805
❌ PropertiesTypeObjectNoDefinition Properties with type:object that don't reference a model definition are not allowed. ARM doesn't allow generic type definitions as this leads to bad customer experience.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L8789
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L8770
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L8676
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L8644
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L8632
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L6351
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L6312
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L6189
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L5733
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L5660
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L5486
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L5481
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L5479
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L5461
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L5387
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L5387
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L5387
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L5387
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L5387
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L5387
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L5359
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L5359
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L5359
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L5359
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L5359
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L5359
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L4329
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L4281
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L4209
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L4007
❌ RequestBodyMustExistForPutPatch The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L3278
❌ RequestBodyMustExistForPutPatch The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L3057
❌ PatchPropertiesCorrespondToPutProperties tags property in patch body is not present in the corresponding put body. A patch request body must only contain properties present in the corresponding put request body, and must contain at least one of the properties.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L3057
❌ TrackedExtensionResourcesAreNotAllowed /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedclustersnapshots/{resourceName} is an extension resource and 200 response schema in patch operation includes location property. Extension resources of type tracked are not allowed.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L3051
❌ RequestBodyMustExistForPutPatch The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L3002
❌ TrackedExtensionResourcesAreNotAllowed /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedclustersnapshots/{resourceName} is an extension resource and 201 response schema in put operation includes location property. Extension resources of type tracked are not allowed.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L2996
❌ TrackedExtensionResourcesAreNotAllowed /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedclustersnapshots/{resourceName} is an extension resource and 200 response schema in put operation includes location property. Extension resources of type tracked are not allowed.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L2996
❌ TrackedExtensionResourcesAreNotAllowed /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedclustersnapshots/{resourceName} is an extension resource and 200 response schema in get operation includes location property. Extension resources of type tracked are not allowed.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L2956
❌ RequestBodyMustExistForPutPatch The put or patch operation does not have a request body defined. This is not allowed. Please specify a request body for this operation.
Location: aks/preview/2023-11-02-preview/managedClusters.json#L2790
View more details on openapi-pipeline-app