Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Insights to add version stable/2023-10-01 #26655

Merged
merged 16 commits into from
Dec 8, 2023

use ErrorResponse from common-types v1 for APIs with legacy error res…

b9216f2
Select commit
Loading
Failed to load commit list.
Merged

[Hub Generated] Review request for Microsoft.Insights to add version stable/2023-10-01 #26655

use ErrorResponse from common-types v1 for APIs with legacy error res…
b9216f2
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff succeeded Dec 2, 2023 in 7m 13s

Swagger LintDiff succeeded

LintDiff
View more details.

Details

compared tags (via openapi-validator v2.1.6) new version base version
package-preview-2023-05 package-preview-2023-05(b9216f2) package-preview-2023-05(main)
package-2023-10 package-2023-10(b9216f2) default(main)
package-2018-02-preview package-2018-02-preview(b9216f2) package-2018-02-preview(main)
package-2018-03 package-2018-03(b9216f2) package-2018-03(main)
package-2018-09 package-2018-09(b9216f2) package-2018-09(main)
package-2018-11-preview package-2018-11-preview(b9216f2) package-2018-11-preview(main)
package-2019-03 package-2019-03(b9216f2) package-2019-03(main)
package-2019-11 package-2019-11(b9216f2) package-2019-11(main)
package-2023-01 package-2023-01(b9216f2) package-2023-01(main)
package-2022-10 package-2022-10(b9216f2) package-2022-10(main)
package-2022-06 package-2022-06(b9216f2) package-2022-06(main)
package-2021-09 package-2021-09(b9216f2) package-2021-09(main)
package-2021-07 package-2021-07(b9216f2) package-2021-07(main)
package-2021-04 package-2021-04(b9216f2) package-2021-04(main)
package-2023-10 package-2023-10(b9216f2) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2023-10-01/metricDefinitions_API.json#L46
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2023-10-01/metricDefinitions_API.json#L49
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2023-10-01/metricDefinitions_API.json#L104
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Insights/stable/2023-10-01/metricDefinitions_API.json#L288
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2023-10-01/metrics_API.json#L46
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2023-10-01/metrics_API.json#L49
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'metrics' in:'Metrics_ListAtSubscriptionScopePost'. Consider updating the operationId
Location: Microsoft.Insights/stable/2023-10-01/metrics_API.json#L119
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2023-10-01/metrics_API.json#L123
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2023-10-01/metrics_API.json#L126
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2023-10-01/metrics_API.json#L259
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Insights/stable/2023-10-01/metrics_API.json#L338
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Insights/stable/2023-10-01/metrics_API.json#L342
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Insights/stable/2023-10-01/metrics_API.json#L453
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Insights/stable/2023-10-01/metrics_API.json#L461


The following errors/warnings exist before current PR submission:

Rule Message
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L48
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L48
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L48
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L48
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L48
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L48
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L48
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L48
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L48
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L48
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L48
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L48
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L136
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L136
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L136
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L136
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L136
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L136
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L136
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L136
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L136
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L136
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L136
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Insights/stable/2018-01-01/metricDefinitions_API.json#L136
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metrics_API.json#L76
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metrics_API.json#L76
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metrics_API.json#L76
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metrics_API.json#L76
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metrics_API.json#L76
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metrics_API.json#L76
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metrics_API.json#L76
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metrics_API.json#L76
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metrics_API.json#L76
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metrics_API.json#L76
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metrics_API.json#L76
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2018-01-01/metrics_API.json#L76
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2023-10-01/metricDefinitions_API.json#L94
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Insights/stable/2023-10-01/metricDefinitions_API.json#L198
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Insights/stable/2023-10-01/metrics_API.json#L240
View more details on openapi-pipeline-app