-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TypeSpec] Upgrade to 0.50.0 #26636
Merged
Merged
[TypeSpec] Upgrade to 0.50.0 #26636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mikeharder
commented
Nov 9, 2023
•
edited
Loading
edited
- Reacts to:
- Azure/typespec-azure#3586
- Azure/typespec-azure#3692
- Azure/typespec-azure#3756
- Swagger BreakingChange
- 1019 - RemovedEnumValue / 1020 - AddedEnumValue
- Changed due to Azure/typespec-azure#3692
- 1019 - RemovedEnumValue / 1020 - AddedEnumValue
- Swagger ModelValidation
- No new errors since PR upgrading to 0.49 (https://github.com/Azure/azure-rest-api-specs/pull/26200/checks?check_run_id=17654328709)
- Swagger check failures in main #26640
- Swagger SpellCheck
- Revert incorrect changes to custom-words.txt #26639
- React to Azure/typespec-azure#3586 - Related to Azure/typespec-azure#3587 and Azure/typespec-azure#3589
This reverts commit f5c49d5.
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
azure.codesigning.json | 2023-06-15-preview(d7d3d34) | 2023-06-15-preview(main) |
widgets.json | 2022-11-01-preview(d7d3d34) | 2022-11-01-preview(main) |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
2023-06-15-preview | 2023-06-15-preview(d7d3d34) | 2023-06-15-preview(main) |
package-2022-11-01-preview | package-2022-11-01-preview(d7d3d34) | package-2022-11-01-preview(main) |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L89 |
AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L170 |
Security definition should have a description. Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L43 |
|
A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L54 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L63 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L70 |
|
Parameter should have a description. Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L77 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L153 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L156 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L159 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L226 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L233 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L284 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L287 |
|
Schema name should be Pascal case. Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L320 |
|
Schema name should be Pascal case. Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L354 |
|
Schema name should be Pascal case. Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L367 |
|
Schema name should be Pascal case. Location: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L381 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️❌
ModelValidation: 3 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
LRO_RESPONSE_HEADER |
Long running operation should return Operation-Id or Operation-Location or azure-AsyncOperation in header but not provided Url: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L86:22 ExampleUrl: preview/2023-06-15-preview/examples/CertificateProfileOperations_Sign.json |
OBJECT_ADDITIONAL_PROPERTIES |
Additional properties not allowed: ekus Url: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L552:30 ExampleUrl: preview/2023-06-15-preview/examples/CertificateProfileOperations_ListSignEkus.json#L12:17 |
OBJECT_MISSING_REQUIRED_PROPERTY |
Missing required property: value Url: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L552:30 ExampleUrl: preview/2023-06-15-preview/examples/CertificateProfileOperations_ListSignEkus.json |
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️❌
SpellCheck: 20 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
HowToFix |
Unknown word (codesigningaccounts), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L54:7 |
HowToFix |
Unknown word (certificateprofiles), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L54:52 |
HowToFix |
Unknown word (codesign), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L57:30 |
HowToFix |
Unknown word (codesign), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L58:34 |
HowToFix |
Unknown word (codesign), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L58:71 |
HowToFix |
Unknown word (Codesigning), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L73:35 |
HowToFix |
Unknown word (codesign), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L73:80 |
HowToFix |
Unknown word (codesigningaccounts), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L144:7 |
HowToFix |
Unknown word (certificateprofiles), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L144:52 |
HowToFix |
Unknown word (codesigning), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L147:42 |
HowToFix |
Unknown word (codesigningaccounts), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L217:7 |
HowToFix |
Unknown word (certificateprofiles), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L217:52 |
HowToFix |
Unknown word (codesigning), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L221:131 |
HowToFix |
Unknown word (Codesigning), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L236:35 |
HowToFix |
Unknown word (codesigningaccounts), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L271:7 |
HowToFix |
Unknown word (certificateprofiles), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L271:52 |
HowToFix |
Unknown word (rootcert), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L271:102 |
HowToFix |
Unknown word (codesigning), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L274:30 |
HowToFix |
Unknown word (codesigning), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L312:21 |
HowToFix |
Unknown word (Codesigning), please fix the error or add words to ./custom-words.txt path: Azure.CodeSigning/preview/2023-06-15-preview/azure.codesigning.json#L429:33 |
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
data-plane
labels
Nov 9, 2023
This was referenced Nov 9, 2023
Swagger Generation Artifacts
|
mikeharder
requested review from
weshaggard,
konrad-jamrozik,
yangyuan and
a team
as code owners
November 9, 2023 05:40
mikeharder
requested review from
bexxx and
weidongxu-microsoft
and removed request for
a team
November 9, 2023 05:40
Swagger pipeline restarted successfully, please wait for status update in this comment. |
zman-ms
pushed a commit
that referenced
this pull request
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
data-plane
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.