Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDN][2023-05-01] Add x-ms-enum extension to fix Pandora SDK const conflict #26619

Closed
wants to merge 2 commits into from

Conversation

t-bzhan
Copy link
Contributor

@t-bzhan t-bzhan commented Nov 8, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    Our existing swagger definition does not follow the best practice of polymorphism to define class inheritance hierarchy, a hard-coded property (typeName) with a single ENUM value is in a lot of places for deserialization purpose. It will break the Hashicorp Pandora SDK generation which will impact Terraform integration for Azure Front Door Standard/Premium service, as Golang does not support ENUM naturally. It will use string constants instead. In our case, with so many ENUMs with the same name “typeName”, it will complain about name conflict when generating Golang SDK: CDN @ 2023-05-01 - issue importing hashicorp/pandora#2831. Azure SDK Track2 for Golang does not have the problem as they did some workaround to add prefixes when the name is conflicting, which is not recommended by Pandora team. This PR aims to add x-ms-enum extension to fix Pandora SDK const conflict. This is introduced as a workaround and we will fix the swagger in next stable version.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

Copy link

openapi-pipeline-app bot commented Nov 8, 2023

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes (label: BreakingChangeReviewRequired). See the PR description for help.
  • ❌ The required check named Swagger ModelValidation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it.

Copy link

openapi-pipeline-app bot commented Nov 8, 2023

Swagger Validation Report

️❌BreakingChange: 43 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
cdn.json 2023-05-01(b341dc8) 2023-05-01(main)

Only 30 items are listed, please refer to log for more details.

Rule Message
1047 - XmsEnumChanged The new version has a different x-ms-enum 'name' than the previous one.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4826:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4738:9
1047 - XmsEnumChanged The new version has a different x-ms-enum 'name' than the previous one.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4826:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4738:9
1047 - XmsEnumChanged The new version has a different x-ms-enum 'name' than the previous one.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4826:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4738:9
1047 - XmsEnumChanged The new version has a different x-ms-enum 'name' than the previous one.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4826:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4738:9
1047 - XmsEnumChanged The new version has a different x-ms-enum 'name' than the previous one.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4826:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4738:9
1047 - XmsEnumChanged The new version has a different x-ms-enum 'name' than the previous one.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4826:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4738:9
1047 - XmsEnumChanged The new version has a different x-ms-enum 'name' than the previous one.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4826:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4738:9
1047 - XmsEnumChanged The new version has a different x-ms-enum 'name' than the previous one.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4826:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4738:9
1047 - XmsEnumChanged The new version has a different x-ms-enum 'name' than the previous one.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4826:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4738:9
1047 - XmsEnumChanged The new version has a different x-ms-enum 'name' than the previous one.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4826:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4738:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5691:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5571:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L3741:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L3741:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L3792:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L3788:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L3828:11
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L3820:11
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L3854:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L3842:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L3912:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L3896:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L3974:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L3954:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4032:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4008:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4094:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4066:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4152:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4120:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4184:11
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4148:11
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4205:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4165:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4264:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4220:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4322:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4274:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4380:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4328:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4429:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4373:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4491:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4431:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4520:11
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4456:11
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4549:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4481:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4600:9
Old: Microsoft.Cdn/stable/2023-05-01/cdn.json#L4528:9
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-2023-05 package-2023-05(b341dc8) package-2023-05(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L118
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L163
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L228
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L293
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L299
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L346
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L403
PostResponseCodes 202 response for a LRO POST operation must not have a response schema specified.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L414
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L466
ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L476
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L477
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L521
ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L531
ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L577
ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L623
ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L672
ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L721
ResourceNameRestriction The resource name parameter 'endpointName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L721
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L773
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L845
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L917
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L923
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L977
ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L984
ResourceNameRestriction The resource name parameter 'endpointName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L984
PostResponseCodes 202 response for a LRO POST operation must not have a response schema specified.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L985
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L1042
ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L1049
ResourceNameRestriction The resource name parameter 'endpointName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L1049
PostResponseCodes 202 response for a LRO POST operation must not have a response schema specified.
Location: Microsoft.Cdn/stable/2023-05-01/cdn.json#L1050
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 26 Errors, 0 Warnings failed [Detail]
Rule Message
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5474:36
ExampleUrl: stable/2023-05-01/examples/Endpoints_ListByProfile.json#L30:33
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5456:26
ExampleUrl: stable/2023-05-01/examples/Endpoints_ListByProfile.json#L28:17
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5568:41
ExampleUrl: stable/2023-05-01/examples/Endpoints_ListByProfile.json#L44:33
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5550:31
ExampleUrl: stable/2023-05-01/examples/Endpoints_ListByProfile.json#L42:17
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5474:36
ExampleUrl: stable/2023-05-01/examples/Endpoints_Get.json#L29:29
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5456:26
ExampleUrl: stable/2023-05-01/examples/Endpoints_Get.json#L27:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5568:41
ExampleUrl: stable/2023-05-01/examples/Endpoints_Get.json#L43:29
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5550:31
ExampleUrl: stable/2023-05-01/examples/Endpoints_Get.json#L41:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5474:36
ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L158:29
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5474:36
ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L170:29
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5456:26
ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L156:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5456:26
ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L168:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5568:41
ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L184:29
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5550:31
ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L182:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5474:36
ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L294:29
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5474:36
ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L306:29
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5456:26
ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L292:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5456:26
ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L304:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5568:41
ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L320:29
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5550:31
ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L318:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5474:36
ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L433:29
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5474:36
ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L445:29
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5456:26
ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L431:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5456:26
ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L443:13
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5568:41
ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L459:29
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5550:31
ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L457:13
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Nov 8, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️❌SDK Breaking Change Tracking failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-sdk-for-python-track2 warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-sdk-for-java warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-sdk-for-net-track2 failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-resource-manager-schemas warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-powershell failed [Detail]

Only 0 items are rendered, please refer to log for more details.

Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Nov 8, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/cdn/armcdn https://apiview.dev/Assemblies/Review/886fceb695f84f96b4577c284377a34c
Java azure-resourcemanager-cdn-generated https://apiview.dev/Assemblies/Review/1d85f6ff54054899b6bc89163b76bbea
JavaScript @azure/arm-cdn https://apiview.dev/Assemblies/Review/34e5643d7bf24e06994889675af4110a
Swagger Microsoft.Cdn https://apiview.dev/Assemblies/Review/dea62303b695443598d4d3915dcf58ba

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels Nov 8, 2023
Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

Copy link
Contributor

Hi, @t-bzhan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

2 similar comments
Copy link
Contributor

Hi, @t-bzhan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

Copy link
Contributor

Hi, @t-bzhan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

Copy link
Contributor

Hi, @t-bzhan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants