[DataFactory & Synapse] Update GoogleAds #26480

Yao725 · 2023-10-31T02:44:47Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-10-31T02:44:50Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-workflow-bot · 2023-10-31T02:44:51Z

Hi @Yao725, this service has enabled Service API Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it's intentional or reject it if it's not expected. Normally, all the specification or example changes should start with PR created in ADO.

You can refer to Service API Toolset Introduction for details.

Please contact service focal contacts or Service API Toolset Support Channel if need further help.

openapi-pipeline-app · 2023-10-31T02:44:51Z

Swagger Validation Report

️❌BreakingChange: 8 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
LinkedService.json	2018-06-01(2c37e90)	2018-06-01(main)
LinkedService.json	2020-12-01(2c37e90)	2020-12-01(main)

Rule	Message
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'connectionProperties' that was not found in the old version. New: stable/2018-06-01/entityTypes/LinkedService.json#L7047:7 Old: stable/2018-06-01/entityTypes/LinkedService.json#L7047:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'keyFilePath' that was not found in the old version. New: stable/2018-06-01/entityTypes/LinkedService.json#L7047:7 Old: stable/2018-06-01/entityTypes/LinkedService.json#L7047:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'trustedCertPath' that was not found in the old version. New: stable/2018-06-01/entityTypes/LinkedService.json#L7047:7 Old: stable/2018-06-01/entityTypes/LinkedService.json#L7047:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'useSystemTrustStore' that was not found in the old version. New: stable/2018-06-01/entityTypes/LinkedService.json#L7047:7 Old: stable/2018-06-01/entityTypes/LinkedService.json#L7047:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'privateKey' that was not found in the old version. New: stable/2020-12-01/entityTypes/LinkedService.json#L6477:7 Old: stable/2020-12-01/entityTypes/LinkedService.json#L6477:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'loginCustomerID' that was not found in the old version. New: stable/2020-12-01/entityTypes/LinkedService.json#L6477:7 Old: stable/2020-12-01/entityTypes/LinkedService.json#L6477:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'googleAdsApiVersion' that was not found in the old version. New: stable/2020-12-01/entityTypes/LinkedService.json#L6477:7 Old: stable/2020-12-01/entityTypes/LinkedService.json#L6477:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'supportLegacyDataTypes' that was not found in the old version. New: stable/2020-12-01/entityTypes/LinkedService.json#L6477:7 Old: stable/2020-12-01/entityTypes/LinkedService.json#L6477:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️🔄LintDiff inProgress [Detail]

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-31T02:44:52Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/datafactory/armdatafactory - Approved - 4.0.0

+	Enum `CosmosDbServicePrincipalCredentialType` has been removed
+	Enum `SalesforceSourceReadBehavior` has been removed
+	Field `EnablePartitionDiscovery`, `PartitionRootPath` of struct `HTTPReadSettings` has been removed
+	Type of `AmazonMWSLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AmazonRdsForLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AmazonRdsForSQLServerLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AmazonRedshiftLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AmazonS3CompatibleLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AmazonS3LinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AsanaLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AzureBatchLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AzureBlobFSLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AzureDataLakeAnalyticsLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AzureDataLakeStoreLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AzureDatabricksDetltaLakeLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AzureDatabricksLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AzureFileStorageLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AzureFunctionLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AzureMLLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AzureMLServiceLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AzureMariaDBLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AzureMySQLLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AzurePostgreSQLLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AzureSQLDWLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AzureSQLDatabaseLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AzureSQLMILinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `AzureSearchLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `CassandraLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `CommonDataServiceForAppsLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `ConcurLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `CosmosDbLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `CouchbaseLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `DataworldLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `Db2LinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `DrillLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `DynamicsAXLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `DynamicsCrmLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `DynamicsLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `EloquaLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `FileServerLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `FtpServerLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `GoogleAdWordsLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `GoogleBigQueryLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `GoogleCloudStorageLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `GoogleSheetsLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `GreenplumLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `HBaseLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `HDInsightHiveActivityTypeProperties.Variables` has been changed from `[]any` to `map[string]any`
+	Type of `HDInsightLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `HDInsightOnDemandLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `HTTPLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `HdfsLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `HiveLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `HubspotLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `ImpalaLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `InformixLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `JiraLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `MagentoLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `MariaDBLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `MarketoLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `MicrosoftAccessLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `MongoDbLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `MySQLLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `NetezzaLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `ODataLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `OdbcLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `Office365LinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `OracleCloudStorageLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `OracleLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `OracleServiceCloudLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `PaypalLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `PhoenixLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `PostgreSQLLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `PrestoLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `QuickBooksLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `QuickbaseLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `ResponsysLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `RestResourceDatasetTypeProperties.AdditionalHeaders` has been changed from `any` to `map[string]any`
+	Type of `RestResourceDatasetTypeProperties.PaginationRules` has been changed from `any` to `map[string]any`
+	Type of `RestServiceLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `SQLServerLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `SalesforceLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `SalesforceMarketingCloudLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `SalesforceServiceCloudLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `SapBWLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `SapCloudForCustomerLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `SapHanaLinkedServiceProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `SapOdpLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `SapOpenHubLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `SapTableLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `ServiceNowLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `SftpServerLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `SharePointOnlineListLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `ShopifyLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `SmartsheetLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `SnowflakeLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `SparkLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `SquareLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `SybaseLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `TeamDeskLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `TeradataLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `VerticaLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `XeroLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `ZendeskLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`
+	Type of `ZohoLinkedServiceTypeProperties.EncryptedCredential` has been changed from `any` to `*string`

❌azure-sdk-for-python-track2 - track2_azure-mgmt-datafactory - Approved - 3.1.0

+	Model HttpReadSettings no longer has parameter enable_partition_discovery
+	Model HttpReadSettings no longer has parameter partition_root_path

❌azure-sdk-for-js - @azure/arm-datafactory - Approved - 12.0.0

+	Interface HttpReadSettings no longer has parameter enablePartitionDiscovery
+	Interface HttpReadSettings no longer has parameter partitionRootPath
+	Removed Enum KnownCosmosDbServicePrincipalCredentialType
+	Type of parameter accountKind of interface AzureBlobStorageLinkedService is changed from string to any
+	Type of parameter additionalHeaders of interface RestResourceDataset is changed from any to {
        [propertyName: string]: any;
    }
+	Type of parameter enablePartitionDiscovery of interface AmazonS3CompatibleReadSettings is changed from boolean to any
+	Type of parameter enablePartitionDiscovery of interface AmazonS3ReadSettings is changed from boolean to any
+	Type of parameter enablePartitionDiscovery of interface AzureBlobFSReadSettings is changed from boolean to any
+	Type of parameter enablePartitionDiscovery of interface AzureBlobStorageReadSettings is changed from boolean to any
+	Type of parameter enablePartitionDiscovery of interface AzureDataLakeStoreReadSettings is changed from boolean to any
+	Type of parameter enablePartitionDiscovery of interface AzureFileStorageReadSettings is changed from boolean to any
+	Type of parameter enablePartitionDiscovery of interface FileServerReadSettings is changed from boolean to any
+	Type of parameter enablePartitionDiscovery of interface FtpReadSettings is changed from boolean to any
+	Type of parameter enablePartitionDiscovery of interface GoogleCloudStorageReadSettings is changed from boolean to any
+	Type of parameter enablePartitionDiscovery of interface HdfsReadSettings is changed from boolean to any
+	Type of parameter enablePartitionDiscovery of interface OracleCloudStorageReadSettings is changed from boolean to any
+	Type of parameter enablePartitionDiscovery of interface SftpReadSettings is changed from boolean to any
+	Type of parameter encryptedCredential of interface AmazonMWSLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AmazonRdsForOracleLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AmazonRdsForSqlServerLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AmazonRedshiftLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AmazonS3CompatibleLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AmazonS3LinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AsanaLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AzureBatchLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AzureBlobFSLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AzureDataLakeAnalyticsLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AzureDataLakeStoreLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AzureDatabricksDeltaLakeLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AzureDatabricksLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AzureFileStorageLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AzureFunctionLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AzureMLLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AzureMLServiceLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AzureMariaDBLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AzureMySqlLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AzurePostgreSqlLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AzureSearchLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AzureSqlDWLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AzureSqlDatabaseLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface AzureSqlMILinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface CassandraLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface CommonDataServiceForAppsLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface ConcurLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface CosmosDbLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface CouchbaseLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface DataworldLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface Db2LinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface DrillLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface DynamicsAXLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface DynamicsCrmLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface DynamicsLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface EloquaLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface FileServerLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface FtpServerLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface GoogleAdWordsLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface GoogleBigQueryLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface GoogleCloudStorageLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface GoogleSheetsLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface GreenplumLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface HBaseLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface HDInsightLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface HDInsightOnDemandLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface HdfsLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface HiveLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface HttpLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface HubspotLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface ImpalaLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface InformixLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface JiraLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface MagentoLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface MariaDBLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface MarketoLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface MicrosoftAccessLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface MongoDbLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface MySqlLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface NetezzaLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface ODataLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface OdbcLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface Office365LinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface OracleCloudStorageLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface OracleLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface OracleServiceCloudLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface PaypalLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface PhoenixLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface PostgreSqlLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface PrestoLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface QuickBooksLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface QuickbaseLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface ResponsysLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface RestServiceLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface SalesforceLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface SalesforceMarketingCloudLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface SalesforceServiceCloudLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface SapBWLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface SapCloudForCustomerLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface SapHanaLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface SapOdpLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface SapOpenHubLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface SapTableLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface ServiceNowLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface SftpServerLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface SharePointOnlineListLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface ShopifyLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface SmartsheetLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface SnowflakeLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface SparkLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface SqlServerLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface SquareLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface SybaseLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface TeamDeskLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface TeradataLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface VerticaLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface XeroLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface ZendeskLinkedService is changed from any to string
+	Type of parameter encryptedCredential of interface ZohoLinkedService is changed from any to string
+	Type of parameter numExecutors of interface SynapseNotebookActivity is changed from number to any
+	Type of parameter paginationRules of interface RestResourceDataset is changed from any to {
        [propertyName: string]: any;
    }
+	Type of parameter readBehavior of interface SalesforceServiceCloudSource is changed from SalesforceSourceReadBehavior to any
+	Type of parameter readBehavior of interface SalesforceSource is changed from SalesforceSourceReadBehavior to any
+	Type of parameter serviceEndpoint of interface AzureBlobStorageLinkedService is changed from string to any
+	Type of parameter servicePrincipalCredentialType of interface CosmosDbLinkedService is changed from CosmosDbServicePrincipalCredentialType to any
+	Type of parameter url of interface SapEccLinkedService is changed from string to any
+	Type of parameter useBinaryTransfer of interface FtpReadSettings is changed from boolean to any
+	Type of parameter username of interface SapEccLinkedService is changed from string to any
+	Type of parameter variables of interface HDInsightHiveActivity is changed from any[] to {
        [propertyName: string]: any;
    }

️🔄 azure-sdk-for-net-track2 inProgress [Detail]

️🔄 azure-sdk-for-python-track2 inProgress [Detail]

️🔄 azure-sdk-for-java inProgress [Detail]

️🔄 azure-sdk-for-go inProgress [Detail]

️🔄 azure-sdk-for-js inProgress [Detail]

️🔄 azure-resource-manager-schemas inProgress [Detail]

️🔄 azure-powershell inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-31T02:44:52Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/datafactory/armdatafactory	https://apiview.dev/Assemblies/Review/05a9749425894d918881e584d29e70ae
JavaScript	@azure/arm-datafactory	https://apiview.dev/Assemblies/Review/a4763871ab284fc88306f21f7f8fd4ff
Java	azure-resourcemanager-datafactory	https://apiview.dev/Assemblies/Review/5fcc7bf28184474f9b12ecfb932fde7c

Yao725 · 2023-10-31T04:51:58Z

...tory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/LinkedService.json

@@ -7045,6 +7045,10 @@
      "description": "Google AdWords service linked service properties.",
      "type": "object",
      "properties": {
+        "connectionProperties": {


These properties were accidentally removed in the previous PR, which doesn't follow the best practice, so add them back here.

generic property bags are not allowed in azure. pl remove them or give them a concrete defintiion.

In ADF this is by design to support both primitive type and object type. Btw, as my previous comment mentioned, these properties are not newly added, I remove them unintentional in my previous PR and add them back here to avoid breaking the customers.

rkmanda

Yao725 · 2023-11-06T02:17:25Z

/pr RequestMerge

openapi-pipeline-app · 2023-11-06T20:10:56Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

* update google ads for adf and synapse * fix errors * update the link used in description

update google ads for adf and synapse

6b69c85

Yao725 requested review from wonner, yanjungao718, Frey-Wang, zhangyd2015 and davidzhaoyue as code owners October 31, 2023 02:44

openapi-assignment-bot bot assigned lmazuel Oct 31, 2023

openapi-workflow-bot bot added the ShiftLeftViolation label Oct 31, 2023

openapi-workflow-bot bot added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 31, 2023

Frey-Wang approved these changes Oct 31, 2023

View reviewed changes

azure-sdk mentioned this pull request Oct 31, 2023

[AutoPR sdk/resourcemanager/datafactory/armdatafactory] [DataFactory & Synapse] Update GoogleAds azure-sdk/azure-sdk-for-go#7942

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Oct 31, 2023

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Oct 31, 2023

azure-sdk mentioned this pull request Oct 31, 2023

[AutoPR Azure.ResourceManager.DataFactory] [DataFactory & Synapse] Update GoogleAds azure-sdk/azure-sdk-for-net#6007

Closed

fix errors

5acd9e8

wonner approved these changes Oct 31, 2023

View reviewed changes

Yao725 commented Oct 31, 2023

View reviewed changes

Yao725 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 31, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 31, 2023

mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 31, 2023

rkmanda added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 1, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 1, 2023

Yao725 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 2, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 2, 2023

rkmanda approved these changes Nov 3, 2023

View reviewed changes

rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 3, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 3, 2023

msyyc added the Approved-SdkBreakingChange-Python label Nov 3, 2023

Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Nov 3, 2023

update the link used in description

2c37e90

Yao725 removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Nov 6, 2023

github-actions bot added the MergeRequested label Nov 6, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Nov 6, 2023

kazrael2119 added the Approved-SdkBreakingChange-JavaScript label Nov 6, 2023

zizw123 merged commit 0e27444 into Azure:main Nov 6, 2023
29 of 31 checks passed

jnlycklama pushed a commit that referenced this pull request Nov 8, 2023

[DataFactory & Synapse] Update GoogleAds (#26480)

6534197

* update google ads for adf and synapse * fix errors * update the link used in description

zman-ms pushed a commit that referenced this pull request Jan 10, 2024

[DataFactory & Synapse] Update GoogleAds (#26480)

438b516

* update google ads for adf and synapse * fix errors * update the link used in description

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DataFactory & Synapse] Update GoogleAds #26480

[DataFactory & Synapse] Update GoogleAds #26480

Yao725 commented Oct 31, 2023 •

edited by openapi-workflow-bot bot

Loading

openapi-pipeline-app bot commented Oct 31, 2023 •

edited

Loading

openapi-workflow-bot bot commented Oct 31, 2023

openapi-pipeline-app bot commented Oct 31, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 31, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Oct 31, 2023 •

edited

Loading

Yao725 Oct 31, 2023

rkmanda Nov 1, 2023

Yao725 Nov 2, 2023

rkmanda left a comment

Yao725 commented Nov 6, 2023

openapi-pipeline-app bot commented Nov 6, 2023

[DataFactory & Synapse] Update GoogleAds #26480

[DataFactory & Synapse] Update GoogleAds #26480

Conversation

Yao725 commented Oct 31, 2023 • edited by openapi-workflow-bot bot Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Oct 31, 2023 • edited Loading

Next Steps to Merge

openapi-workflow-bot bot commented Oct 31, 2023

openapi-pipeline-app bot commented Oct 31, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Oct 31, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Oct 31, 2023 • edited Loading

Generated ApiView

Yao725 Oct 31, 2023

Choose a reason for hiding this comment

rkmanda Nov 1, 2023

Choose a reason for hiding this comment

Yao725 Nov 2, 2023

Choose a reason for hiding this comment

rkmanda left a comment

Choose a reason for hiding this comment

Yao725 commented Nov 6, 2023

openapi-pipeline-app bot commented Nov 6, 2023

Yao725 commented Oct 31, 2023 •

edited by openapi-workflow-bot bot

Loading

openapi-pipeline-app bot commented Oct 31, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 31, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 31, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 31, 2023 •

edited

Loading