Update container app usages value to float #26452

Juliehzl · 2023-10-30T07:06:32Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-10-30T07:06:36Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-10-30T07:06:37Z

Swagger Validation Report

️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
Usages.json	2023-05-02-preview(bf59bf7)	2023-05-02-preview(main)

Rule	Message
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.App/preview/2023-05-02-preview/Usages.json#L145:9 Old: Microsoft.App/preview/2023-05-02-preview/Usages.json#L145:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.App/preview/2023-05-02-preview/Usages.json#L150:9 Old: Microsoft.App/preview/2023-05-02-preview/Usages.json#L150:9
`❌` 1026 - TypeChanged	The new version has a different type 'number' than the previous one 'integer'. New: Microsoft.App/preview/2023-05-02-preview/Usages.json#L145:9 Old: Microsoft.App/preview/2023-05-02-preview/Usages.json#L145:9
`❌` 1026 - TypeChanged	The new version has a different type 'number' than the previous one 'integer'. New: Microsoft.App/preview/2023-05-02-preview/Usages.json#L150:9 Old: Microsoft.App/preview/2023-05-02-preview/Usages.json#L150:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.6)	new version	base version
package-preview-2023-05	package-preview-2023-05(bf59bf7)	package-preview-2023-05(main)

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'location'. Location: Microsoft.App/preview/2023-05-02-preview/Usages.json#L25
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-05-02-preview/Usages.json#L35
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-05-02-preview/Usages.json#L38
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-05-02-preview/Usages.json#L74
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-05-02-preview/Usages.json#L77
⚠️ LatestVersionOfCommonTypesMustBeUsed	Use the latest version v5 of types.json. Location: Microsoft.App/preview/2023-05-02-preview/Usages.json#L88
⚠️ SchemaDescriptionOrTitle	Schema should have a description or title. Location: Microsoft.App/preview/2023-05-02-preview/Usages.json#L168

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-30T07:06:38Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from e32e64f. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-appcontainers [View full logs] [Release SDK Changes]
- azure_mgmt_appcontainers-1.0.0b1-py3-none-any.whl
- azure-mgmt-appcontainers-1.0.0b1.zip
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from e32e64f. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-appcontainers [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from e32e64f. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/appcontainers/armappcontainers [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from e32e64f. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.

️✔️@azure/arm-appcontainers [View full logs] [Release SDK Changes]
- azure-arm-appcontainers-2.0.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from e32e64f. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.2
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.2>
cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️app [View full logs]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from e32e64f. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.app.DefaultTag [View full logs]

Az.ContainerAppsApi.0.1.0.nupkg

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.app.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-30T07:06:39Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/appcontainers/armappcontainers	https://apiview.dev/Assemblies/Review/aa183a9d5e414f90aeb1e56ff55daabd
Java	azure-resourcemanager-appcontainers	https://apiview.dev/Assemblies/Review/018b130b0291426ea007d39b77237b00
JavaScript	@azure/arm-appcontainers	There is no API change compared with the previous version

openapi-workflow-bot · 2023-10-30T07:12:20Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

mikekistler

Need to specify type

specification/app/resource-manager/Microsoft.App/preview/2023-05-02-preview/Usages.json

…05-02-preview/Usages.json Co-authored-by: Mike Kistler <[email protected]>

rkmanda

Juliehzl · 2023-11-02T02:07:51Z

/pr RequestMerge

rkmanda · 2023-11-02T03:17:03Z

blocked on Mike's review

Juliehzl · 2023-11-02T04:49:05Z

blocked on Mike's review

but Mike already added BreakingChangeApproved label.

mikekistler

Looks good! 👍

openapi-pipeline-app · 2023-11-02T18:55:42Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

* update * Update specification/app/resource-manager/Microsoft.App/preview/2023-05-02-preview/Usages.json Co-authored-by: Mike Kistler <[email protected]> * Update specification/app/resource-manager/Microsoft.App/preview/2023-05-02-preview/Usages.json Co-authored-by: Mike Kistler <[email protected]> --------- Co-authored-by: Mike Kistler <[email protected]>

update

f3659f3

openapi-assignment-bot bot assigned rkmanda Oct 30, 2023

Juliehzl changed the title ~~Update usage value to float~~ Update container app usages value to float Oct 30, 2023

azure-sdk mentioned this pull request Oct 30, 2023

[AutoPR sdk/resourcemanager/appcontainers/armappcontainers] Update container app usages value to float azure-sdk/azure-sdk-for-go#7885

Closed

mikekistler requested changes Oct 30, 2023

View reviewed changes

specification/app/resource-manager/Microsoft.App/preview/2023-05-02-preview/Usages.json Show resolved Hide resolved

specification/app/resource-manager/Microsoft.App/preview/2023-05-02-preview/Usages.json Show resolved Hide resolved

mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 30, 2023

Juliehzl and others added 2 commits October 31, 2023 09:55

Update specification/app/resource-manager/Microsoft.App/preview/2023-…

1d2dcce

…05-02-preview/Usages.json Co-authored-by: Mike Kistler <[email protected]>

Update specification/app/resource-manager/Microsoft.App/preview/2023-…

bf59bf7

…05-02-preview/Usages.json Co-authored-by: Mike Kistler <[email protected]>

Juliehzl added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 31, 2023

openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 31, 2023

Juliehzl mentioned this pull request Oct 31, 2023

Update container app usages value to float #26448

Merged

6 tasks

rkmanda approved these changes Nov 1, 2023

View reviewed changes

rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 1, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 1, 2023

github-actions bot added the MergeRequested label Nov 2, 2023

rkmanda approved these changes Nov 2, 2023

View reviewed changes

rkmanda requested a review from mikekistler November 2, 2023 03:15

mikekistler approved these changes Nov 2, 2023

View reviewed changes

rkmanda approved these changes Nov 2, 2023

View reviewed changes

rkmanda merged commit e32e64f into Azure:main Nov 2, 2023
28 of 31 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update container app usages value to float #26452

Update container app usages value to float #26452

Juliehzl commented Oct 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 30, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Oct 30, 2023 •

edited

Loading

openapi-workflow-bot bot commented Oct 30, 2023

mikekistler left a comment

rkmanda left a comment

Juliehzl commented Nov 2, 2023

rkmanda commented Nov 2, 2023

Juliehzl commented Nov 2, 2023

mikekistler left a comment

openapi-pipeline-app bot commented Nov 2, 2023

Update container app usages value to float #26452

Update container app usages value to float #26452

Conversation

Juliehzl commented Oct 30, 2023 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Oct 30, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Oct 30, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Oct 30, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Oct 30, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Oct 30, 2023

mikekistler left a comment

Choose a reason for hiding this comment

rkmanda left a comment

Choose a reason for hiding this comment

Juliehzl commented Nov 2, 2023

rkmanda commented Nov 2, 2023

Juliehzl commented Nov 2, 2023

mikekistler left a comment

Choose a reason for hiding this comment

openapi-pipeline-app bot commented Nov 2, 2023

Juliehzl commented Oct 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 30, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 30, 2023 •

edited

Loading