Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix casing for operation id #26180

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

dkirby017
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • Fix operation Id casing conflict

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 11, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 11, 2023

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
HybridCompute.json 2023-06-20-preview(1d688ee) 2023-06-20-preview(main)
Rule Message
1008 - ModifiedOperationId The operation id has been changed from 'licenseProfiles_List' to 'LicenseProfiles_List'. This will impact generated code.
New: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L829:7
Old: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L829:7
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-preview-2023-06 package-preview-2023-06(1d688ee) package-preview-2023-06(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
PostResponseCodes Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L38
OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'Licenses' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L42
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L84
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L84
PatchResponseCodes Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L134
LroPatch202 The async patch operation should return 202.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L163
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L224
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L348
ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L520
ResourceNameRestriction The resource name parameter 'extensionName' should be defined with a 'pattern' restriction.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L1103
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L1104
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L1104
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L1154
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L1253
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L1441
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L1617
OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L1654
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L1705
BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'Machine' has extra properties ['resources'].
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L2477
TrackedResourcePatchOperation Tracked resource 'License' must have patch operation that at least supports the update of tags.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L2585
ArmResourcePropertiesBag Top level property names should not be repeated inside the properties bag for ARM resource 'MachineExtension'. Properties [properties.type] conflict with ARM top level properties. Please rename these.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L3026
⚠️ LongRunningOperationsOptionsValidator A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L37
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L46
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L49
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L71
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L92
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L95
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L98
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L123
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.HybridCompute/preview/2023-06-20-preview/HybridCompute.json#L142
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 11, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

azure-sdk-for-go - sdk/resourcemanager/hybridcompute/armhybridcompute - Approved - 2.0.0-beta.1
+	Type of `MachineExtensionProperties.ProtectedSettings` has been changed from `any` to `map[string]any`
+	Type of `MachineExtensionProperties.Settings` has been changed from `any` to `map[string]any`
+	Type of `MachineExtensionUpdateProperties.ProtectedSettings` has been changed from `any` to `map[string]any`
+	Type of `MachineExtensionUpdateProperties.Settings` has been changed from `any` to `map[string]any`
azure-sdk-for-js - @azure/arm-hybridcompute - Approved - 4.0.0-beta.1
+	Class HybridComputeManagementClient has a new signature
+	Interface MachineExtensionsListNextOptionalParams no longer has parameter expand
+	Type of parameter protectedSettings of interface MachineExtensionProperties is changed from Record to {
        [propertyName: string]: any;
    }
+	Type of parameter settings of interface MachineExtensionProperties is changed from Record to {
        [propertyName: string]: any;
    }
azure-sdk-for-python-track2 - track2_azure-mgmt-hybridcompute - Approved - 8.0.0
+	Model Machine no longer has parameter properties
+	Model MachineExtensionUpdate no longer has parameter properties
+	Model MachineUpdate no longer has parameter properties
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from ed7dd07. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
    cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
    cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
    cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
    cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
    cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
    cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-hybridcompute [View full logs]  [Release SDK Changes] Breaking Change Detected
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation MachinesOperations.begin_assess_patches
    info	[Changelog]   - Added operation MachinesOperations.begin_install_patches
    info	[Changelog]   - Added operation group AgentVersionOperations
    info	[Changelog]   - Added operation group ExtensionMetadataOperations
    info	[Changelog]   - Added operation group HybridIdentityMetadataOperations
    info	[Changelog]   - Added operation group LicenseProfilesOperations
    info	[Changelog]   - Added operation group LicensesOperations
    info	[Changelog]   - Added operation group NetworkProfileOperations
    info	[Changelog]   - Model AgentConfiguration has a new parameter config_mode
    info	[Changelog]   - Model Machine has a new parameter ad_fqdn
    info	[Changelog]   - Model Machine has a new parameter agent_configuration
    info	[Changelog]   - Model Machine has a new parameter agent_upgrade
    info	[Changelog]   - Model Machine has a new parameter agent_version
    info	[Changelog]   - Model Machine has a new parameter client_public_key
    info	[Changelog]   - Model Machine has a new parameter cloud_metadata
    info	[Changelog]   - Model Machine has a new parameter detected_properties
    info	[Changelog]   - Model Machine has a new parameter display_name
    info	[Changelog]   - Model Machine has a new parameter dns_fqdn
    info	[Changelog]   - Model Machine has a new parameter domain_name
    info	[Changelog]   - Model Machine has a new parameter error_details
    info	[Changelog]   - Model Machine has a new parameter extensions
    info	[Changelog]   - Model Machine has a new parameter kind
    info	[Changelog]   - Model Machine has a new parameter last_status_change
    info	[Changelog]   - Model Machine has a new parameter license_profile
    info	[Changelog]   - Model Machine has a new parameter location_data
    info	[Changelog]   - Model Machine has a new parameter machine_fqdn
    info	[Changelog]   - Model Machine has a new parameter mssql_discovered
    info	[Changelog]   - Model Machine has a new parameter network_profile
    info	[Changelog]   - Model Machine has a new parameter os_name
    info	[Changelog]   - Model Machine has a new parameter os_profile
    info	[Changelog]   - Model Machine has a new parameter os_sku
    info	[Changelog]   - Model Machine has a new parameter os_type
    info	[Changelog]   - Model Machine has a new parameter os_version
    info	[Changelog]   - Model Machine has a new parameter parent_cluster_resource_id
    info	[Changelog]   - Model Machine has a new parameter private_link_scope_resource_id
    info	[Changelog]   - Model Machine has a new parameter provisioning_state
    info	[Changelog]   - Model Machine has a new parameter resources
    info	[Changelog]   - Model Machine has a new parameter service_statuses
    info	[Changelog]   - Model Machine has a new parameter status
    info	[Changelog]   - Model Machine has a new parameter vm_id
    info	[Changelog]   - Model Machine has a new parameter vm_uuid
    info	[Changelog]   - Model MachineExtensionUpdate has a new parameter auto_upgrade_minor_version
    info	[Changelog]   - Model MachineExtensionUpdate has a new parameter enable_automatic_upgrade
    info	[Changelog]   - Model MachineExtensionUpdate has a new parameter force_update_tag
    info	[Changelog]   - Model MachineExtensionUpdate has a new parameter protected_settings
    info	[Changelog]   - Model MachineExtensionUpdate has a new parameter publisher
    info	[Changelog]   - Model MachineExtensionUpdate has a new parameter settings
    info	[Changelog]   - Model MachineExtensionUpdate has a new parameter type
    info	[Changelog]   - Model MachineExtensionUpdate has a new parameter type_handler_version
    info	[Changelog]   - Model MachineUpdate has a new parameter agent_upgrade
    info	[Changelog]   - Model MachineUpdate has a new parameter cloud_metadata
    info	[Changelog]   - Model MachineUpdate has a new parameter kind
    info	[Changelog]   - Model MachineUpdate has a new parameter location_data
    info	[Changelog]   - Model MachineUpdate has a new parameter os_profile
    info	[Changelog]   - Model MachineUpdate has a new parameter parent_cluster_resource_id
    info	[Changelog]   - Model MachineUpdate has a new parameter private_link_scope_resource_id
    info	[Changelog]   - Model ProxyResource has a new parameter system_data
    info	[Changelog]   - Model Resource has a new parameter system_data
    info	[Changelog]   - Model TrackedResource has a new parameter system_data
    info	[Changelog]   - Operation MachinesOperations.list_by_resource_group has a new optional parameter expand
    info	[Changelog]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog]   - Model Machine no longer has parameter properties
    info	[Changelog]   - Model MachineExtensionUpdate no longer has parameter properties
    info	[Changelog]   - Model MachineUpdate no longer has parameter properties
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from ed7dd07. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/hybridcompute/armhybridcompute [View full logs]  [Release SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Type of `MachineExtensionProperties.ProtectedSettings` has been changed from `any` to `map[string]any`
    info	[Changelog] - Type of `MachineExtensionProperties.Settings` has been changed from `any` to `map[string]any`
    info	[Changelog] - Type of `MachineExtensionUpdateProperties.ProtectedSettings` has been changed from `any` to `map[string]any`
    info	[Changelog] - Type of `MachineExtensionUpdateProperties.Settings` has been changed from `any` to `map[string]any`
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New enum type `AgentConfigurationMode` with values `AgentConfigurationModeFull`, `AgentConfigurationModeMonitor`
    info	[Changelog] - New enum type `ArcKindEnum` with values `ArcKindEnumAVS`, `ArcKindEnumAWS`, `ArcKindEnumEPS`, `ArcKindEnumGCP`, `ArcKindEnumHCI`, `ArcKindEnumSCVMM`, `ArcKindEnumVMware`
    info	[Changelog] - New enum type `EsuEligibility` with values `EsuEligibilityEligible`, `EsuEligibilityIneligible`, `EsuEligibilityUnknown`
    info	[Changelog] - New enum type `EsuKeyState` with values `EsuKeyStateActive`, `EsuKeyStateInactive`
    info	[Changelog] - New enum type `EsuServerType` with values `EsuServerTypeDatacenter`, `EsuServerTypeStandard`
    info	[Changelog] - New enum type `LastAttemptStatusEnum` with values `LastAttemptStatusEnumFailed`, `LastAttemptStatusEnumSuccess`
    info	[Changelog] - New enum type `LicenseAssignmentState` with values `LicenseAssignmentStateAssigned`, `LicenseAssignmentStateNotAssigned`
    info	[Changelog] - New enum type `LicenseCoreType` with values `LicenseCoreTypePCore`, `LicenseCoreTypeVCore`
    info	[Changelog] - New enum type `LicenseEdition` with values `LicenseEditionDatacenter`, `LicenseEditionStandard`
    info	[Changelog] - New enum type `LicenseState` with values `LicenseStateActivated`, `LicenseStateDeactivated`
    info	[Changelog] - New enum type `LicenseTarget` with values `LicenseTargetWindowsServer2012`, `LicenseTargetWindowsServer2012R2`
    info	[Changelog] - New enum type `LicenseType` with values `LicenseTypeESU`
    info	[Changelog] - New enum type `OsType` with values `OsTypeLinux`, `OsTypeWindows`
    info	[Changelog] - New enum type `PatchOperationStartedBy` with values `PatchOperationStartedByPlatform`, `PatchOperationStartedByUser`
    info	[Changelog] - New enum type `PatchOperationStatus` with values `PatchOperationStatusCompletedWithWarnings`, `PatchOperationStatusFailed`, `PatchOperationStatusInProgress`, `PatchOperationStatusSucceeded`, `PatchOperationStatusUnknown`
    info	[Changelog] - New enum type `PatchServiceUsed` with values `PatchServiceUsedAPT`, `PatchServiceUsedUnknown`, `PatchServiceUsedWU`, `PatchServiceUsedWUWSUS`, `PatchServiceUsedYUM`, `PatchServiceUsedZypper`
    info	[Changelog] - New enum type `ProvisioningState` with values `ProvisioningStateAccepted`, `ProvisioningStateCanceled`, `ProvisioningStateCreating`, `ProvisioningStateDeleted`, `ProvisioningStateDeleting`, `ProvisioningStateFailed`, `ProvisioningStateSucceeded`, `ProvisioningStateUpdating`
    info	[Changelog] - New enum type `VMGuestPatchClassificationLinux` with values `VMGuestPatchClassificationLinuxCritical`, `VMGuestPatchClassificationLinuxOther`, `VMGuestPatchClassificationLinuxSecurity`
    info	[Changelog] - New enum type `VMGuestPatchClassificationWindows` with values `VMGuestPatchClassificationWindowsCritical`, `VMGuestPatchClassificationWindowsDefinition`, `VMGuestPatchClassificationWindowsFeaturePack`, `VMGuestPatchClassificationWindowsSecurity`, `VMGuestPatchClassificationWindowsServicePack`, `VMGuestPatchClassificationWindowsTools`, `VMGuestPatchClassificationWindowsUpdateRollUp`, `VMGuestPatchClassificationWindowsUpdates`
    info	[Changelog] - New enum type `VMGuestPatchRebootSetting` with values `VMGuestPatchRebootSettingAlways`, `VMGuestPatchRebootSettingIfRequired`, `VMGuestPatchRebootSettingNever`
    info	[Changelog] - New enum type `VMGuestPatchRebootStatus` with values `VMGuestPatchRebootStatusCompleted`, `VMGuestPatchRebootStatusFailed`, `VMGuestPatchRebootStatusNotNeeded`, `VMGuestPatchRebootStatusRequired`, `VMGuestPatchRebootStatusStarted`, `VMGuestPatchRebootStatusUnknown`
    info	[Changelog] - New function `NewAgentVersionClient(azcore.TokenCredential, *arm.ClientOptions) (*AgentVersionClient, error)`
    info	[Changelog] - New function `*AgentVersionClient.Get(context.Context, string, string, *AgentVersionClientGetOptions) (AgentVersionClientGetResponse, error)`
    info	[Changelog] - New function `*AgentVersionClient.List(context.Context, string, *AgentVersionClientListOptions) (AgentVersionClientListResponse, error)`
    info	[Changelog] - New function `*ClientFactory.NewAgentVersionClient() *AgentVersionClient`
    info	[Changelog] - New function `*ClientFactory.NewExtensionMetadataClient() *ExtensionMetadataClient`
    info	[Changelog] - New function `*ClientFactory.NewHybridIdentityMetadataClient() *HybridIdentityMetadataClient`
    info	[Changelog] - New function `*ClientFactory.NewLicenseProfilesClient() *LicenseProfilesClient`
    info	[Changelog] - New function `*ClientFactory.NewLicensesClient() *LicensesClient`
    info	[Changelog] - New function `*ClientFactory.NewNetworkProfileClient() *NetworkProfileClient`
    info	[Changelog] - New function `NewExtensionMetadataClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ExtensionMetadataClient, error)`
    info	[Changelog] - New function `*ExtensionMetadataClient.Get(context.Context, string, string, string, string, *ExtensionMetadataClientGetOptions) (ExtensionMetadataClientGetResponse, error)`
    info	[Changelog] - New function `*ExtensionMetadataClient.NewListPager(string, string, string, *ExtensionMetadataClientListOptions) *runtime.Pager[ExtensionMetadataClientListResponse]`
    info	[Changelog] - New function `NewHybridIdentityMetadataClient(string, azcore.TokenCredential, *arm.ClientOptions) (*HybridIdentityMetadataClient, error)`
    info	[Changelog] - New function `*HybridIdentityMetadataClient.Get(context.Context, string, string, string, *HybridIdentityMetadataClientGetOptions) (HybridIdentityMetadataClientGetResponse, error)`
    info	[Changelog] - New function `*HybridIdentityMetadataClient.NewListByMachinesPager(string, string, *HybridIdentityMetadataClientListByMachinesOptions) *runtime.Pager[HybridIdentityMetadataClientListByMachinesResponse]`
    info	[Changelog] - New function `NewLicenseProfilesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*LicenseProfilesClient, error)`
    info	[Changelog] - New function `*LicenseProfilesClient.BeginCreateOrUpdate(context.Context, string, string, LicenseProfile, *LicenseProfilesClientBeginCreateOrUpdateOptions) (*runtime.Poller[LicenseProfilesClientCreateOrUpdateResponse], error)`
    info	[Changelog] - New function `*LicenseProfilesClient.BeginDelete(context.Context, string, string, *LicenseProfilesClientBeginDeleteOptions) (*runtime.Poller[LicenseProfilesClientDeleteResponse], error)`
    info	[Changelog] - New function `*LicenseProfilesClient.Get(context.Context, string, string, *LicenseProfilesClientGetOptions) (LicenseProfilesClientGetResponse, error)`
    info	[Changelog] - New function `*LicenseProfilesClient.NewListPager(string, string, *LicenseProfilesClientListOptions) *runtime.Pager[LicenseProfilesClientListResponse]`
    info	[Changelog] - New function `*LicenseProfilesClient.BeginUpdate(context.Context, string, string, LicenseProfileUpdate, *LicenseProfilesClientBeginUpdateOptions) (*runtime.Poller[LicenseProfilesClientUpdateResponse], error)`
    info	[Changelog] - New function `NewLicensesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*LicensesClient, error)`
    info	[Changelog] - New function `*LicensesClient.BeginCreateOrUpdate(context.Context, string, string, License, *LicensesClientBeginCreateOrUpdateOptions) (*runtime.Poller[LicensesClientCreateOrUpdateResponse], error)`
    info	[Changelog] - New function `*LicensesClient.BeginDelete(context.Context, string, string, *LicensesClientBeginDeleteOptions) (*runtime.Poller[LicensesClientDeleteResponse], error)`
    info	[Changelog] - New function `*LicensesClient.Get(context.Context, string, string, *LicensesClientGetOptions) (LicensesClientGetResponse, error)`
    info	[Changelog] - New function `*LicensesClient.NewListByResourceGroupPager(string, *LicensesClientListByResourceGroupOptions) *runtime.Pager[LicensesClientListByResourceGroupResponse]`
    info	[Changelog] - New function `*LicensesClient.NewListBySubscriptionPager(*LicensesClientListBySubscriptionOptions) *runtime.Pager[LicensesClientListBySubscriptionResponse]`
    info	[Changelog] - New function `*LicensesClient.BeginUpdate(context.Context, string, string, LicenseUpdate, *LicensesClientBeginUpdateOptions) (*runtime.Poller[LicensesClientUpdateResponse], error)`
    info	[Changelog] - New function `*LicensesClient.BeginValidateLicense(context.Context, License, *LicensesClientBeginValidateLicenseOptions) (*runtime.Poller[LicensesClientValidateLicenseResponse], error)`
    info	[Changelog] - New function `*MachinesClient.BeginAssessPatches(context.Context, string, string, *MachinesClientBeginAssessPatchesOptions) (*runtime.Poller[MachinesClientAssessPatchesResponse], error)`
    info	[Changelog] - New function `*MachinesClient.BeginInstallPatches(context.Context, string, string, MachineInstallPatchesParameters, *MachinesClientBeginInstallPatchesOptions) (*runtime.Poller[MachinesClientInstallPatchesResponse], error)`
    info	[Changelog] - New function `NewNetworkProfileClient(string, azcore.TokenCredential, *arm.ClientOptions) (*NetworkProfileClient, error)`
    info	[Changelog] - New function `*NetworkProfileClient.Get(context.Context, string, string, *NetworkProfileClientGetOptions) (NetworkProfileClientGetResponse, error)`
    info	[Changelog] - New struct `AgentUpgrade`
    info	[Changelog] - New struct `AgentVersion`
    info	[Changelog] - New struct `AgentVersionsList`
    info	[Changelog] - New struct `AvailablePatchCountByClassification`
    info	[Changelog] - New struct `ErrorDetailAutoGenerated`
    info	[Changelog] - New struct `ErrorResponseAutoGenerated`
    info	[Changelog] - New struct `EsuKey`
    info	[Changelog] - New struct `EsuProfileUpdateProperties`
    info	[Changelog] - New struct `ExtensionValue`
    info	[Changelog] - New struct `ExtensionValueListResult`
    info	[Changelog] - New struct `ExtensionValueProperties`
    info	[Changelog] - New struct `HybridIdentityMetadata`
    info	[Changelog] - New struct `HybridIdentityMetadataList`
    info	[Changelog] - New struct `HybridIdentityMetadataProperties`
    info	[Changelog] - New struct `IPAddress`
    info	[Changelog] - New struct `License`
    info	[Changelog] - New struct `LicenseDetails`
    info	[Changelog] - New struct `LicenseProfile`
    info	[Changelog] - New struct `LicenseProfileArmEsuProperties`
    info	[Changelog] - New struct `LicenseProfileArmEsuPropertiesWithoutAssignedLicense`
    info	[Changelog] - New struct `LicenseProfileMachineInstanceView`
    info	[Changelog] - New struct `LicenseProfileMachineInstanceViewEsuProperties`
    info	[Changelog] - New struct `LicenseProfileProperties`
    info	[Changelog] - New struct `LicenseProfileStorageModelEsuProperties`
    info	[Changelog] - New struct `LicenseProfileUpdate`
    info	[Changelog] - New struct `LicenseProfileUpdateProperties`
    info	[Changelog] - New struct `LicenseProfilesListResult`
    info	[Changelog] - New struct `LicenseProperties`
    info	[Changelog] - New struct `LicenseUpdate`
    info	[Changelog] - New struct `LicenseUpdateProperties`
    info	[Changelog] - New struct `LicenseUpdatePropertiesLicenseDetails`
    info	[Changelog] - New struct `LicensesListResult`
    info	[Changelog] - New struct `LinuxParameters`
    info	[Changelog] - New struct `MachineAssessPatchesResult`
    info	[Changelog] - New struct `MachineInstallPatchesParameters`
    info	[Changelog] - New struct `MachineInstallPatchesResult`
    info	[Changelog] - New struct `NetworkInterface`
    info	[Changelog] - New struct `NetworkProfile`
    info	[Changelog] - New struct `Subnet`
    info	[Changelog] - New struct `WindowsParameters`
    info	[Changelog] - New field `ConfigMode` in struct `AgentConfiguration`
    info	[Changelog] - New field `Kind`, `Resources` in struct `Machine`
    info	[Changelog] - New field `EnableAutomaticUpgrade` in struct `MachineExtensionUpdateProperties`
    info	[Changelog] - New field `AgentUpgrade`, `LicenseProfile`, `NetworkProfile` in struct `MachineProperties`
    info	[Changelog] - New field `Kind` in struct `MachineUpdate`
    info	[Changelog] - New field `AgentUpgrade` in struct `MachineUpdateProperties`
    info	[Changelog] - New field `Expand` in struct `MachinesClientCreateOrUpdateOptions`
    info	[Changelog] - New field `Expand` in struct `MachinesClientListByResourceGroupOptions`
    info	[Changelog] - New field `SystemData` in struct `ProxyResource`
    info	[Changelog] - New field `SystemData` in struct `Resource`
    info	[Changelog] - New field `SystemData` in struct `TrackedResource`
    info	[Changelog]
    info	[Changelog] Total 2 breaking change(s), 217 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from ed7dd07. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-hybridcompute [View full logs]  [Release SDK Changes] Breaking Change Detected
    Only show 120 items here, please refer to log for details.
    info	[Changelog]   - Added Interface LinuxParameters
    info	[Changelog]   - Added Interface Machine
    info	[Changelog]   - Added Interface MachineAssessPatchesResult
    info	[Changelog]   - Added Interface MachineExtension
    info	[Changelog]   - Added Interface MachineExtensionsDeleteHeaders
    info	[Changelog]   - Added Interface MachineExtensionsUpdateHeaders
    info	[Changelog]   - Added Interface MachineExtensionUpdate
    info	[Changelog]   - Added Interface MachineInstallPatchesParameters
    info	[Changelog]   - Added Interface MachineInstallPatchesResult
    info	[Changelog]   - Added Interface MachinesAssessPatchesHeaders
    info	[Changelog]   - Added Interface MachinesAssessPatchesOptionalParams
    info	[Changelog]   - Added Interface MachinesInstallPatchesHeaders
    info	[Changelog]   - Added Interface MachinesInstallPatchesOptionalParams
    info	[Changelog]   - Added Interface MachineUpdate
    info	[Changelog]   - Added Interface NetworkInterface
    info	[Changelog]   - Added Interface NetworkProfile
    info	[Changelog]   - Added Interface NetworkProfileGetOptionalParams
    info	[Changelog]   - Added Interface OSProfileLinuxConfiguration
    info	[Changelog]   - Added Interface OSProfileWindowsConfiguration
    info	[Changelog]   - Added Interface PrivateEndpointConnection
    info	[Changelog]   - Added Interface PrivateEndpointConnectionDataModel
    info	[Changelog]   - Added Interface PrivateEndpointConnectionsDeleteHeaders
    info	[Changelog]   - Added Interface PrivateLinkResource
    info	[Changelog]   - Added Interface PrivateLinkScopesDeleteHeaders
    info	[Changelog]   - Added Interface ProxyResource
    info	[Changelog]   - Added Interface ServiceStatus
    info	[Changelog]   - Added Interface ServiceStatuses
    info	[Changelog]   - Added Interface Subnet
    info	[Changelog]   - Added Interface TrackedResource
    info	[Changelog]   - Added Interface WindowsParameters
    info	[Changelog]   - Added Type Alias AgentConfigurationMode
    info	[Changelog]   - Added Type Alias AgentVersionGetResponse
    info	[Changelog]   - Added Type Alias AgentVersionListResponse
    info	[Changelog]   - Added Type Alias ArcKindEnum
    info	[Changelog]   - Added Type Alias AssessmentModeTypes
    info	[Changelog]   - Added Type Alias EsuEligibility
    info	[Changelog]   - Added Type Alias EsuKeyState
    info	[Changelog]   - Added Type Alias EsuServerType
    info	[Changelog]   - Added Type Alias ExtensionMetadataGetResponse
    info	[Changelog]   - Added Type Alias ExtensionMetadataListResponse
    info	[Changelog]   - Added Type Alias HybridIdentityMetadataGetResponse
    info	[Changelog]   - Added Type Alias HybridIdentityMetadataListByMachinesNextResponse
    info	[Changelog]   - Added Type Alias HybridIdentityMetadataListByMachinesResponse
    info	[Changelog]   - Added Type Alias LastAttemptStatusEnum
    info	[Changelog]   - Added Type Alias LicenseAssignmentState
    info	[Changelog]   - Added Type Alias LicenseCoreType
    info	[Changelog]   - Added Type Alias LicenseEdition
    info	[Changelog]   - Added Type Alias LicenseProfilesCreateOrUpdateResponse
    info	[Changelog]   - Added Type Alias LicenseProfilesDeleteResponse
    info	[Changelog]   - Added Type Alias LicenseProfilesGetResponse
    info	[Changelog]   - Added Type Alias LicenseProfilesListNextResponse
    info	[Changelog]   - Added Type Alias LicenseProfilesListResponse
    info	[Changelog]   - Added Type Alias LicenseProfilesUpdateResponse
    info	[Changelog]   - Added Type Alias LicensesCreateOrUpdateResponse
    info	[Changelog]   - Added Type Alias LicensesGetResponse
    info	[Changelog]   - Added Type Alias LicensesListByResourceGroupNextResponse
    info	[Changelog]   - Added Type Alias LicensesListByResourceGroupResponse
    info	[Changelog]   - Added Type Alias LicensesListBySubscriptionNextResponse
    info	[Changelog]   - Added Type Alias LicensesListBySubscriptionResponse
    info	[Changelog]   - Added Type Alias LicenseState
    info	[Changelog]   - Added Type Alias LicensesUpdateResponse
    info	[Changelog]   - Added Type Alias LicensesValidateLicenseResponse
    info	[Changelog]   - Added Type Alias LicenseTarget
    info	[Changelog]   - Added Type Alias LicenseType
    info	[Changelog]   - Added Type Alias MachinesAssessPatchesResponse
    info	[Changelog]   - Added Type Alias MachinesInstallPatchesResponse
    info	[Changelog]   - Added Type Alias NetworkProfileGetResponse
    info	[Changelog]   - Added Type Alias OsType
    info	[Changelog]   - Added Type Alias PatchModeTypes
    info	[Changelog]   - Added Type Alias PatchOperationStartedBy
    info	[Changelog]   - Added Type Alias PatchOperationStatus
    info	[Changelog]   - Added Type Alias PatchServiceUsed
    info	[Changelog]   - Added Type Alias ProvisioningState
    info	[Changelog]   - Added Type Alias VMGuestPatchClassificationLinux
    info	[Changelog]   - Added Type Alias VMGuestPatchClassificationWindows
    info	[Changelog]   - Added Type Alias VMGuestPatchRebootSetting
    info	[Changelog]   - Added Type Alias VMGuestPatchRebootStatus
    info	[Changelog]   - Interface HybridComputePrivateLinkScopeProperties has a new optional parameter privateEndpointConnections
    info	[Changelog]   - Interface MachineExtensionProperties has a new optional parameter enableAutomaticUpgrade
    info	[Changelog]   - Interface MachinesListByResourceGroupOptionalParams has a new optional parameter expand
    info	[Changelog]   - Interface OperationValue has a new optional parameter isDataAction
    info	[Changelog]   - Interface OSProfile has a new optional parameter linuxConfiguration
    info	[Changelog]   - Interface OSProfile has a new optional parameter windowsConfiguration
    info	[Changelog]   - Interface PrivateEndpointConnectionProperties has a new optional parameter groupIds
    info	[Changelog]   - Interface Resource has a new optional parameter systemData
    info	[Changelog]   - Added Enum KnownAgentConfigurationMode
    info	[Changelog]   - Added Enum KnownArcKindEnum
    info	[Changelog]   - Added Enum KnownAssessmentModeTypes
    info	[Changelog]   - Added Enum KnownEsuEligibility
    info	[Changelog]   - Added Enum KnownEsuKeyState
    info	[Changelog]   - Added Enum KnownEsuServerType
    info	[Changelog]   - Added Enum KnownLastAttemptStatusEnum
    info	[Changelog]   - Added Enum KnownLicenseAssignmentState
    info	[Changelog]   - Added Enum KnownLicenseCoreType
    info	[Changelog]   - Added Enum KnownLicenseEdition
    info	[Changelog]   - Added Enum KnownLicenseState
    info	[Changelog]   - Added Enum KnownLicenseTarget
    info	[Changelog]   - Added Enum KnownLicenseType
    info	[Changelog]   - Added Enum KnownOsType
    info	[Changelog]   - Added Enum KnownPatchModeTypes
    info	[Changelog]   - Added Enum KnownPatchOperationStartedBy
    info	[Changelog]   - Added Enum KnownPatchOperationStatus
    info	[Changelog]   - Added Enum KnownPatchServiceUsed
    info	[Changelog]   - Added Enum KnownProvisioningState
    info	[Changelog]   - Added Enum KnownVMGuestPatchClassificationLinux
    info	[Changelog]   - Added Enum KnownVMGuestPatchClassificationWindows
    info	[Changelog]   - Added Enum KnownVMGuestPatchRebootSetting
    info	[Changelog]   - Added Enum KnownVMGuestPatchRebootStatus
    info	[Changelog]   - Added function getContinuationToken
    info	[Changelog]
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Class HybridComputeManagementClient has a new signature
    info	[Changelog]   - Interface MachineExtensionsListNextOptionalParams no longer has parameter expand
    info	[Changelog]   - Type of parameter protectedSettings of interface MachineExtensionProperties is changed from Record<string, unknown> to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter settings of interface MachineExtensionProperties is changed from Record<string, unknown> to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from ed7dd07. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ️✔️hybridcompute [View full logs]  [Release Schema Changes]
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs]Release - Generate from ed7dd07. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ⚠️Az.hybridcompute.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.hybridcompute.DefaultTag
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from ed7dd07. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-hybridcompute [View full logs]  [Release SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 11, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/hybridcompute/armhybridcompute https://apiview.dev/Assemblies/Review/091777d58af44096a63b2a8b0a71220c
.Net Azure.ResourceManager.HybridCompute https://apiview.dev/Assemblies/Review/ef87835d419540868821f8fb2dbe9ce2
Java azure-resourcemanager-hybridcompute https://apiview.dev/Assemblies/Review/76aab185d98d4cc8be333931a098b597
JavaScript @azure/arm-hybridcompute https://apiview.dev/Assemblies/Review/ef8aea661be24dcba43e8b57e17adae2

@dkirby017
Copy link
Member Author

/pr RequestMerge

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager labels Oct 11, 2023
@openapi-workflow-bot
Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@ms-zhenhua
Copy link
Contributor

please remove ARMChangesRequested Label when it's ready for review. And Add MergeRequested label only after the PR is labeled signedoff.

@dkirby017 dkirby017 removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels Oct 12, 2023
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 12, 2023
@dkirby017 dkirby017 removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 12, 2023
@dkirby017
Copy link
Member Author

/pr RequestMerge

@dkirby017
Copy link
Member Author

just for clarity, this is a 1 character change to correct a casing discrepancy that apparently breaks the pipeline somewhere down the line and isn't checked for as part of the PR builds, for some reason. There are no actual breaking changes in this PR, despite the auto-added tags. thanks.

@rkmanda rkmanda added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 12, 2023
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 12, 2023
@rkmanda
Copy link
Member

rkmanda commented Oct 12, 2023

The PR is in the review queue. Pl request a merge when u reach step 4 as per the PR workflow diagram

@dkirby017
Copy link
Member Author

The PR is in the review queue. Pl request a merge when u reach step 4 as per the PR workflow diagram

This is correcting one character's casing. Why does this need to jump through so many hoops? Customers are complaining about the lack of documentation for this API version because the casing conflict caused a pipeline error (which I'll keep bringing up, should either be case insensitive or the PR build should be checking this). It'd be great if there was a simplified flow for absolutely trivial fixes like this.

@dkirby017 dkirby017 removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMReview labels Oct 16, 2023
@dkirby017
Copy link
Member Author

/pr RequestMerge

@dkirby017
Copy link
Member Author

again, single character change that needs to go in to fix a broken pipeline. Could we please get this merged?

@rkmanda rkmanda merged commit ed7dd07 into main Oct 16, 2023
28 of 31 checks passed
@rkmanda rkmanda deleted the dakirby/correctOperationIdCasingConflicts branch October 16, 2023 21:39
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python CI-BreakingChange-Go CI-BreakingChange-JavaScript ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants