Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 2 new APIs for VMSS: Redeploy and PerformMaintenance #2589

Merged
merged 3 commits into from
Mar 8, 2018
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2689,6 +2689,110 @@
"x-ms-long-running-operation": true
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/redeploy": {
"post": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide x-ms-examples for each of these operations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just another standard operation. Similar ones already exist in the single VM case without examples.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand but we need examples to approve new changes, it helps us validate the examples with the operations described in the spec.

"tags": [
"VirtualMachineScaleSets"
],
"operationId": "VirtualMachineScaleSets_Redeploy",
"description": "Redeploy one or more virtual machines in a VM scale set.",
"parameters": [
{
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the resource group."
},
{
"name": "vmScaleSetName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the VM scale set."
},
{
"name": "vmInstanceIDs",
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/VirtualMachineScaleSetVMInstanceRequiredIDs"
},
"description": "A list of virtual machine instance IDs from the VM scale set."
},
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/OperationStatusResponse"
}
},
"202": {
"description": "Accepted"
}
},
"x-ms-long-running-operation": true
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/performMaintenance": {
"post": {
"tags": [
"VirtualMachineScaleSets"
],
"operationId": "VirtualMachineScaleSets_PerformMaintenance",
"description": "Perform maintenance on one or more virtual machines in a VM scale set.",
"parameters": [
{
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the resource group."
},
{
"name": "vmScaleSetName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the VM scale set."
},
{
"name": "vmInstanceIDs",
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/VirtualMachineScaleSetVMInstanceRequiredIDs"
},
"description": "A list of virtual machine instance IDs from the VM scale set."
},
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/OperationStatusResponse"
}
},
"202": {
"description": "Accepted"
}
},
"x-ms-long-running-operation": true
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/manualupgrade": {
"post": {
"tags": [
Expand Down Expand Up @@ -3583,6 +3687,106 @@
"x-ms-long-running-operation": true
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualmachines/{instanceId}/redeploy": {
"post": {
"tags": [
"VirtualMachineScaleSetVMs"
],
"operationId": "VirtualMachineScaleSetVMs_Redeploy",
"description": "Redeploys a virtual machine in a VM scale set.",
"parameters": [
{
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the resource group."
},
{
"name": "vmScaleSetName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the VM scale set."
},
{
"name": "instanceId",
"in": "path",
"required": true,
"type": "string",
"description": "The instance ID of the virtual machine."
},
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/OperationStatusResponse"
}
},
"202": {
"description": "Accepted"
}
},
"x-ms-long-running-operation": true
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmScaleSetName}/virtualmachines/{instanceId}/performMaintenance": {
"post": {
"tags": [
"VirtualMachineScaleSetVMs"
],
"operationId": "VirtualMachineScaleSetVMs_PerformMaintenance",
"description": "Performs maintenance on a virtual machine in a VM scale set.",
"parameters": [
{
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the resource group."
},
{
"name": "vmScaleSetName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the VM scale set."
},
{
"name": "instanceId",
"in": "path",
"required": true,
"type": "string",
"description": "The instance ID of the virtual machine."
},
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/OperationStatusResponse"
}
},
"202": {
"description": "Accepted"
}
},
"x-ms-long-running-operation": true
}
},
"/subscriptions/{subscriptionId}/providers/Microsoft.Compute/locations/{location}/logAnalytics/apiAccess/getRequestRateByInterval": {
"post": {
"tags": [
Expand Down Expand Up @@ -6732,6 +6936,10 @@
"$ref": "#/definitions/VirtualMachineAgentInstanceView",
"description": "The VM Agent running on the virtual machine."
},
"maintenanceRedeployStatus": {
"$ref": "#/definitions/MaintenanceRedeployStatus",
"description": "The Maintenance Operation status on the virtual machine."
},
"disks": {
"type": "array",
"items": {
Expand Down