Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prettier to 3.x #25673

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Update prettier to 3.x #25673

merged 2 commits into from
Sep 6, 2023

Conversation

weshaggard
Copy link
Member

Update prettier to 3.x

  • Updated the json-swagger plugin to support the 3.x pretter
  • Switch the plugin to be JS based to avoid the need to compile via TS
  • Simplified plugin to delegate most work to the base estree plugin

Fixes #25670
Fixes Azure/azure-sdk-tools#6109

- Updated the json-swagger plugin to support the 3.x pretter
- Switch the plugin to be JS based to avoid the need to compile via TS
- Simplified plugin to delegate most work to the base estree plugin
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 5, 2023

Next Steps to Merge

⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 5, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️🔄CredScan inProgress [Detail]
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️🔄PoliCheck inProgress [Detail]
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 5, 2023

Swagger pipeline restarted successfully, please wait for status update in this comment.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 5, 2023

Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@weshaggard weshaggard assigned weshaggard and unassigned josefree Sep 5, 2023
@weshaggard weshaggard enabled auto-merge (squash) September 6, 2023 17:27
@weshaggard weshaggard merged commit 7eaa071 into Azure:main Sep 6, 2023
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

jnlycklama pushed a commit that referenced this pull request Nov 8, 2023
- Updated the json-swagger plugin to support the 3.x pretter
- Switch the plugin to be JS based to avoid the need to compile via TS
- Simplified plugin to delegate most work to the base estree plugin
- Move swagger plugin source under eng
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EngSys] Upgrade dependency "prettier" TypeScript compilation fails in azure-rest-api-specs pipelines
3 participants