Adding a new endpoint type for connection monitor and location and subscription details in 2023-06-01-preview #25590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cription detail for validation.
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| applicationGateway.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| applicationGatewayWafDynamicManifests.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| applicationSecurityGroup.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| availableDelegations.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| availableServiceAliases.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| azureFirewall.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| azureFirewallFqdnTag.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| azureWebCategory.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| bastionHost.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| checkDnsAvailability.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| cloudServiceNetworkInterface.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| cloudServicePublicIpAddress.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| cloudServiceSwap.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| customIpPrefix.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| ddosCustomPolicy.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| ddosProtectionPlan.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| dscpConfiguration.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| endpointService.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| expressRouteCircuit.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| expressRouteCrossConnection.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| expressRoutePort.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| expressRouteProviderPort.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| firewallPolicy.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| ipAllocation.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| ipGroups.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| loadBalancer.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| natGateway.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| network.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| network.json | 2023-06-01-preview(5ab1439) | 2022-06-01-preview(main) |
| networkInterface.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| networkManager.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| networkManager.json | 2023-06-01-preview(5ab1439) | 2022-04-01-preview(main) |
| networkManagerActiveConfiguration.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| networkManagerActiveConfiguration.json | 2023-06-01-preview(5ab1439) | 2022-04-01-preview(main) |
| networkManagerConnection.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| networkManagerConnection.json | 2023-06-01-preview(5ab1439) | 2022-04-01-preview(main) |
| networkManagerConnectivityConfiguration.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| networkManagerConnectivityConfiguration.json | 2023-06-01-preview(5ab1439) | 2022-04-01-preview(main) |
| networkManagerEffectiveConfiguration.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| networkManagerEffectiveConfiguration.json | 2023-06-01-preview(5ab1439) | 2022-04-01-preview(main) |
| networkManagerGroup.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| networkManagerGroup.json | 2023-06-01-preview(5ab1439) | 2022-04-01-preview(main) |
| networkManagerScopeConnection.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| networkManagerScopeConnection.json | 2023-06-01-preview(5ab1439) | 2022-04-01-preview(main) |
| networkManagerSecurityAdminConfiguration.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| networkManagerSecurityAdminConfiguration.json | 2023-06-01-preview(5ab1439) | 2022-04-01-preview(main) |
| networkProfile.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| networkSecurityGroup.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| networkVirtualAppliance.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| networkWatcher.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| operation.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| privateEndpoint.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| privateLinkService.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| publicIpAddress.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| publicIpPrefix.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| routeFilter.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| routeTable.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| securityPartnerProvider.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| serviceCommunity.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| serviceEndpointPolicy.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| serviceTags.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| usage.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| virtualNetwork.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| virtualNetworkGateway.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| virtualNetworkTap.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| virtualRouter.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| virtualWan.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| vmssNetworkInterface.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| vmssPublicIpAddress.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
| webapplicationfirewall.json | 2023-06-01-preview(5ab1439) | 2023-05-01(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 12 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/listEffectiveVirtualNetworks' removed or restructured? Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L418:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/listActiveSecurityUserRules' removed or restructured? Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L143:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/networkGroups/{networkGroupName}/listEffectiveVirtualNetworks' removed or restructured? Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerGroup.json#L240:5 |
|
| The new version is missing a definition that was found in the old version. Was 'EffectiveVirtualNetworksParameter' removed or renamed? New: Microsoft.Network/preview/2023-06-01-preview/networkManager.json#L422:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L476:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ActiveSecurityUserRule' removed or renamed? New: Microsoft.Network/preview/2023-06-01-preview/networkManagerActiveConfiguration.json#L150:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ActiveDefaultSecurityUserRule' removed or renamed? New: Microsoft.Network/preview/2023-06-01-preview/networkManagerActiveConfiguration.json#L150:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3 |
|
| The new version is missing a definition that was found in the old version. Was 'DefaultUserRulePropertiesFormat' removed or renamed? New: Microsoft.Network/preview/2023-06-01-preview/networkManagerActiveConfiguration.json#L150:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3 |
|
| The new version is missing a definition that was found in the old version. Was 'UserRulePropertiesFormat' removed or renamed? New: Microsoft.Network/preview/2023-06-01-preview/networkManagerActiveConfiguration.json#L150:3 Old: Microsoft.Network/preview/2022-04-01-preview/networkManagerActiveConfiguration.json#L197:3 |
|
| The new version is removing enum value(s) 'SecurityUser' from the old version. New: Microsoft.Network/preview/2023-06-01-preview/networkManager.json#L504:11 Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L558:11 |
|
| The new version is removing enum value(s) 'SecurityUser' from the old version. New: Microsoft.Network/preview/2023-06-01-preview/networkManager.json#L576:9 Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L625:9 |
|
| The new version is removing enum value(s) 'SecurityUser' from the old version. New: Microsoft.Network/preview/2023-06-01-preview/networkManager.json#L613:11 Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L661:11 |
|
| The new version is removing enum value(s) 'SecurityUser' from the old version. New: Microsoft.Network/preview/2023-06-01-preview/networkManager.json#L676:9 Old: Microsoft.Network/preview/2022-04-01-preview/networkManager.json#L724:9 |
️❌CredScan: 0 Errors, 0 Warnings failed [Detail]
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| compared tags (via openapi-validator v2.1.4) | new version | base version |
|---|---|---|
| default | default(5ab1439) | default(main) |
️❌Avocado: 760 Errors, 0 Warnings failed [Detail]
Only 12 items are listed, please refer to log for more details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 442 Errors, 0 Warnings failed [Detail]
Only 12 items are listed, please refer to log for more details.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=383935&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from d582fb474f135d269768efe17aacfd68ea1fa23e. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.Network [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from d582fb474f135d269768efe17aacfd68ea1fa23e. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.ResourceManager.Network [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.FirewallPolicyRuleCollectionGroupData Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.FirewallPolicyRuleCollectionGroupData(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.ETag>, System.Nullable<System.Int32>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.FirewallPolicyRuleCollectionInfo>, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.SubnetData Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.SubnetData(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.ETag>, System.String, System.Collections.Generic.IEnumerable<System.String>, Azure.ResourceManager.Network.NetworkSecurityGroupData, Azure.ResourceManager.Network.RouteTableData, Azure.Core.ResourceIdentifier, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ServiceEndpointProperties>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.ServiceEndpointPolicyData>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.PrivateEndpointData>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.NetworkIPConfiguration>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.NetworkIPConfigurationProfile>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Resources.Models.WritableSubResource>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ResourceNavigationLink>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ServiceAssociationLink>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ServiceDelegation>, System.String, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>, System.Nullable<Azure.ResourceManager.Network.Models.VirtualNetworkPrivateEndpointNetworkPolicy>, System.Nullable<Azure.ResourceManager.Network.Models.VirtualNetworkPrivateLinkServiceNetworkPolicy>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ApplicationGatewayIPConfiguration>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.VirtualNetworkGatewayData Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.VirtualNetworkGatewayData(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.Core.AzureLocation>, System.Collections.Generic.IDictionary<System.String, System.String>, Azure.ResourceManager.Resources.Models.ExtendedLocation, System.Nullable<Azure.ETag>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.VirtualNetworkGatewayIPConfiguration>, System.Nullable<Azure.ResourceManager.Network.Models.VirtualNetworkGatewayType>, System.Nullable<Azure.ResourceManager.Network.Models.VpnType>, System.Nullable<Azure.ResourceManager.Network.Models.VpnGatewayGeneration>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, Azure.Core.ResourceIdentifier, Azure.ResourceManager.Network.Models.VirtualNetworkGatewaySku, Azure.ResourceManager.Network.Models.VpnClientConfiguration, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.VirtualNetworkGatewayPolicyGroup>, Azure.ResourceManager.Network.Models.BgpSettings, System.Collections.Generic.IEnumerable<System.String>, System.Nullable<System.Guid>, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>, System.Nullable<System.Boolean>, System.String, Azure.Core.ResourceIdentifier, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.VirtualNetworkGatewayNatRuleData>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<Azure.ResourceManager.Network.Models.ExpressRouteGatewayAdminState>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Network/Debug/netstandard2.0/Azure.ResourceManager.Network.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from d582fb474f135d269768efe17aacfd68ea1fa23e. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] notice cmderr [automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.0.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.0.0> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-network [View full logs] [Preview SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - Model BastionHost has a new parameter network_acls info [Changelog] - Model BastionHost has a new parameter virtual_network info [Changelog] - Model FirewallPolicy has a new parameter size info [Changelog] - Model FirewallPolicyRuleCollectionGroup has a new parameter size info [Changelog] - Model Subnet has a new parameter default_outbound_access info [Changelog] - Model VirtualNetworkGateway has a new parameter auto_scale_configuration
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from d582fb474f135d269768efe17aacfd68ea1fa23e. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-network-generated [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from d582fb474f135d269768efe17aacfd68ea1fa23e. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/network/armnetwork [View full logs] [Preview SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - New struct `BastionHostPropertiesFormatNetworkACLs` info [Changelog] - New struct `IPRule` info [Changelog] - New struct `VirtualNetworkGatewayAutoScaleBounds` info [Changelog] - New struct `VirtualNetworkGatewayAutoScaleConfiguration` info [Changelog] - New field `NetworkACLs`, `VirtualNetwork` in struct `BastionHostPropertiesFormat` info [Changelog] - New field `Size` in struct `FirewallPolicyPropertiesFormat` info [Changelog] - New field `Size` in struct `FirewallPolicyRuleCollectionGroupProperties` info [Changelog] - New field `DefaultOutboundAccess` in struct `SubnetPropertiesFormat` info [Changelog] - New field `AutoScaleConfiguration` in struct `VirtualNetworkGatewayPropertiesFormat` info [Changelog] info [Changelog] Total 0 breaking change(s), 13 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from d582fb474f135d269768efe17aacfd68ea1fa23e. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-network [View full logs] [Preview SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Added Interface BastionHostPropertiesFormatNetworkAcls info [Changelog] - Added Interface IPRule info [Changelog] - Added Interface VirtualNetworkGatewayAutoScaleBounds info [Changelog] - Added Interface VirtualNetworkGatewayAutoScaleConfiguration info [Changelog] - Interface BastionHost has a new optional parameter networkAcls info [Changelog] - Interface BastionHost has a new optional parameter virtualNetwork info [Changelog] - Interface FirewallPolicy has a new optional parameter size info [Changelog] - Interface FirewallPolicyRuleCollectionGroup has a new optional parameter size info [Changelog] - Interface Subnet has a new optional parameter defaultOutboundAccess info [Changelog] - Interface VirtualNetworkGateway has a new optional parameter autoScaleConfiguration
️❌ azure-resource-manager-schemas failed [Detail]
❌Code Generator Failed [Logs] Generate from d582fb474f135d269768efe17aacfd68ea1fa23e. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] ERR! code EBADENGINE cmderr [initScript.sh] Unsupported engine cmderr [initScript.sh] npm ERR! engine Not compatible with your version of node/npm: [email protected] cmderr [initScript.sh] npm ERR! notsup Not compatible with your version of node/npm: [email protected] cmderr [initScript.sh] npm ERR! notsup Required: {"node":"^18.17.0 || >=20.5.0"} cmderr [initScript.sh] npm ERR! notsup Actual: {"npm":"8.19.4","node":"v16.20.2"} cmderr [initScript.sh] A complete log of this run can be found in: cmderr [initScript.sh] npm ERR! /home/cloudtest/.npm/_logs/2023-09-05T10_00_04_284Z-debug-0.log error Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json cmderr [generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500 cmderr [generateScript.sh] return new TSError(diagnosticText, diagnosticCodes) cmderr [generateScript.sh] ^ cmderr [generateScript.sh] TSError: ⨯ Unable to compile TypeScript: cmderr [generateScript.sh] cmd/generateall.ts(7,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(11,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(12,18): error TS2307: Cannot find module 'path' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(14,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(15,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(64,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(81,67): error TS7006: Parameter 'x' implicitly has an 'any' type. cmderr [generateScript.sh] cmd/generateall.ts(82,49): error TS7006: Parameter 'f' implicitly has an 'any' type. cmderr [generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(117,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(118,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(169,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i @types/node` and then add `node` to the types field in your tsconfig. cmderr [generateScript.sh] at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12) cmderr [generateScript.sh] at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19) cmderr [generateScript.sh] at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36) cmderr [generateScript.sh] at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32) cmderr [generateScript.sh] at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43) cmderr [generateScript.sh] at Module._extensions..js (node:internal/modules/cjs/loader:1252:10) cmderr [generateScript.sh] at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12) cmderr [generateScript.sh] at Module.load (node:internal/modules/cjs/loader:1076:32) cmderr [generateScript.sh] at Function.Module._load (node:internal/modules/cjs/loader:911:12) cmderr [generateScript.sh] at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12) cmderr [generateScript.sh] cmderr [generateScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.0.0 cmderr [generateScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.0.0> cmderr [generateScript.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [generateScript.sh] npm notice error Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh warn Skip package processing as generation is failed
️❌ azure-powershell failed [Detail]
❌Pipeline Framework Failed [Logs] Generate from d582fb474f135d269768efe17aacfd68ea1fa23e. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json SSL error: syscall failure: Broken pipe Error: SSL error: syscall failure: Broken pipe
⚠️Az.network.DefaultTag [View full logs]error Fatal error: SSL error: syscall failure: Broken pipe error The following packages are still pending: error Az.network.DefaultTag
Generated ApiView
|
v-sapanchal
changed the title
This was referenced Aug 30, 2023
AzureRestAPISpecReview
added
ARMReview
CI-MissingBaseCommit
new-api-version
resource-manager
WaitForARMFeedback
|
Hi @v-sapanchal! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
kumaam
approved these changes
Sep 5, 2023
|
Please address or respond to feedback from the ARM API reviewer. |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
Hi @mentat9 , Could you please help me, how can I resolve this comment. |
@v-sapanchal - I (and the automation) can't find any evidence for the current existence of the 2023-06-01-preview API version, so this PR appears to be for a new API version, so:
|
Hi @mentat9 , I have already raised separated PR, this is the separated one , |
|
Hi, @v-sapanchal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
1 similar comment
|
Hi, @v-sapanchal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @v-sapanchal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
4 similar comments
|
Hi, @v-sapanchal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @v-sapanchal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @v-sapanchal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @v-sapanchal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @v-sapanchal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
9 similar comments
|
Hi, @v-sapanchal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @v-sapanchal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @v-sapanchal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @v-sapanchal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @v-sapanchal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @v-sapanchal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @v-sapanchal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @v-sapanchal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @v-sapanchal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @v-sapanchal. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.