Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.OffAzure to add version stable/2023-06-06 #25366

Merged
merged 22 commits into from
Sep 5, 2023
Merged

[Hub Generated] Review request for Microsoft.OffAzure to add version stable/2023-06-06 #25366

merged 22 commits into from
Sep 5, 2023

Conversation

tarsharm
Copy link
Contributor

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Getting help

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 17, 2023 •
edited
Loading

Next Steps to Merge

⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 17, 2023 •
edited
Loading

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
Rule Message
❌ Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/ea0fbe571b4da073b7a2f274e1cbeacedcf15ead/specification/migrate/resource-manager/Microsoft.Migrate/MordernizeProjects/preview/2022-05-01-preview/migrateEngine.json",
"old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/migrate/resource-manager/Microsoft.Migrate/MordernizeProjects/preview/2022-05-01-preview/migrateEngine.json",
"details":"Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.57/common/temp/node_modules/.pnpm/@Azure[email protected]/node_modules/autorest/dist/app.js" --v2 --input-file=/mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specification/migrate/resource-manager/Microsoft.Migrate/MordernizeProjects/preview/2022-05-01-preview/migrateEngine.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nERROR: Referenced file 'file:///mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specification/migrate/common-types/resource-management/v3/types.json' not found\n - file:///mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specification/migrate/resource-manager/Microsoft.Migrate/MordernizeProjects/preview/2022-05-01-preview/migrateEngine.json:34:14 ($.paths["/providers/Microsoft.Migrate/operations"].get.responses.default.schema["$ref"])\nFATAL: swagger-document/loader - FAILED\nFATA"
️❌Breaking Change(Cross-Version): 123 Errors, 32 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
migrate.json 2023-06-06(ea0fbe5) 2020-07-07(main)

The following breaking changes are detected by comparison with the latest stable version:

Only 30 items are listed, please refer to log for more details.

Rule Message
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/clusters/{clusterName}' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L44:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/clusters' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L188:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/hosts/{hostName}' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L256:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/hosts' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L400:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/jobs/{jobName}' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L468:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/jobs' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L534:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/machines/{machineName}' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L596:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/machines' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L662:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/operationsStatus/{operationStatusName}' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L752:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/runAsAccounts/{accountName}' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L818:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/runAsAccounts' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L884:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L946:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/refresh' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1210:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/healthSummary' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1272:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/jobs/{jobName}' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1334:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/jobs' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1400:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/machines/{machineName}' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1462:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/machines' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1528:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/machines/{machineName}/stop' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1618:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/machines/{machineName}/start' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1687:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/runAsAccounts/{accountName}' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1756:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/runAsAccounts' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1822:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L1884:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/refresh' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L2148:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/healthSummary' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L2210:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/vCenters/{vcenterName}' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L2272:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/vCenters' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L2480:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/operationsStatus/{operationStatusName}' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L2548:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/HyperVSites/{siteName}/summary' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L2614:5
❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OffAzure/VMwareSites/{siteName}/summary' removed or restructured?
Old: Microsoft.OffAzure/stable/2020-07-07/migrate.json#L2672:5
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️️✔️LintDiff succeeded [Detail]
Rule Message
❌ LintDiffToolException "details":""stack":"ResolverError: Error reading file \"/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json\"\n at onError (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.57/common/temp/node_modules/.pnpm/@APIDevTools[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/parse.js:92:16)",
"code":"ERESOLVER",
"message":"Error reading file \"/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json\"",
"source":"/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json",
"path":null,
"name":"ResolverError",
"footprint":"null+/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json+ERESOLVER+Error reading file \"/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json\"""
️❌Avocado: 158 Errors, 0 Warnings failed [Detail]

Only 30 items are listed, please refer to log for more details.

Rule Message
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /providers/Microsoft.OffAzure/operations is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/masterSites/{}/privateEndpointConnections/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/masterSites/{}/privateEndpointConnections is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/masterSites/{}/privateLinkResources/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/masterSites/{}/privateLinkResources is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.OffAzure/hypervSites is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.OffAzure/importSites is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.OffAzure/masterSites is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.OffAzure/serverSites is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.OffAzure/vmwareSites is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{}/clientGroupMembers is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{}/clusters is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{}/clusters/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{}/computeErrorSummary is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{}/computeusage is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{}/exportApplications is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{}/exportDependencies is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{}/exportMachineErrors is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{}/generateCoarseMap is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{}/generateDetailedMap is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{}/hosts is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{}/hosts/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{}/jobs is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{}/jobs/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{}/listHealthSummary is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{}/machines is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{}/machines/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
❌ MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.OffAzure/hypervSites/{}/machines/{}/softwareinventories is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/migrate/resource-manager/readme.md
json: Microsoft.OffAzure/stable/2023-06-06/migrate.json
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand] 
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail]
Rule Message
❌ LintRpaasToolException "details":""stack":"ResolverError: Error reading file \"/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json\"\n at onError (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.57/common/temp/node_modules/.pnpm/@APIDevTools[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/parse.js:92:16)\n at processTicksAndRejections (internal/process/task_queues.js:95:5)",
"code":"ERESOLVER",
"message":"Error reading file \"/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json\"",
"source":"/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json",
"path":null,
"name":"ResolverError",
"footprint":"null+/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json+ERESOLVER+Error reading file \"/mnt/vss/_work/1/azure-rest-api-specs/specification/migrate/common-types/resource-management/v3/types.json\"""
️❌PR Summary: 0 Errors, 0 Warnings failed [Detail]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 17, 2023 •
edited
Loading

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand] 
 Please click here to preview with your @microsoft account.
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking


️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from baa8239. SDK Automation 14.0.0 
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.Migrate [View full logs]  [Release SDK Changes] 
    info	[Changelog]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from baa8239. SDK Automation 14.0.0 
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/migrate/armmigrate [View full logs]  [Release SDK Changes] 
    info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from baa8239. SDK Automation 14.0.0 
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.
  • ️✔️@azure/arm-migrate [View full logs]  [Release SDK Changes] 
    info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️❌ azure-resource-manager-schemas failed [Detail]
  • ❌Code Generator Failed [Logs]Release - Generate from baa8239. Schema Automation 14.0.0 
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] ERR! code EBADENGINE
cmderr	[initScript.sh]  Unsupported engine
cmderr	[initScript.sh] npm ERR! engine Not compatible with your version of node/npm: [email protected]
cmderr	[initScript.sh] npm ERR! notsup Not compatible with your version of node/npm: [email protected]
cmderr	[initScript.sh] npm ERR! notsup Required: {"node":"^18.17.0 || >=20.5.0"}
cmderr	[initScript.sh] npm ERR! notsup Actual:   {"npm":"8.19.4","node":"v16.20.2"}
cmderr	[initScript.sh] ERR! A complete log of this run can be found in:
cmderr	[initScript.sh] npm ERR!     /home/cloudtest/.npm/_logs/2023-09-05T20_32_02_236Z-debug-0.log
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(7,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(12,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(15,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(64,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(81,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(82,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(117,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(118,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(169,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i @types/node` and then add `node` to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1076:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:911:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
cmderr	[generateScript.sh]  notice
cmderr	[generateScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.0.0
cmderr	[generateScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.0.0>
cmderr	[generateScript.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[generateScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Skip package processing as generation is failed
️❌ azure-powershell failed [Detail]
  • ❌Pipeline Framework Failed [Logs]Release - Generate from baa8239. SDK Automation 14.0.0 
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe
  • ️✔️Az.migrate.DefaultTag [View full logs]  
    error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.migrate.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 17, 2023 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/migrate/armmigrate There is no API change compared with the previous version
.Net Azure.ResourceManager.Migrate https://apiview.dev/Assemblies/Review/a6a3b6c9a2f74154931a8e23f9463fbb
JavaScript @azure/arm-migrate There is no API change compared with the previous version

This was referenced Aug 17, 2023
Draft
Draft
Closed
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 19, 2023 •
edited
Loading

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 19, 2023 •
edited
Loading

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane new-api-version resource-manager labels Aug 19, 2023
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 19, 2023 •
edited
Loading

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 19, 2023 •
edited
Loading

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 19, 2023 •
edited
Loading

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 20, 2023 •
edited
Loading

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

@tarsharm tarsharm marked this pull request as ready for review August 21, 2023 11:46
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 21, 2023 •
edited
Loading

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

@AzureRestAPISpecReview AzureRestAPISpecReview added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 21, 2023
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 31, 2023
@sjanamma sjanamma added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 31, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 31, 2023
@tarsharm
Copy link
Contributor Author

tarsharm commented Sep 1, 2023

/pr RequestMerge

@tarsharm
Copy link
Contributor Author

tarsharm commented Sep 1, 2023

/pr RequestMerge

@anuchandy anuchandy added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Sep 1, 2023
@openapi-workflow-bot openapi-workflow-bot bot added commitAfterSignedOff and removed Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates labels Sep 2, 2023
This was referenced Sep 2, 2023
Closed
Closed
@tarsharm
Copy link
Contributor Author

tarsharm commented Sep 2, 2023

/pr RequestMerge

@tarsharm
Copy link
Contributor Author

tarsharm commented Sep 4, 2023

/pr RequestMerge

@mentat9
Copy link
Member

mentat9 commented Sep 5, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mentat9 mentat9 merged commit baa8239 into main Sep 5, 2023
@mentat9 mentat9 deleted the tarsharm-SwashBuckle-migrate-Microsoft.OffAzure-2023-06-06 branch September 5, 2023 20:27
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

This was referenced Sep 5, 2023
Closed
Closed
Closed
jnlycklama pushed a commit that referenced this pull request Nov 8, 2023
@tarsharm @anuchandy @jnlycklama
[Hub Generated] Review request for Microsoft.OffAzure to add version …
26d9082 
…stable/2023-06-06 (#25366)

* Adds base for updating Microsoft.OffAzure from version stable/2020-07-07 to version 2023-06-06

* Updates readme

* Updates API version in new specs and examples

* Initial Swagger

* adding types.json

* Resolve casing errors

* resolve casing issues

* Define importSites API for importJobs with GET/LIST call

* Fixing checks

* Prettier changes and spell check

* Prettier fixes

* Prettier fix

* OAV example fixes (#25512)

* OAV example fixes (#25514)

* oav example fixes (#25523)

* Remove data-plane folder

* removed common-types

* Remove dupilcate key

* Remove duplicate key

* Fix no input file error

---------

Co-authored-by: Anu Thomas Chandy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkmanda rkmanda rkmanda left review comments

@anuchandy anuchandy anuchandy approved these changes

Assignees

@anuchandy anuchandy

Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-ModelValidation ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required commitAfterSignedOff new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tarsharm @mikekistler @rkmanda @mentat9 @anuchandy @JeffreyRichter @AzureRestAPISpecReview @sjanamma