[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2023-08-01 #25305

thramu · 2023-08-15T03:00:56Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] public repo review queue, private repo review queue
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- Adding a new api from public preview to stable version

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-08-15T03:01:00Z

Swagger Validation Report

️❌BreakingChange: 9 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
costmanagement.exports.json	2023-08-01(adf2e88)	2023-08-01(main)
costallocation.json	2023-08-01(adf2e88)	2023-08-01(main)
settings.json	2023-08-01(adf2e88)	2023-08-01(main)

Rule	Message
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.CostManagement/stable/2023-08-01/costallocation.json#L42:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.CostManagement/stable/2023-08-01/costallocation.json#L81:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.CostManagement/stable/2023-08-01/costallocation.json#L126:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.CostManagement/stable/2023-08-01/settings.json#L36:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.CostManagement/stable/2023-08-01/settings.json#L75:5
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'identity' in response that was not found in the old version. New: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L418:7 Old: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L418:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'location' in response that was not found in the old version. New: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L418:7 Old: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L418:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'identity' that was not found in the old version. New: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L418:7 Old: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L418:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'location' that was not found in the old version. New: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L418:7 Old: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L418:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.4)	new version	base version
package-2023-08	package-2023-08(adf2e88)	package-2023-08(main)

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.CostManagement/exports/{exportName}' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.CostManagement/exports' that has the scope parameter.'. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L36
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.CostManagement/exports/{exportName}/run' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.CostManagement/exports' that has the scope parameter.'. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L36
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.CostManagement/exports/{exportName}/runHistory' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.CostManagement/exports' that has the scope parameter.'. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L36
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L84
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.CostManagement/exports/{exportName}/run' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.CostManagement/exports/{exportName}' that has the scope parameter.'. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L97
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.CostManagement/exports/{exportName}/runHistory' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.CostManagement/exports/{exportName}' that has the scope parameter.'. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L97
`❌` ResourceNameRestriction	The resource name parameter 'exportName' should be defined with a 'pattern' restriction. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L97
`❌` ParametersInPointGet	Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L127
`❌` PutResponseSchemaDescription	Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L209
`❌` DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L270
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.CostManagement/exports/{exportName}/runHistory' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.CostManagement/exports/{exportName}/run' that has the scope parameter.'. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L283
`❌` ResourceNameRestriction	The resource name parameter 'exportName' should be defined with a 'pattern' restriction. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L283
`❌` SyncPostReturn	200 response for a synchronous POST operation must have a response schema specified. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L284
`❌` ResourceNameRestriction	The resource name parameter 'exportName' should be defined with a 'pattern' restriction. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L337
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L381
`❌` TopLevelResourcesListBySubscription	The top-level resource 'Export' does not have list by subscription operation, please add it. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L410
⚠️ PageableOperation	Based on the response model schema, operation 'Exports_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L37
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'scope'. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L66
⚠️ RequiredReadOnlySystemData	The response of operation:'Exports_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L98
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'scope'. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L127
⚠️ RequiredReadOnlySystemData	The response of operation:'Exports_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L160
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'scope'. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L189
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'scope'. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L259
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'run' in:'Exports_Execute'. Consider updating the operationId Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L288
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'scope'. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L313
⚠️ ListInOperationName	Since operation response has model definition in array type, it should be of the form '_list'. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L338
⚠️ PageableOperation	Based on the response model schema, operation 'Exports_GetExecutionHistory' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L338
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'scope'. Location: Microsoft.CostManagement/stable/2023-08-01/costmanagement.exports.json#L367

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2023-08-15T03:01:00Z

Hi, @thramu! Thank you for your pull request. To help get your PR merged:

Ensure you reviewed the checklists in the PR description.

Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

openapi-pipeline-app · 2023-08-15T03:01:00Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from d53d0d9. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:805
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 805 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:881
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 881 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:805
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 805 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:881
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 881 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.Cost-Management [View full logs] [Release SDK Changes]
```
info	[Changelog]
```
❌Azure.ResourceManager.CostManagement [View full logs] [Release SDK Changes]
```
info	[Changelog]
```

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from d53d0d9. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/costmanagement/armcostmanagement [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `OperationStatusTypeComplete` added to enum type `OperationStatusType`
info	[Changelog] - New enum type `BenefitUtilizationSummaryReportSchema` with values `BenefitUtilizationSummaryReportSchemaAvgUtilizationPercentage`, `BenefitUtilizationSummaryReportSchemaBenefitID`, `BenefitUtilizationSummaryReportSchemaBenefitOrderID`, `BenefitUtilizationSummaryReportSchemaBenefitType`, `BenefitUtilizationSummaryReportSchemaKind`, `BenefitUtilizationSummaryReportSchemaMaxUtilizationPercentage`, `BenefitUtilizationSummaryReportSchemaMinUtilizationPercentage`, `BenefitUtilizationSummaryReportSchemaUsageDate`, `BenefitUtilizationSummaryReportSchemaUtilizedPercentage`
info	[Changelog] - New enum type `BudgetNotificationOperatorType` with values `BudgetNotificationOperatorTypeEqualTo`, `BudgetNotificationOperatorTypeGreaterThan`, `BudgetNotificationOperatorTypeGreaterThanOrEqualTo`, `BudgetNotificationOperatorTypeLessThan`
info	[Changelog] - New enum type `BudgetOperatorType` with values `BudgetOperatorTypeIn`
info	[Changelog] - New enum type `CategoryType` with values `CategoryTypeCost`, `CategoryTypeReservationUtilization`
info	[Changelog] - New enum type `CostAllocationPolicyType` with values `CostAllocationPolicyTypeFixedProportion`
info	[Changelog] - New enum type `CostAllocationResourceType` with values `CostAllocationResourceTypeDimension`, `CostAllocationResourceTypeTag`
info	[Changelog] - New enum type `CultureCode` with values `CultureCodeCsCz`, `CultureCodeDaDk`, `CultureCodeDeDe`, `CultureCodeEnGb`, `CultureCodeEnUs`, `CultureCodeEsEs`, `CultureCodeFrFr`, `CultureCodeHuHu`, `CultureCodeItIt`, `CultureCodeJaJp`, `CultureCodeKoKr`, `CultureCodeNbNo`, `CultureCodeNlNl`, `CultureCodePlPl`, `CultureCodePtBr`, `CultureCodePtPt`, `CultureCodeRuRu`, `CultureCodeSvSe`, `CultureCodeTrTr`, `CultureCodeZhCn`, `CultureCodeZhTw`
info	[Changelog] - New enum type `Frequency` with values `FrequencyDaily`, `FrequencyMonthly`, `FrequencyWeekly`
info	[Changelog] - New enum type `Reason` with values `ReasonAlreadyExists`, `ReasonInvalid`, `ReasonValid`
info	[Changelog] - New enum type `RuleStatus` with values `RuleStatusActive`, `RuleStatusNotActive`, `RuleStatusProcessing`
info	[Changelog] - New enum type `SettingType` with values `SettingTypeTaginheritance`
info	[Changelog] - New enum type `SettingsKind` with values `SettingsKindTaginheritance`
info	[Changelog] - New enum type `SystemAssignedServiceIdentityType` with values `SystemAssignedServiceIdentityTypeNone`, `SystemAssignedServiceIdentityTypeSystemAssigned`
info	[Changelog] - New enum type `ThresholdType` with values `ThresholdTypeActual`, `ThresholdTypeForecasted`
info	[Changelog] - New enum type `TimeGrainType` with values `TimeGrainTypeAnnually`, `TimeGrainTypeBillingAnnual`, `TimeGrainTypeBillingMonth`, `TimeGrainTypeBillingQuarter`, `TimeGrainTypeLast30Days`, `TimeGrainTypeLast7Days`, `TimeGrainTypeMonthly`, `TimeGrainTypeQuarterly`
info	[Changelog] - New function `NewBudgetsClient(azcore.TokenCredential, *arm.ClientOptions) (*BudgetsClient, error)`
info	[Changelog] - New function `*BudgetsClient.CreateOrUpdate(context.Context, string, string, Budget, *BudgetsClientCreateOrUpdateOptions) (BudgetsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*BudgetsClient.Delete(context.Context, string, string, *BudgetsClientDeleteOptions) (BudgetsClientDeleteResponse, error)`
info	[Changelog] - New function `*BudgetsClient.Get(context.Context, string, string, *BudgetsClientGetOptions) (BudgetsClientGetResponse, error)`
info	[Changelog] - New function `*BudgetsClient.NewListPager(string, *BudgetsClientListOptions) *runtime.Pager[BudgetsClientListResponse]`
info	[Changelog] - New function `*ClientFactory.NewBudgetsClient() *BudgetsClient`
info	[Changelog] - New function `*ClientFactory.NewCostAllocationRulesClient() *CostAllocationRulesClient`
info	[Changelog] - New function `*ClientFactory.NewGenerateBenefitUtilizationSummariesReportClient() *GenerateBenefitUtilizationSummariesReportClient`
info	[Changelog] - New function `*ClientFactory.NewSettingsClient() *SettingsClient`
info	[Changelog] - New function `NewCostAllocationRulesClient(azcore.TokenCredential, *arm.ClientOptions) (*CostAllocationRulesClient, error)`
info	[Changelog] - New function `*CostAllocationRulesClient.CheckNameAvailability(context.Context, string, CostAllocationRuleCheckNameAvailabilityRequest, *CostAllocationRulesClientCheckNameAvailabilityOptions) (CostAllocationRulesClientCheckNameAvailabilityResponse, error)`
info	[Changelog] - New function `*CostAllocationRulesClient.CreateOrUpdate(context.Context, string, string, CostAllocationRuleDefinition, *CostAllocationRulesClientCreateOrUpdateOptions) (CostAllocationRulesClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*CostAllocationRulesClient.Delete(context.Context, string, string, *CostAllocationRulesClientDeleteOptions) (CostAllocationRulesClientDeleteResponse, error)`
info	[Changelog] - New function `*CostAllocationRulesClient.Get(context.Context, string, string, *CostAllocationRulesClientGetOptions) (CostAllocationRulesClientGetResponse, error)`
info	[Changelog] - New function `*CostAllocationRulesClient.NewListPager(string, *CostAllocationRulesClientListOptions) *runtime.Pager[CostAllocationRulesClientListResponse]`
info	[Changelog] - New function `NewGenerateBenefitUtilizationSummariesReportClient(azcore.TokenCredential, *arm.ClientOptions) (*GenerateBenefitUtilizationSummariesReportClient, error)`
info	[Changelog] - New function `*GenerateBenefitUtilizationSummariesReportClient.BeginGenerateByBillingAccount(context.Context, string, BenefitUtilizationSummariesRequest, *GenerateBenefitUtilizationSummariesReportClientBeginGenerateByBillingAccountOptions) (*runtime.Poller[GenerateBenefitUtilizationSummariesReportClientGenerateByBillingAccountResponse], error)`
info	[Changelog] - New function `*GenerateBenefitUtilizationSummariesReportClient.BeginGenerateByBillingProfile(context.Context, string, string, BenefitUtilizationSummariesRequest, *GenerateBenefitUtilizationSummariesReportClientBeginGenerateByBillingProfileOptions) (*runtime.Poller[GenerateBenefitUtilizationSummariesReportClientGenerateByBillingProfileResponse], error)`
info	[Changelog] - New function `*GenerateBenefitUtilizationSummariesReportClient.BeginGenerateByReservationID(context.Context, string, string, BenefitUtilizationSummariesRequest, *GenerateBenefitUtilizationSummariesReportClientBeginGenerateByReservationIDOptions) (*runtime.Poller[GenerateBenefitUtilizationSummariesReportClientGenerateByReservationIDResponse], error)`
info	[Changelog] - New function `*GenerateBenefitUtilizationSummariesReportClient.BeginGenerateByReservationOrderID(context.Context, string, BenefitUtilizationSummariesRequest, *GenerateBenefitUtilizationSummariesReportClientBeginGenerateByReservationOrderIDOptions) (*runtime.Poller[GenerateBenefitUtilizationSummariesReportClientGenerateByReservationOrderIDResponse], error)`
info	[Changelog] - New function `*GenerateBenefitUtilizationSummariesReportClient.BeginGenerateBySavingsPlanID(context.Context, string, string, BenefitUtilizationSummariesRequest, *GenerateBenefitUtilizationSummariesReportClientBeginGenerateBySavingsPlanIDOptions) (*runtime.Poller[GenerateBenefitUtilizationSummariesReportClientGenerateBySavingsPlanIDResponse], error)`
info	[Changelog] - New function `*GenerateBenefitUtilizationSummariesReportClient.BeginGenerateBySavingsPlanOrderID(context.Context, string, BenefitUtilizationSummariesRequest, *GenerateBenefitUtilizationSummariesReportClientBeginGenerateBySavingsPlanOrderIDOptions) (*runtime.Poller[GenerateBenefitUtilizationSummariesReportClientGenerateBySavingsPlanOrderIDResponse], error)`
info	[Changelog] - New function `*Setting.GetSetting() *Setting`
info	[Changelog] - New function `NewSettingsClient(azcore.TokenCredential, *arm.ClientOptions) (*SettingsClient, error)`
info	[Changelog] - New function `*SettingsClient.CreateOrUpdateByScope(context.Context, string, SettingType, SettingClassification, *SettingsClientCreateOrUpdateByScopeOptions) (SettingsClientCreateOrUpdateByScopeResponse, error)`
info	[Changelog] - New function `*SettingsClient.DeleteByScope(context.Context, string, SettingType, *SettingsClientDeleteByScopeOptions) (SettingsClientDeleteByScopeResponse, error)`
info	[Changelog] - New function `*SettingsClient.GetByScope(context.Context, string, SettingType, *SettingsClientGetByScopeOptions) (SettingsClientGetByScopeResponse, error)`
info	[Changelog] - New function `*SettingsClient.List(context.Context, string, *SettingsClientListOptions) (SettingsClientListResponse, error)`
info	[Changelog] - New function `*TagInheritanceSetting.GetSetting() *Setting`
info	[Changelog] - New struct `AsyncOperationStatusProperties`
info	[Changelog] - New struct `BenefitUtilizationSummariesOperationStatus`
info	[Changelog] - New struct `BenefitUtilizationSummariesRequest`
info	[Changelog] - New struct `Budget`
info	[Changelog] - New struct `BudgetComparisonExpression`
info	[Changelog] - New struct `BudgetFilter`
info	[Changelog] - New struct `BudgetFilterProperties`
info	[Changelog] - New struct `BudgetProperties`
info	[Changelog] - New struct `BudgetTimePeriod`
info	[Changelog] - New struct `BudgetsListResult`
info	[Changelog] - New struct `CostAllocationProportion`
info	[Changelog] - New struct `CostAllocationRuleCheckNameAvailabilityRequest`
info	[Changelog] - New struct `CostAllocationRuleCheckNameAvailabilityResponse`
info	[Changelog] - New struct `CostAllocationRuleDefinition`
info	[Changelog] - New struct `CostAllocationRuleDetails`
info	[Changelog] - New struct `CostAllocationRuleList`
info	[Changelog] - New struct `CostAllocationRuleProperties`
info	[Changelog] - New struct `CurrentSpend`
info	[Changelog] - New struct `ForecastSpend`
info	[Changelog] - New struct `Notification`
info	[Changelog] - New struct `SettingsListResult`
info	[Changelog] - New struct `SourceCostAllocationResource`
info	[Changelog] - New struct `SystemAssignedServiceIdentity`
info	[Changelog] - New struct `TagInheritanceProperties`
info	[Changelog] - New struct `TagInheritanceSetting`
info	[Changelog] - New struct `TargetCostAllocationResource`
info	[Changelog] - New field `Identity`, `Location` in struct `Export`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 162 additive change(s).

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from d53d0d9. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-costmanagement [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group BudgetsOperations
info	[Changelog]   - Added operation group CostAllocationRulesOperations
info	[Changelog]   - Added operation group GenerateBenefitUtilizationSummariesReportOperations
info	[Changelog]   - Added operation group SettingsOperations
info	[Changelog]   - Model Export has a new parameter identity
info	[Changelog]   - Model Export has a new parameter location

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from d53d0d9. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️cost-management [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from d53d0d9. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

⚠️Az.cost-management.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.cost-management.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-15T03:01:01Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/costmanagement/armcostmanagement	https://apiview.dev/Assemblies/Review/f28291b847e4480394d7c68d839010f8

openapi-workflow-bot · 2023-08-15T03:07:45Z

Hi @thramu! The automation detected this pull request introduces changes to at least one existing API version that violate Azure's versioning policy. To comply with the policy, these changes must be made in a new API version. As a result, the automation added the NewApiVersionRequired label.

You cannot proceed with merging this PR until you complete one of the following action items:

ACTION ITEM ALTERNATIVE A: Introduce a new API version.
Submit a new PR instead of this one, or modify this PR, so that it adds a new API version instead of introducing changes to existing API versions.

ACTION ITEM ALTERNATIVE B: Request approval.
Alternatively, if you cannot avoid modifying existing API versions, then you can request an approval for them. Please follow the breaking changes process.
This case applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.

openapi-workflow-bot · 2023-08-15T03:07:45Z

Hi @thramu, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval.

openapi-workflow-bot · 2023-08-15T03:07:46Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

openapi-pipeline-app · 2023-08-15T23:44:00Z

Next Steps to Merge

⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-workflow-bot · 2023-08-15T23:50:04Z

Hi @thramu! Your PR has some issues. Please fix the CI issues, if present, in following order: Avocado, SemanticValidation, ModelValidation, Breaking Change, LintDiff.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic Validation	Fix-SemanticValidation-Error	High
Model Validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	High

If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel.

openapi-pipeline-app · 2023-08-15T23:50:09Z

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

openapi-pipeline-app · 2023-08-15T23:57:36Z

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

openapi-pipeline-app · 2023-08-17T18:16:25Z

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

TimLovellSmith · 2023-08-18T03:27:47Z

[ARMGuidelineFalsePositive]

We get

⚠️ EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.Location: Microsoft.CostManagement/stable/2023-08-01/costallocation.json#L324

for the check name availability response, but I consider that a false positive, because its following the guidance from the RPC.

   "nameAvailable": {
      "type": "boolean",
      "description": "Whether this rule name is available"
    }

openapi-pipeline-app · 2023-08-18T18:00:09Z

Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

...on/cost-management/resource-manager/Microsoft.CostManagement/stable/2023-08-01/settings.json

specification/cost-management/resource-manager/readme.md

TimLovellSmith · 2023-08-19T00:33:57Z

Basically looks good to me, minor feedbacks, I don't think they're truly blocking.

specification/cost-management/resource-manager/readme.md

thramu · 2023-08-21T17:58:03Z

/pr RequestMerge

openapi-pipeline-app · 2023-08-22T03:14:00Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

Adding cost allocation api to 2023-08-01 api version

b78f8e0

openapi-assignment-bot bot assigned rkmanda Aug 15, 2023

thramu requested a review from alprosms August 15, 2023 03:01

azure-sdk mentioned this pull request Aug 15, 2023

[AutoPR sdk/resourcemanager/costmanagement/armcostmanagement] [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2023-08-01 azure-sdk/azure-sdk-for-go#6866

Closed

alprosms approved these changes Aug 15, 2023

View reviewed changes

Adding Settings API

2bc089c

azure-sdk mentioned this pull request Aug 15, 2023

[AutoPR cost-management/resource-manager] [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2023-08-01 azure-sdk/azure-resource-manager-schemas#3066

Draft

MISC

af4f8d1

AzureRestAPISpecReview added the CI-FixRequiredOnFailure label Aug 15, 2023

Error Fix

5a24bef

AzureRestAPISpecReview removed the CI-FixRequiredOnFailure label Aug 16, 2023

mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 16, 2023

rkmanda removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 16, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 16, 2023

Updating the proxy resource references from common-types

2107af7

LintDiff warnings Fix

adf2e88

TimLovellSmith reviewed Aug 19, 2023

View reviewed changes

...on/cost-management/resource-manager/Microsoft.CostManagement/stable/2023-08-01/settings.json Show resolved Hide resolved

TimLovellSmith reviewed Aug 19, 2023

View reviewed changes

...on/cost-management/resource-manager/Microsoft.CostManagement/stable/2023-08-01/settings.json Show resolved Hide resolved

TimLovellSmith reviewed Aug 19, 2023

View reviewed changes

specification/cost-management/resource-manager/readme.md Show resolved Hide resolved

TimLovellSmith reviewed Aug 19, 2023

View reviewed changes

specification/cost-management/resource-manager/readme.md Show resolved Hide resolved

TimLovellSmith added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 19, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 19, 2023

github-actions bot added the MergeRequested label Aug 21, 2023

ms-henglu added the Approved-Suppression label Aug 22, 2023

ms-henglu approved these changes Aug 22, 2023

View reviewed changes

ms-henglu merged commit d53d0d9 into main Aug 22, 2023

ms-henglu deleted the thramu-cost-management-Microsoft.CostManagement-2023-08-01-new branch August 22, 2023 03:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2023-08-01 #25305

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2023-08-01 #25305

thramu commented Aug 15, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 15, 2023 •

edited

Loading

openapi-workflow-bot bot commented Aug 15, 2023

openapi-pipeline-app bot commented Aug 15, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 15, 2023 •

edited

Loading

openapi-workflow-bot bot commented Aug 15, 2023

openapi-workflow-bot bot commented Aug 15, 2023

openapi-workflow-bot bot commented Aug 15, 2023

openapi-pipeline-app bot commented Aug 15, 2023 •

edited

Loading

openapi-workflow-bot bot commented Aug 15, 2023

openapi-pipeline-app bot commented Aug 15, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 15, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 17, 2023 •

edited

Loading

TimLovellSmith commented Aug 18, 2023

openapi-pipeline-app bot commented Aug 18, 2023

TimLovellSmith commented Aug 19, 2023 •

edited

Loading

thramu commented Aug 21, 2023

openapi-pipeline-app bot commented Aug 22, 2023

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2023-08-01 #25305

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2023-08-01 #25305

Conversation

thramu commented Aug 15, 2023 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Getting help

openapi-pipeline-app bot commented Aug 15, 2023 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Aug 15, 2023

openapi-pipeline-app bot commented Aug 15, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 15, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Aug 15, 2023

openapi-workflow-bot bot commented Aug 15, 2023

openapi-workflow-bot bot commented Aug 15, 2023

openapi-pipeline-app bot commented Aug 15, 2023 • edited Loading

Next Steps to Merge

openapi-workflow-bot bot commented Aug 15, 2023

openapi-pipeline-app bot commented Aug 15, 2023 • edited Loading

openapi-pipeline-app bot commented Aug 15, 2023 • edited Loading

openapi-pipeline-app bot commented Aug 17, 2023 • edited Loading

TimLovellSmith commented Aug 18, 2023

openapi-pipeline-app bot commented Aug 18, 2023

TimLovellSmith commented Aug 19, 2023 • edited Loading

thramu commented Aug 21, 2023

openapi-pipeline-app bot commented Aug 22, 2023

thramu commented Aug 15, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 15, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 15, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 15, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 15, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 15, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 15, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 17, 2023 •

edited

Loading

TimLovellSmith commented Aug 19, 2023 •

edited

Loading