Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IpAllocationDelete.json to fix the Linter Error #25201

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

ZhangYi19941217
Copy link
Contributor

@ZhangYi19941217 ZhangYi19941217 commented Aug 7, 2023

Update IpAllocationDelete.json to fix the Linter Error ( LRO_RESPONSE_HEADER ) for Microsoft.Network: https://openapihub.azure-devex-tools.com/amekpis/linting/detail?errorId=1A6E673F-4276-41D9-B7A8-606727991FCA

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] public repo review queue, private repo review queue
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Getting help

Update IpAllocationDelete.json to fix the Linter Error
@openapi-workflow-bot
Copy link

Hi, @ZhangYi19941217! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
  • @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 7, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    ️️✔️Automated merging requirements met succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 7, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking



    azure-sdk-for-python-track2 - track2_azure-mgmt-network - Approved - 24.0.0
    +	Removed operation group NspLinkReconcileOperations
    +	Removed operation group NspLinkReferenceReconcileOperations
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 150f517. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.Network [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.FirewallPolicyRuleCollectionGroupData Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.FirewallPolicyRuleCollectionGroupData(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.ETag>, System.Nullable<System.Int32>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.FirewallPolicyRuleCollectionInfo>, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.SubnetData Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.SubnetData(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.ETag>, System.String, System.Collections.Generic.IEnumerable<System.String>, Azure.ResourceManager.Network.NetworkSecurityGroupData, Azure.ResourceManager.Network.RouteTableData, Azure.Core.ResourceIdentifier, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ServiceEndpointProperties>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.ServiceEndpointPolicyData>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.PrivateEndpointData>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.NetworkIPConfiguration>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.NetworkIPConfigurationProfile>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Resources.Models.WritableSubResource>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ResourceNavigationLink>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ServiceAssociationLink>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ServiceDelegation>, System.String, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>, System.Nullable<Azure.ResourceManager.Network.Models.VirtualNetworkPrivateEndpointNetworkPolicy>, System.Nullable<Azure.ResourceManager.Network.Models.VirtualNetworkPrivateLinkServiceNetworkPolicy>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.ApplicationGatewayIPConfiguration>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.VirtualNetworkGatewayData Azure.ResourceManager.Network.Models.ArmNetworkModelFactory.VirtualNetworkGatewayData(Azure.Core.ResourceIdentifier, System.String, System.Nullable<Azure.Core.ResourceType>, System.Nullable<Azure.Core.AzureLocation>, System.Collections.Generic.IDictionary<System.String, System.String>, Azure.ResourceManager.Resources.Models.ExtendedLocation, System.Nullable<Azure.ETag>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.VirtualNetworkGatewayIPConfiguration>, System.Nullable<Azure.ResourceManager.Network.Models.VirtualNetworkGatewayType>, System.Nullable<Azure.ResourceManager.Network.Models.VpnType>, System.Nullable<Azure.ResourceManager.Network.Models.VpnGatewayGeneration>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, Azure.Core.ResourceIdentifier, Azure.ResourceManager.Network.Models.VirtualNetworkGatewaySku, Azure.ResourceManager.Network.Models.VpnClientConfiguration, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.Models.VirtualNetworkGatewayPolicyGroup>, Azure.ResourceManager.Network.Models.BgpSettings, System.Collections.Generic.IEnumerable<System.String>, System.Nullable<System.Guid>, System.Nullable<Azure.ResourceManager.Network.Models.NetworkProvisioningState>, System.Nullable<System.Boolean>, System.String, Azure.Core.ResourceIdentifier, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Network.VirtualNetworkGatewayNatRuleData>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<System.Boolean>, System.Nullable<Azure.ResourceManager.Network.Models.ExpressRouteGatewayAdminState>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Network/Debug/netstandard2.0/Azure.ResourceManager.Network.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 150f517. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-network [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 150f517. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/network/armnetwork [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `ApplicationGatewaySKUNameBasic` added to enum type `ApplicationGatewaySKUName`
      info	[Changelog] - New value `ApplicationGatewayTierBasic` added to enum type `ApplicationGatewayTier`
      info	[Changelog] - New enum type `SyncMode` with values `SyncModeAutomatic`, `SyncModeManual`
      info	[Changelog] - New function `*LoadBalancersClient.MigrateToIPBased(context.Context, string, string, *LoadBalancersClientMigrateToIPBasedOptions) (LoadBalancersClientMigrateToIPBasedResponse, error)`
      info	[Changelog] - New struct `BastionHostPropertiesFormatNetworkACLs`
      info	[Changelog] - New struct `IPRule`
      info	[Changelog] - New struct `MigrateLoadBalancerToIPBasedRequest`
      info	[Changelog] - New struct `MigratedPools`
      info	[Changelog] - New struct `VirtualNetworkGatewayAutoScaleBounds`
      info	[Changelog] - New struct `VirtualNetworkGatewayAutoScaleConfiguration`
      info	[Changelog] - New field `SyncMode` in struct `BackendAddressPoolPropertiesFormat`
      info	[Changelog] - New field `NetworkACLs`, `VirtualNetwork` in struct `BastionHostPropertiesFormat`
      info	[Changelog] - New field `Size` in struct `FirewallPolicyPropertiesFormat`
      info	[Changelog] - New field `Size` in struct `FirewallPolicyRuleCollectionGroupProperties`
      info	[Changelog] - New field `DefaultOutboundAccess` in struct `SubnetPropertiesFormat`
      info	[Changelog] - New field `AutoScaleConfiguration` in struct `VirtualNetworkGatewayPropertiesFormat`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 24 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 150f517. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-network [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation LoadBalancers.migrateToIpBased
      info	[Changelog]   - Added Interface BastionHostPropertiesFormatNetworkAcls
      info	[Changelog]   - Added Interface IPRule
      info	[Changelog]   - Added Interface LoadBalancersMigrateToIpBasedOptionalParams
      info	[Changelog]   - Added Interface MigratedPools
      info	[Changelog]   - Added Interface MigrateLoadBalancerToIpBasedRequest
      info	[Changelog]   - Added Interface VirtualNetworkGatewayAutoScaleBounds
      info	[Changelog]   - Added Interface VirtualNetworkGatewayAutoScaleConfiguration
      info	[Changelog]   - Added Type Alias LoadBalancersMigrateToIpBasedResponse
      info	[Changelog]   - Added Type Alias SyncMode
      info	[Changelog]   - Interface BackendAddressPool has a new optional parameter syncMode
      info	[Changelog]   - Interface BastionHost has a new optional parameter networkAcls
      info	[Changelog]   - Interface BastionHost has a new optional parameter virtualNetwork
      info	[Changelog]   - Interface FirewallPolicy has a new optional parameter size
      info	[Changelog]   - Interface FirewallPolicyRuleCollectionGroup has a new optional parameter size
      info	[Changelog]   - Interface Subnet has a new optional parameter defaultOutboundAccess
      info	[Changelog]   - Interface VirtualNetworkGateway has a new optional parameter autoScaleConfiguration
      info	[Changelog]   - Added Enum KnownSyncMode
      info	[Changelog]   - Enum KnownApplicationGatewaySkuName has a new value Basic
      info	[Changelog]   - Enum KnownApplicationGatewayTier has a new value Basic
    ️🔄 azure-resource-manager-schemas inProgress [Detail]
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 150f517. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ⚠️Az.network.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.network.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 7, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/network/armnetwork https://apiview.dev/Assemblies/Review/e4b6359df9664f33a132632b44571861
    Java azure-resourcemanager-network-generated https://apiview.dev/Assemblies/Review/6d70cf34bba74d10b823f7e428d5104c
    JavaScript @azure/arm-network https://apiview.dev/Assemblies/Review/0075b60f85f54b1a939b8ec9b327fb1c
    .Net Azure.ResourceManager.Network https://apiview.dev/Assemblies/Review/fba1ad676b9849fa9f4a8ae68c84ba5e

    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 7, 2023
    @ms-zhenhua ms-zhenhua added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 10, 2023
    @ZhangYi19941217
    Copy link
    Contributor Author

    /pr RequestMerge

    @openapi-pipeline-app
    Copy link

    Next Steps to Merge

    ⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

    ✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

    @ms-henglu ms-henglu merged commit 150f517 into main Aug 22, 2023
    @ms-henglu ms-henglu deleted the ZhangYi19941217-patch-1 branch August 22, 2023 03:09
    @openapi-pipeline-app
    Copy link

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review FixS360 ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants