Redact sensitive info #25159
Merged
Redact sensitive info #25159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
|
Hi, @jlichwa! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Generation Artifacts
|
|
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
heaths
approved these changes
Aug 3, 2023
konrad-jamrozik
pushed a commit
that referenced
this pull request
Aug 12, 2023
* Adds base for updating Microsoft.KeyVault from version stable/7.4 to version 7.5-preview.1 * Updates readme * Updates API version in new specs and examples * Adding New readonly property hsmPlatform to the Key Attributes (#23769) * Trustedmode backuprestore (#23780) * Trusted mode backup, restore, selective restore swagger specifications * Rename trusted mode to managed identity mode * Incorporate Heath's PR suggestions. * Description change * add enums * Incorporate heath's suggestion * reword description * rename * Redact sensitive info (#25159) * Fix example base64 encodings (#25273) --------- Co-authored-by: Heath Stewart <[email protected]> Co-authored-by: Kapil Jain (MSFT) <[email protected]> Co-authored-by: vasanthrajams <[email protected]> Co-authored-by: Heath Stewart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API - Pull Request
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links