-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aneeshakella/scalable gateway swagger changes #25107
Aneeshakella/scalable gateway swagger changes #25107
Conversation
Hi, @aneeshakella-microsoft! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
virtualNetworkGateway.json | 2023-05-01(499fc66) | 2023-04-01(main) |
️⚠️
LintDiff: 1 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.4) | new version | base version |
---|---|---|
package-2023-05 | package-2023-05(499fc66) | package-2023-05(release-network-Microsoft.Network-official-2023-05-01) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
Schema should have a description or title. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L2869 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
ResourceNameRestriction |
The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L37 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L91 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L191 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L200 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L252 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L264 |
ResourceNameRestriction |
The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L325 |
ResourceNameRestriction |
The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L378 |
ParametersInPost |
gatewayVip is a query parameter. Post operation must not contain any query parameter other than api-version. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L385 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L415 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L427 |
ResourceNameRestriction |
The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L442 |
LroPostReturn |
200 response for a LRO POST operation must have a response schema specified. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L443 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L475 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L481 |
ResourceNameRestriction |
The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L496 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L541 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L547 |
ResourceNameRestriction |
The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L562 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L607 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L613 |
ResourceNameRestriction |
The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L628 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L664 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L670 |
ResourceNameRestriction |
The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L685 |
ParametersInPost |
peer is a query parameter. Post operation must not contain any query parameter other than api-version. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L692 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L728 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L734 |
ResourceNameRestriction |
The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L749 |
ResourceNameRestriction |
The resource name parameter 'virtualNetworkGatewayName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-05-01/virtualNetworkGateway.json#L799 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Hi @aneeshakella-microsoft! Your PR has some issues. Please fix the CI issues, if present, in following order:
If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel. |
/pr RequestMerge |
af6f9b1
into
Azure:release-network-Microsoft.Network-official-2023-05-01
* Adds base for updating Microsoft.Network from version stable/2023-04-01 to version 2023-05-01 * Updates readme * Updates API version in new specs and examples * Aneeshakella/scalable gateway swagger changes (#25107) * Added additional scalable gateway changes * small formatting change * made documents prettier * prettier changes * added references to fix avocado * testing a fix * another test * added new test * new changes * removed update * new changes * updated specs * updated specs * [Public] Adding support for Developer Bastion (#25132) * Public Preview Developer Bastion * Public Preview Developer Bastion * Bastion Developer Sku * updated firewall policy and rcg object by adding size property to it (#25220) * Update Subnet property defaultOutboundAccess in swagger (#25181) * Subnet property defaultOutboundAccess added * NIT update * NIT Fix description --------- Co-authored-by: unknown <[email protected]> --------- Co-authored-by: aneeshakella-microsoft <[email protected]> Co-authored-by: anvrao1 <[email protected]> Co-authored-by: navya-ganta <[email protected]> Co-authored-by: anjbal <[email protected]> Co-authored-by: unknown <[email protected]>
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] public repo review queue, private repo review queue
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequested
is removed from your PR. This should cause the label
WaitForARMFeedback
to be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue
If you need further help with anything, see
Getting help
section below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.
ARM API changes review
ARMReview
label.ARMReview
label, if appropriate.If this happens, proceed according to guidance given in GitHub comments also added by the automation.
Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.
Getting help
and https://aka.ms/ci-fix.