-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.DelegatedNetwork to add version preview/2023-05-18-preview #25016
[Hub Generated] Review request for Microsoft.DelegatedNetwork to add version preview/2023-05-18-preview #25016
Conversation
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
common-types.json | 2023-06-27-preview(5cd43cf) | 2021-03-15(main) |
common-types.json | 2023-06-27-preview(5cd43cf) | 2023-05-18-preview(main) |
controller.json | 2023-06-27-preview(5cd43cf) | 2021-03-15(main) |
controller.json | 2023-06-27-preview(5cd43cf) | 2023-05-18-preview(main) |
delegatedSubnets.json | 2023-06-27-preview(5cd43cf) | 2021-03-15(main) |
delegatedSubnets.json | 2023-06-27-preview(5cd43cf) | 2023-05-18-preview(main) |
operations.json | 2023-06-27-preview(5cd43cf) | 2021-03-15(main) |
operations.json | 2023-06-27-preview(5cd43cf) | 2023-05-18-preview(main) |
orchestrators.json | 2023-06-27-preview(5cd43cf) | 2021-03-15(main) |
orchestrators.json | 2023-06-27-preview(5cd43cf) | 2023-05-18-preview(main) |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.4) | new version | base version |
---|---|---|
package-2023-06-27-preview | package-2023-06-27-preview(5cd43cf) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
PutResponseSchemaDescription |
Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/controller.json#L112 |
PutResponseSchemaDescription |
Description of 201 response code of a PUT operation MUST include term 'create'. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/controller.json#L112 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/controller.json#L163 |
ProvisioningStateValidation |
ProvisioningState must have terminal states: Succeeded, Failed and Canceled. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/controller.json#L402 |
PutResponseSchemaDescription |
Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/delegatedSubnets.json#L115 |
PutResponseSchemaDescription |
Description of 201 response code of a PUT operation MUST include term 'create'. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/delegatedSubnets.json#L115 |
PatchResponseCode |
LRO PATCH must have 200 and 202 return codes. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/delegatedSubnets.json#L137 |
LroPatch202 |
The async patch operation should return 202. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/delegatedSubnets.json#L171 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/delegatedSubnets.json#L219 |
MissingTypeObject |
The schema 'ResourceUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/delegatedSubnets.json#L351 |
ProvisioningStateValidation |
ProvisioningState must have terminal states: Succeeded, Failed and Canceled. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/delegatedSubnets.json#L409 |
PutResponseSchemaDescription |
Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/orchestrators.json#L112 |
PutResponseSchemaDescription |
Description of 201 response code of a PUT operation MUST include term 'create'. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/orchestrators.json#L112 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/orchestrators.json#L166 |
PatchIdentityProperty |
The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/orchestrators.json#L205 |
MissingTypeObject |
The schema 'OrchestratorResourceUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/orchestrators.json#L365 |
ProvisioningStateValidation |
ProvisioningState must have terminal states: Succeeded, Failed and Canceled. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/orchestrators.json#L422 |
MissingTypeObject |
The schema 'OrchestratorIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/orchestrators.json#L466 |
The response of operation:'Controller_GetDetails' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/controller.json#L38 |
|
The response of operation:'Controller_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/controller.json#L78 |
|
The response of operation:'Controller_Patch' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/controller.json#L178 |
|
'PATCH' operation 'Controller_Patch' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/controller.json#L188 |
|
Property location must have 'x-ms-mutability':['read', 'create'] extension defined.Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/controller.json#L330 |
|
The response of operation:'DelegatedSubnetService_GetDetails' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/delegatedSubnets.json#L38 |
|
The response of operation:'DelegatedSubnetService_PutDetails' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/delegatedSubnets.json#L78 |
|
'PUT' operation 'DelegatedSubnetService_PutDetails' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/delegatedSubnets.json#L91 |
|
The response of operation:'DelegatedSubnetService_PatchDetails' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/delegatedSubnets.json#L137 |
|
'PATCH' operation 'DelegatedSubnetService_PatchDetails' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/delegatedSubnets.json#L147 |
|
Property location must have 'x-ms-mutability':['read', 'create'] extension defined.Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/delegatedSubnets.json#L337 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DelegatedNetwork/preview/2023-06-27-preview/delegatedSubnets.json#L464 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Hi, @isaac-dasan! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Generation Artifacts
|
Generated ApiView
|
...resource-manager/Microsoft.DelegatedNetwork/preview/2023-06-27-preview/delegatedSubnets.json
Outdated
Show resolved
Hide resolved
Hi @isaac-dasan! Your PR has some issues. Please fix the CI issues, if present, in following order:
If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel. |
...resource-manager/Microsoft.DelegatedNetwork/preview/2023-06-27-preview/delegatedSubnets.json
Outdated
Show resolved
Hide resolved
…023-05-18-preview-4
Next Steps to Merge |
/pr RequestMerge |
/azp run |
Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
Azure Pipelines successfully started running 2 pipeline(s). |
waiting for required checks to pass |
/azp run |
Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
Azure Pipelines successfully started running 2 pipeline(s). |
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.
ARM API changes review
ARMReview
label.ARMReview
label, if appropriate.If this happens, proceed according to guidance given in GitHub comments also added by the automation.
Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.
Getting help
and https://aka.ms/ci-fix.