Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug-Fix] Minor change in Managed Network Fabric #24948

Merged
merged 2 commits into from
Aug 1, 2023
Merged

[Bug-Fix] Minor change in Managed Network Fabric #24948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
743eade
Changes Made:
Mohana-Krishna-Nali Jul 24, 2023
7ba1a4e
Reverting the changes made for "type" parameter.
Mohana-Krishna-Nali Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions ...resource-manager/Microsoft.ManagedNetworkFabric/stable/2023-06-15/AccessControlLists.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,6 +645,12 @@
"format": "uri",
"minLength": 1
},
"defaultAction": {
"type": "string",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string

If the set of values are pre-defined, make it an enum?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have referred Enum, CommunityActionTypes

"description": "Default action that needs to be applied when no condition is matched. Example: Permit | Deny.",
"default": "Permit",
"$ref": "./common.json#/definitions/CommunityActionTypes"
},
"matchConfigurations": {
"type": "array",
"description": "List of match configurations.",
Expand Down Expand Up @@ -717,7 +723,7 @@
"description": "List of actions that need to be performed for the matched conditions.",
"minItems": 1,
"items": {
"description": "Action that need to performed.",
"description": "Action that need to be performed.",
"$ref": "#/definitions/AccessControlListAction"
}
}
Expand All @@ -730,7 +736,7 @@
"etherTypes": {
"type": "array",
"minItems": 1,
"description": "List of ether type values that needs to be matched.",
"description": "List of ether type values that need to be matched.",
"items": {
"type": "string",
"minLength": 1,
Expand All @@ -740,7 +746,7 @@
"fragments": {
"type": "array",
"minItems": 1,
"description": "List of IP fragment packets that needs to be matched.",
"description": "List of IP fragment packets that need to be matched.",
"items": {
"type": "string",
"minLength": 1,
Expand All @@ -750,7 +756,7 @@
"ipLengths": {
"type": "array",
"minItems": 1,
"description": "List of IP Lengths that needs to be matched.",
"description": "List of IP Lengths that need to be matched.",
"items": {
"type": "string",
"minLength": 1,
Expand All @@ -760,7 +766,7 @@
"ttlValues": {
"type": "array",
"minItems": 1,
"description": "List of TTL [Time To Live] values that needs to be matched.",
"description": "List of TTL [Time To Live] values that need to be matched.",
"items": {
"type": "string",
"minLength": 1,
Expand All @@ -770,7 +776,7 @@
"dscpMarkings": {
"type": "array",
"minItems": 1,
"description": "List of DSCP Markings that needs to be matched.",
"description": "List of DSCP Markings that need to be matched.",
"items": {
"type": "string",
"minLength": 1,
Expand All @@ -794,7 +800,7 @@
"properties": {
"flags": {
"type": "array",
"description": "List of protocol flags that needs to be matched.",
"description": "List of protocol flags that need to be matched.",
"items": {
"type": "string",
"description": "Flag of the port."
Expand Down
4 changes: 2 additions & 2 deletions ...ic/resource-manager/Microsoft.ManagedNetworkFabric/stable/2023-06-15/NetworkTapRules.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,7 @@
"description": "List of actions that need to be performed for the matched conditions.",
"minItems": 1,
"items": {
"description": "Action that need to performed.",
"description": "Action that needs to performed.",
"$ref": "#/definitions/NetworkTapRuleAction"
}
}
Expand All @@ -748,7 +748,7 @@
"properties": {
"encapsulationType": {
"type": "string",
"description": "Encapsulation Type.",
"description": "Encapsulation Type that needs to be matched.",
"default": "None",
"minLength": 1,
"enum": [
Expand Down
6 changes: 6 additions & 0 deletions ...bric/resource-manager/Microsoft.ManagedNetworkFabric/stable/2023-06-15/RoutePolicies.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,12 @@
"type": "object",
"description": "Route Policy patchable properties.",
"properties": {
"defaultAction": {
"type": "string",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string

If the set of values are pre-defined, make it an enum?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have referred Enum, CommunityActionTypes

"description": "Default action that needs to be applied when no condition is matched. Example: Permit | Deny.",
"default": "Deny",
"$ref": "./common.json#/definitions/CommunityActionTypes"
},
"statements": {
"type": "array",
"description": "Route Policy statements.",
Expand Down
20 changes: 10 additions & 10 deletions ...tworkfabric/resource-manager/Microsoft.ManagedNetworkFabric/stable/2023-06-15/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@
},
"portGroupNames": {
"type": "array",
"description": "List of the port Group Names that to be matched.",
"description": "List of the port Group Names that need to be matched.",
"minItems": 1,
"items": {
"type": "string",
Expand All @@ -512,11 +512,11 @@
},
"VlanMatchCondition": {
"type": "object",
"description": "The vlan match conditions that needs to be matched.",
"description": "The vlan match conditions that need to be matched.",
"properties": {
"vlans": {
"type": "array",
"description": "List of vlans that needs to be matched.",
"description": "List of vlans that need to be matched.",
"minItems": 1,
"items": {
"type": "string",
Expand All @@ -527,7 +527,7 @@
},
"innerVlans": {
"type": "array",
"description": "List of inner vlans that needs to be matched.",
"description": "List of inner vlans that need to be matched.",
"minItems": 1,
"items": {
"type": "string",
Expand All @@ -538,7 +538,7 @@
},
"vlanGroupNames": {
"type": "array",
"description": "List of vlan group names that to be matched.",
"description": "List of vlan group names that need to be matched.",
"minItems": 1,
"items": {
"type": "string",
Expand All @@ -554,7 +554,7 @@
"properties": {
"type": {
"type": "string",
"description": "IP Address type.",
"description": "IP Address type that needs to be matched.",
"minLength": 1,
"enum": [
"SourceIP",
Expand All @@ -567,7 +567,7 @@
},
"prefixType": {
"type": "string",
"description": "IP Prefix Type.",
"description": "IP Prefix Type that needs to be matched.",
"minLength": 1,
"enum": [
"Prefix",
Expand All @@ -580,7 +580,7 @@
},
"ipPrefixValues": {
"type": "array",
"description": "The list of IP Prefixes.",
"description": "The list of IP Prefixes that need to be matched.",
"minItems": 1,
"items": {
"type": "string",
Expand Down Expand Up @@ -624,7 +624,7 @@
},
"portGroups": {
"type": "array",
"description": "List of the port group.",
"description": "List of the port groups.",
"minItems": 1,
"items": {
"description": "Port Group",
Expand Down Expand Up @@ -691,7 +691,7 @@
},
"ports": {
"type": "array",
"description": "List of the ports that needs to be matched.",
"description": "List of the ports that need to be matched.",
"minItems": 1,
"items": {
"type": "string",
Expand Down
3 changes: 3 additions & 0 deletions ...gedNetworkFabric/stable/2023-06-15/examples/AccessControlLists_Create_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"annotation": "annotation",
"configurationType": "File",
"aclsUrl": "https://ACL-Storage-URL",
"defaultAction": "Permit",
"matchConfigurations": [
{
"matchConfigurationName": "example-match",
Expand Down Expand Up @@ -125,6 +126,7 @@
"annotation": "annotation",
"configurationType": "File",
"aclsUrl": "https://ACL-Storage-URL",
"defaultAction": "Permit",
"matchConfigurations": [
{
"matchConfigurationName": "example-match",
Expand Down Expand Up @@ -254,6 +256,7 @@
"annotation": "annotation",
"configurationType": "File",
"aclsUrl": "https://ACL-Storage-URL",
"defaultAction": "Permit",
"matchConfigurations": [
{
"matchConfigurationName": "example-match",
Expand Down
1 change: 1 addition & 0 deletions ...anagedNetworkFabric/stable/2023-06-15/examples/AccessControlLists_Get_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"annotation": "annotation",
"configurationType": "File",
"aclsUrl": "https://ACL-Storage-URL",
"defaultAction": "Permit",
"matchConfigurations": [
{
"matchConfigurationName": "example-match",
Expand Down
1 change: 1 addition & 0 deletions ...ric/stable/2023-06-15/examples/AccessControlLists_ListByResourceGroup_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"annotation": "annotation",
"configurationType": "File",
"aclsUrl": "https://ACL-Storage-URL",
"defaultAction": "Permit",
"matchConfigurations": [
{
"matchConfigurationName": "example-match",
Expand Down
1 change: 1 addition & 0 deletions ...bric/stable/2023-06-15/examples/AccessControlLists_ListBySubscription_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"annotation": "annotation",
"configurationType": "File",
"aclsUrl": "https://ACL-Storage-URL",
"defaultAction": "Permit",
"matchConfigurations": [
{
"matchConfigurationName": "example-match",
Expand Down
2 changes: 2 additions & 0 deletions ...gedNetworkFabric/stable/2023-06-15/examples/AccessControlLists_Update_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"properties": {
"configurationType": "File",
"aclsUrl": "https://microsoft.com/a",
"defaultAction": "Permit",
"matchConfigurations": [
{
"matchConfigurationName": "example-match",
Expand Down Expand Up @@ -124,6 +125,7 @@
"annotation": "annotation",
"configurationType": "File",
"aclsUrl": "https://ACL-Storage-URL",
"defaultAction": "Permit",
"matchConfigurations": [
{
"matchConfigurationName": "example-match",
Expand Down
3 changes: 3 additions & 0 deletions ....ManagedNetworkFabric/stable/2023-06-15/examples/RoutePolicies_Create_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"networkFabricId": "/subscriptions/1234ABCD-0A1B-1234-5678-123456ABCDEF/resourceGroups/example-rg/providers/Microsoft.ManagedNetworkFabric/networkFabrics/example-fabric",
"addressFamilyType": "IPv4",
"annotation": "annotation",
"defaultAction": "Deny",
"statements": [
{
"sequenceNumber": 7,
Expand Down Expand Up @@ -80,6 +81,7 @@
"provisioningState": "Accepted",
"administrativeState": "Enabled",
"annotation": "annotation",
"defaultAction": "Deny",
"statements": [
{
"sequenceNumber": 7,
Expand Down Expand Up @@ -164,6 +166,7 @@
"provisioningState": "Accepted",
"administrativeState": "Enabled",
"annotation": "annotation",
"defaultAction": "Deny",
"statements": [
{
"sequenceNumber": 7,
Expand Down
1 change: 1 addition & 0 deletions ...oft.ManagedNetworkFabric/stable/2023-06-15/examples/RoutePolicies_Get_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"provisioningState": "Accepted",
"administrativeState": "Enabled",
"annotation": "annotation",
"defaultAction": "Deny",
"statements": [
{
"sequenceNumber": 7,
Expand Down
1 change: 1 addition & 0 deletions ...rkFabric/stable/2023-06-15/examples/RoutePolicies_ListByResourceGroup_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"provisioningState": "Accepted",
"administrativeState": "Enabled",
"annotation": "annotation",
"defaultAction": "Deny",
"statements": [
{
"sequenceNumber": 7,
Expand Down
1 change: 1 addition & 0 deletions ...orkFabric/stable/2023-06-15/examples/RoutePolicies_ListBySubscription_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"provisioningState": "Accepted",
"administrativeState": "Enabled",
"annotation": "annotation",
"defaultAction": "Deny",
"statements": [
{
"sequenceNumber": 7,
Expand Down
2 changes: 2 additions & 0 deletions ....ManagedNetworkFabric/stable/2023-06-15/examples/RoutePolicies_Update_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"routePolicyName": "example-routePolicy",
"body": {
"properties": {
"defaultAction": "Deny",
"statements": [
{
"sequenceNumber": 7,
Expand Down Expand Up @@ -76,6 +77,7 @@
"provisioningState": "Accepted",
"administrativeState": "Enabled",
"annotation": "annotation",
"defaultAction": "Deny",
"statements": [
{
"sequenceNumber": 7,
Expand Down