Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable creation of perimeter base rule #24945

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Disable creation of perimeter base rule #24945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8559ede
Disable creation of perimeter base rule
vineetmimrot Jul 24, 2023
5d9cd2e
Merge branch 'main' into vimimrot/Delete-Perimeter-Rule-Creation
vineetmimrot Jul 24, 2023
8169ec7
Made NSP rule readonly
vineetmimrot Jul 24, 2023
06a7047
Added email/sms rule changes
vineetmimrot Jul 24, 2023
a29f0de
Minor fix
vineetmimrot Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions ...ource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReconcile.json
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions ...ager/Microsoft.Network/preview/2021-02-01-preview/examples/NspLinkReferenceReconcile.json
View file
Open in desktop

This file was deleted.

88 changes: 3 additions & 85 deletions ...source-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,48 +1081,6 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/links/{linkName}/reconcile": {
vineetmimrot marked this conversation as resolved.
Show resolved Hide resolved
"parameters": [
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "#/parameters/NetworkSecurityPerimeterNameParameter"
},
{
"$ref": "#/parameters/LinkNameParameter"
},
{
"$ref": "./network.json#/parameters/ApiVersionParameter"
}
],
"post": {
"tags": [
"NspLinkReconcile"
],
"operationId": "NspLinkReconcile_Post",
"description": "Reconcile NSP link resource.",
"responses": {
"200": {
"description": "OK"
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "./network.json#/definitions/CloudError"
}
}
},
"x-ms-examples": {
"NspLinkReconcile": {
"$ref": "./examples/NspLinkReconcile.json"
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/linkReferences/{linkReferenceName}": {
"parameters": [
{
Expand Down Expand Up @@ -1257,48 +1215,6 @@
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkSecurityPerimeters/{networkSecurityPerimeterName}/linkReferences/{linkReferenceName}/reconcile": {
"parameters": [
vineetmimrot marked this conversation as resolved.
Show resolved Hide resolved
{
"$ref": "./network.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/ResourceGroupNameParameter"
},
{
"$ref": "#/parameters/NetworkSecurityPerimeterNameParameter"
},
{
"$ref": "#/parameters/LinkReferenceNameParameter"
},
{
"$ref": "./network.json#/parameters/ApiVersionParameter"
}
],
"post": {
"tags": [
"NspLinkReferenceReconcile"
],
"operationId": "NspLinkReferenceReconcile_Post",
"description": "Reconcile NSP linkReference resource.",
"responses": {
"200": {
"description": "OK"
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "./network.json#/definitions/CloudError"
}
}
},
"x-ms-examples": {
"NspLinkReferenceReconcile": {
"$ref": "./examples/NspLinkReferenceReconcile.json"
}
}
}
}
},
"definitions": {
Expand Down Expand Up @@ -1522,12 +1438,13 @@
"description": "List of subscription ids"
},
"networkSecurityPerimeters": {
"readOnly": true,
"type": "array",
"items": {
"x-ms-client-flatten": true,
"$ref": "#/definitions/PerimeterBasedAccessRule"
},
"description": "Inbound rule specified by the perimeter id."
"description": "Rule specified by the perimeter id."
},
"emailAddresses": {
"type": "array",
Expand Down Expand Up @@ -1559,6 +1476,7 @@
"type": "object",
"properties": {
"id": {
"readOnly": true,
"type": "string",
"description": "NSP id in the ARM id format."
},
Expand Down