Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update code owner #24754

Merged
merged 1 commit into from
Jul 11, 2023
Merged

update code owner #24754

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -263,5 +263,5 @@
/specification/**/resource-manager/**/readme.typescript.md @qiaozha
/specification/**/resource-manager/**/readme.az.md @jsntcy @qiaozha
/specification/**/resource-manager/**/readme.cli.md @jsntcy @qiaozha
/specification/**/resource-manager/**/readme.go.md @ArcturusZhang
/specification/**/resource-manager/**/readme.python.md @msyyc @Wzb123456789
/specification/**/resource-manager/**/readme.go.md @tadelesh
/specification/**/resource-manager/**/readme.python.md @msyyc
Copy link
Member

@raych1 raych1 Jul 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArcturusZhang @weidongxu-microsoft , do you know if dotnet and java need the review on corresponding readme?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java does not review readme.java.md

Java automation basically override all options there.

If SDK dev need to add option, we will review it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DotNet does not need to review readme file. All dotnet related information is in the autorest.md in azure-sdk-for-net repo
I do not know Java.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weidongxu-microsoft if this is the case do we really need a readme.java.md file at all?

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft Jul 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weshaggard
Java still have a few things to configure, e.g. https://github.com/Azure/azure-rest-api-specs/blob/main/specification/managednetworkfabric/resource-manager/readme.java.md
or #24781

Maybe the file will include a few more directives, if swagger having problem (model with duplicate name, breaking changes that can be mitigated, etc.). So it may get longer than the sample above.

I am fine about either having readme.java.md, or get rid of it and put these java configure to readme.md. At present, we generally follow the convention of putting java specific configure in readme.java.md

What I mean is that 99% of the case, the meaningful change to readme.java.md is done by SDK dev.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I think what Ray is trying to do here is more around how to get the SDK generation owners reviewing the PRs for any SDK related impact not just the readme configuration necessarily. The readme is just an easy way to help identify PRs and assign reviewers, but it isn't a full solution to reviewing the spec PRs from and SDK generation perspective.