Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the swagger to reconcile SDK generation #24669

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
83c5f65
Unified Vision API: Remove AdultResult (#23863)
shonohs Jun 20, 2023
6af0ff9
Add SQL VA new API to package-composite-v5 (#24389)
GalGoldi72 Jun 20, 2023
fe05696
[OpenAI.Inference] Adding typespec definitions for DALL-E (#24382)
glecaros Jun 20, 2023
ca95eb5
Update tspconfig.yaml (#24433)
raych1 Jun 20, 2023
fba7ffa
[Hub Generated] Review request for Microsoft.AlertsManagement to add …
noneumar Jun 20, 2023
eae8ca2
[Go] sql readme.go.md add directive (#24510)
Alancere Jun 20, 2023
9b52364
Add view parameter, remove adminDistrict type (#24452)
gigigoo0 Jun 20, 2023
e5d8bf3
Simplify PR GH ARM comment template `control_plane_template.md`; simp…
Jun 20, 2023
2b1d333
New version 2023-05-01 for RP Microsoft.Consumption (#23958)
pednekarpraj Jun 21, 2023
e0ec410
Fixing additional Properties (#24480)
moadus Jun 21, 2023
90189a4
Salambashir/addDFSv2Swagger (#24289)
salambashir Jun 21, 2023
526e604
[Hub Generated] Review request for Microsoft.Authorization to add ver…
veseshad92 Jun 21, 2023
237753f
[Hub Generated] Publish private branch 'feature/CloudHsm_updates' (#2…
emmeliaAra Jun 21, 2023
f5b74b0
Removing the Anonymous types in public-preview version (#24515)
Mohana-Krishna-Nali Jun 21, 2023
453fb04
update typescript.md (#24354)
kazrael2119 Jun 21, 2023
a72e896
update putDeployment example (#24486)
tianxin-ms Jun 21, 2023
c7f3e60
rename (#24531)
Alancere Jun 21, 2023
9aec843
Fixing enum to have the proper values + reenabling csharp generation.…
glecaros Jun 21, 2023
8ded9fa
remove getSipConfiguration example and update description (#24533)
dzeliar Jun 22, 2023
221677f
Renaming 'credential' property to 'credentials' (#24522)
JatinKhatri03 Jun 22, 2023
582af8c
Azure OpenAI: Make startGenerateImage LRO internal for clients (#24546)
trrwilson Jun 22, 2023
c7d8f2e
[Hub Generated] Review request for Microsoft.AgFoodPlatform to add ve…
ryuzakil Jun 23, 2023
d2a5b3d
Galkeinan/adding 2023 01 01 documentations (#24234)
galkeinan-microsoft Jun 23, 2023
af93fc3
[OpenAI.Inference] Remove unnecessary suppression (#24562)
mikeharder Jun 23, 2023
5b269e1
Removing unused state + Fixing enum + Adding versioning to DALL-E mod…
glecaros Jun 23, 2023
6f73e89
[CI] Add trigger for typespec-next (#24564)
mikeharder Jun 24, 2023
b0068e9
Revert "Revert "[Hub Generated] Publish private branch 'azure-kusto/d…
michaelshikh07 Jun 24, 2023
de93ae3
Update readme.python.md (#24504)
msyyc Jun 25, 2023
1d9003a
Release microsoft.api management 2023 03 01 preview (#23792)
solankisamir Jun 25, 2023
89e91a0
Update readme.java.md to make Resource.resourcegroup and subscriptio…
haolingdong-msft Jun 25, 2023
02acc29
update typescript.md in storagecache (#24527)
kazrael2119 Jun 26, 2023
34782dd
Swagger correctness fix (#24211)
kalyanachakravarthikarri-az Jun 26, 2023
1f9b94d
update trigger type enum - schedule for jobs (#24400)
anandanthony Jun 26, 2023
1f272d6
python config (#24567)
msyyc Jun 26, 2023
3fd46fc
update readme.typescript.md to make Resource.resourcegroup and subscr…
kazrael2119 Jun 26, 2023
a8cb7f0
[Hub Generated] Publish private branch 'ssivathas/2023-06-01' (#24528)
JeetendraJoshi-MSFT Jun 26, 2023
9a56be3
Fix of search new preview version (#24576)
galkeinan-microsoft Jun 26, 2023
a829c60
feat: add ulimits to custom-words.txt for container service preview A…
UtheMan Jun 26, 2023
d0ac260
[Hub Generated] Review request for Microsoft.DelegatedNetwork to add …
thomasricci Jun 26, 2023
ed1c652
[Hub Generated] Review request for Creator to add version stable/2023…
tejitpabari99 Jun 26, 2023
baab681
Re-enabling Java checks for Azure OpenAI (#24541)
jpalvarezl Jun 26, 2023
4549bfd
Add SQL VA Database to package-composite-v5 (#24506)
GalGoldi72 Jun 27, 2023
b67eccd
Update `pull_request_assignment.yml`: remove `armapireview` and other…
Jun 27, 2023
686983b
mgmt, managednetworkfabric, update java option (#24569)
weidongxu-microsoft Jun 27, 2023
94e9ea5
Update readme.python.md (#24601)
Wzb123456789 Jun 27, 2023
d8fbbdf
Update pull_request_assignment.yml (#24602)
raych1 Jun 27, 2023
4b74815
readme.java.md (#24573)
XiaofeiCao Jun 27, 2023
1816b61
[ManagedCcf] Remove import of typespec-autorest (#24599)
mikeharder Jun 27, 2023
d0083f3
[Sphere.Management] Remove import of typespec-autorest (#24600)
mikeharder Jun 27, 2023
d03c196
Create readme.python.md (#24603)
msyyc Jun 27, 2023
bc32387
initial WIP Typespec E2E doc (#24343)
allenjzhang Jun 27, 2023
288b01a
[HealthInsights] Remove import of typespec-autorest (#24598)
mikeharder Jun 27, 2023
41a6298
[Hub Generated] Review request for Microsoft.MachineLearningServices …
erjms Jun 27, 2023
a862f4f
[TypeSpec] Add @azure-tools/typespec-validation tool
ckairen Jun 28, 2023
e7db720
Correctly mark AKS ManagedClusterServicePrincipalProfile.Secret as x-…
super-harsh Jun 28, 2023
237afa1
add directive to avoid breaking change (#24609)
kazrael2119 Jun 28, 2023
b1d41f8
[Compute] API Version 2023-01-02 (#24364)
haagha Jun 28, 2023
4aa4e84
Add managedResourcesPublicNetworkAccess property in 2021-12-01 API ve…
daminia-ms Jun 28, 2023
b133da4
Update workflow-bot comment and mention APIView (#24575)
Jun 28, 2023
4c49a05
Update readme.md for latest SDK release (#24618)
thomasricci Jun 29, 2023
45cea7e
[typespec-ci] Add pr trigger for eng/tools/TypeSpecValidation (#24640)
mikeharder Jun 29, 2023
db23874
Azure OpenAI: reuse LRO response model as status polling model (#24556)
trrwilson Jun 29, 2023
0504b27
[TypeSpecValidation/ Format document (#24642)
mikeharder Jun 29, 2023
f31a209
Typespec EGv2 Clean CI (#24361)
l0lawrence Jun 29, 2023
c810578
[typespec-ci] Discard git changes (#24650)
mikeharder Jun 29, 2023
64efc48
adding mutability flag to the identity property ACS (#24477)
joannajiang112628 Jun 30, 2023
d75abbd
Add new stable API-version 2023-05-01 in Microsoft.Dataprotection (#2…
Shashank1306s Jun 30, 2023
6107f25
update (#24655)
msyyc Jun 30, 2023
4ffdb08
[TypeSpecValidation] Enable simple-git logging (#24656)
mikeharder Jun 30, 2023
9383e81
Add multi-vector support to search requests (#24614)
Careyjmac Jun 30, 2023
ce93b56
update the swagger to more closely match the version that our SDK was…
ericasp16 Jun 30, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
68 changes: 30 additions & 38 deletions .github/PULL_REQUEST_TEMPLATE/control_plane_template.md
Original file line number Diff line number Diff line change
@@ -1,49 +1,41 @@
## ARM API Information (Control Plane)
# ARM (Control Plane) API Specification Update Pull Request

### Changelog
Add a changelog entry for this PR by answering the following questions:
1. What's the purpose of the update?
- [ ] new service onboarding
- [ ] new API version
- [ ] update existing version for new feature
- [ ] update existing version to fix swagger quality issue in s360
- [ ] Other, please clarify
2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
## Purpose of this PR

### Contribution checklist (MS Employees Only):
- [ ] I commit to follow the [Breaking Change Policy](https://aka.ms/AzBreakingChangesPolicy) of "no breaking changes"
- [ ] I have reviewed the [documentation](https://aka.ms/ameonboard) for the workflow.
- [ ] [Validation tools](https://aka.ms/swaggertools) were run on swagger spec(s) and errors have all been fixed in this PR. [How to fix?](https://aka.ms/ci-fix)
What's the purpose of this PR? Check all that apply. This is **mandatory**!

If any further question about AME onboarding or validation tools, please view the [FAQ](https://aka.ms/faqinprreview).
- [ ] New API version. (Such PR should have been generated with [OpenAPI Hub](https://aka.ms/openapihub), per [this wiki doc](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version).)
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [ ] Update existing version to fix swagger quality issues in S360.
- [ ] Other, please clarify:
- _edit this with your clarification_

### ARM API Review Checklist
## Due diligence checklist

> **Applicability**: :warning:
>
> If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
> - Change to data plane APIs
> - Adding new properties
> - All removals
To merge this PR, you **must** go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Otherwise your PR may be subject to ARM review requirements. Complete the following:
- [ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the [wiki](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version). Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
- [ ] I have reviewed the general guidance on the spec PR review process: https://aka.ms/specprreview.
- [ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data-plane related specifications.
- [ ] I commit to follow the [Breaking Change Policy](https://aka.ms/AzBreakingChangesPolicy).
- [ ] I have reviewed following [Resource Provider guidelines](https://aka.ms/rpguidelines), including
[ARM resource provider contract](https://github.com/Azure/azure-resource-manager-rpc) and
[REST guidelines](https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md) (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.

- [ ] Ensure you've reviewed following [guidelines](https://aka.ms/rpguidelines) including [ARM resource provider contract](https://github.com/Azure/azure-resource-manager-rpc) and [REST guidelines](https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md). Estimated time (4 hours). This is required before you can request review from ARM API Review board.
### ARM API changes review

- [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (*RP Manifest Approvers* team under <ins>Azure Resource Manager service</ins>) from IcM and reach out to them.
- If you want for the ARM team to review this PR, you must add the `ARMReview` label.
- The automation may automatically add the `ARMReview` label, if appropriate.
If this happens, proceed according to guidance given in GitHub comments also added by the automation.

### Breaking Change Review Checklist
If you have any breaking changes as defined in the [Breaking Change Policy](https://aka.ms/AzBreakingChangesPolicy/), request approval from the Breaking Change Review Board.
### Breaking change review

**Action**: to initiate an evaluation of the breaking change, create a new intake using the [template for breaking changes](https://aka.ms/Breakingchangetemplate). Additional details on the process and office hours are on the [Breaking Change Wiki](https://eng.ms/docs/cloud-ai-platform/azure-core/azure-core-pm-and-design/trusted-platform-pm-karimb/service-lifecycle-and-actions-team/service-lifecycle-actions-team/apex/media/overview_breakingchanges).
If you have any breaking changes as defined in the [Breaking Change Policy](https://aka.ms/AzBreakingChangesPolicy/),
follow the process outlined in the [High-level Breaking Change Process doc](https://aka.ms/breakingchangesprocess#high-level-breaking-change-process).

## Getting help

NOTE: To update API(s) in public preview for over 1 year (refer to [Retirement of Previews](http://aka.ms/aprwiki))

Please follow the link to find more details on [PR review process](https://aka.ms/SwaggerPRReview).
- For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
- For additional help, see https://aka.ms/azsdk/support/spectools.
Loading