-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Resources to add version stable/2023-07-01 #24667
[Hub Generated] Review request for Microsoft.Resources to add version stable/2023-07-01 #24667
Conversation
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
resources.json | 2023-07-01(52d0112) | 2022-09-01(main) |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 443 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.4) | new version | base version |
---|---|---|
package-resources-2023-07 | package-resources-2023-07(52d0112) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 30 items are listed, please refer to log for more details.
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L38 |
||
Not using the common-types defined parameter 'scope'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L44 |
||
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L44 |
||
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L44 |
||
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L69 |
||
Not using the common-types defined parameter 'scope'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L76 |
||
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L76 |
||
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L76 |
||
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L103 |
||
Not using the common-types defined parameter 'scope'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L109 |
||
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L109 |
||
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L109 |
||
The response of operation:'Deployments_CreateOrUpdateAtScope' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L135 |
||
Not using the common-types defined parameter 'scope'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L142 |
||
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L142 |
||
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L142 |
||
The response of operation:'Deployments_GetAtScope' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L189 |
||
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L189 |
||
Not using the common-types defined parameter 'scope'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L195 |
||
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L195 |
||
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L195 |
||
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L223 |
||
Not using the common-types defined parameter 'scope'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L230 |
||
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L230 |
||
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L230 |
||
A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L254 |
RPC-Async-V1-05 | |
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L255 |
||
Not using the common-types defined parameter 'scope'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L262 |
||
Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L262 |
||
Not using the common-types defined parameter 'api-version'. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L262 |
️❌
Avocado: 1 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
MULTIPLE_DEFAULT_TAGS |
The readme file has more than one default tag. readme: specification/resources/resource-manager/readme.md |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Hi, @gary-x-li! Thank you for your pull request. To help get your PR merged: |
Swagger Generation Artifacts
|
Generated ApiView
|
Hi @gary-x-li! Your PR has some issues. Please fix the CI issues, if present, in following order:
If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel. |
Hi, @gary-x-li. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @gary-x-li. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Swagger pipeline restarted successfully, please wait for status update in this comment. |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.
ARM API changes review
ARMReview
label.ARMReview
label, if appropriate.If this happens, proceed according to guidance given in GitHub comments also added by the automation.
Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.
Getting help
and https://aka.ms/ci-fix.