Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tsv auto folder detection for pr pipeline run #24629
tsv auto folder detection for pr pipeline run #24629
Changes from 23 commits
b66e2ed
7818abc
93bb01d
472e6d0
85801bd
09e6428
38eead2
2081891
c84cdc4
5b99a70
61f1873
38e2205
75efc3d
e1d9e9a
239b42c
909325f
37adb14
06055a4
5ef8fab
8f8915a
6b83e5a
54c0b2f
af2a669
9095230
97e4618
7514081
77110cf
dd1bf28
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fail with error if exactly one parameter is empty (this should never be valid)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add another parameter to control whether the script runs
git restore
andgit clean
between folders. In validation pipelines, these commands are good to isolate the diffs caused by each spec folder. But on dev machines, you generally want to leave the files changed in your enlistment so you can view them in an editor, add them to a PR, etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a dev machine, if validating multiple specs without clean between specs, it means any diffs from earlier specs will cause later specs to fail validation. But I think this is fine. Users will likely review the git diffs in VS Code rather than from the command-line output.