Corrected error being generated during .NET SDK Release #24478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| networkVirtualAppliance.json | 2023-02-01(656d830) | 2023-02-01(main) |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.3) | new version | base version |
|---|---|---|
| package-2023-02 | package-2023-02(656d830) | package-2023-02(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L37 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L85 |
|
Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L105 |
|
The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L181 |
|
Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L248 |
|
Description of 201 response code of a PUT operation MUST include term 'create'. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L248 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L270 |
|
The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L373 |
|
The resource name parameter 'siteName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L373 |
|
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L413 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L422 |
|
Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L535 |
|
Description of 201 response code of a PUT operation MUST include term 'create'. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L535 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L551 |
|
The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L566 |
|
The resource name parameter 'skuName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L658 |
|
The resource name parameter 'networkVirtualApplianceName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L701 |
|
The resource name parameter 'ruleCollectionName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L701 |
|
Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L743 |
|
Description of 201 response code of a PUT operation MUST include term 'create'. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L743 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L759 |
| Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L44 |
|
| Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L105 |
|
| Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L160 |
|
| Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L217 |
|
| Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L295 |
|
| Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L380 |
|
| Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L442 |
|
| Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L497 |
|
| Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2023-02-01/networkVirtualAppliance.json#L573 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
|
Hi, @JainRah Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=368430&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-js - @azure/arm-network - Approved - 32.0.0+ Class NetworkManagementClient has a new signature + Enum KnownApplicationGatewayCustomErrorStatusCode no longer has value HttpStatus499
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.Network [View full logs] [Release SDK Changes]
️❌ azure-sdk-for-net-track2 failed [Detail]
command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mFailed to build sdk. exit code: False cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m
❌Azure.ResourceManager.Network [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.ArmOperation<Azure.ResourceManager.Network.Models.PeerRouteList> Azure.ResourceManager.Network.BgpConnectionResource.GetLearnedRoutesVirtualHubBgpConnection(Azure.WaitUntil, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Threading.Tasks.Task<Azure.ResourceManager.ArmOperation<Azure.ResourceManager.Network.Models.PeerRouteList>> Azure.ResourceManager.Network.BgpConnectionResource.GetLearnedRoutesVirtualHubBgpConnectionAsync(Azure.WaitUntil, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.ArmOperation Azure.ResourceManager.Network.VirtualHubResource.GetEffectiveVirtualHubRoutes(Azure.WaitUntil, Azure.ResourceManager.Network.Models.EffectiveRoutesContent, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Threading.Tasks.Task<Azure.ResourceManager.ArmOperation> Azure.ResourceManager.Network.VirtualHubResource.GetEffectiveVirtualHubRoutesAsync(Azure.WaitUntil, Azure.ResourceManager.Network.Models.EffectiveRoutesContent, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.ArmOperation Azure.ResourceManager.Network.VirtualHubResource.GetInboundRoutes(Azure.WaitUntil, Azure.ResourceManager.Network.Models.VirtualHubInboundRoutesContent, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Threading.Tasks.Task<Azure.ResourceManager.ArmOperation> Azure.ResourceManager.Network.VirtualHubResource.GetInboundRoutesAsync(Azure.WaitUntil, Azure.ResourceManager.Network.Models.VirtualHubInboundRoutesContent, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.ArmOperation Azure.ResourceManager.Network.VirtualHubResource.GetOutboundRoutes(Azure.WaitUntil, Azure.ResourceManager.Network.Models.VirtualHubOutboundRoutesContent, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Threading.Tasks.Task<Azure.ResourceManager.ArmOperation> Azure.ResourceManager.Network.VirtualHubResource.GetOutboundRoutesAsync(Azure.WaitUntil, Azure.ResourceManager.Network.Models.VirtualHubOutboundRoutesContent, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.Models.ApplicationGatewayCustomErrorStatusCode Azure.ResourceManager.Network.Models.ApplicationGatewayCustomErrorStatusCode.HttpStatus499.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.Models.LoadBalancerBackendAddressAdminState Azure.ResourceManager.Network.Models.LoadBalancerBackendAddressAdminState.Drain.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Network.Models.PeerRouteList' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Network/Debug/netstandard2.0/Azure.ResourceManager.Network.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] cmderr [automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.7.1 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.7.1> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-network [View full logs] [Release SDK Changes]info [Changelog]
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-network-generated [View full logs] [Release SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/network/armnetwork [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - `ApplicationGatewayCustomErrorStatusCodeHTTPStatus499` from enum `ApplicationGatewayCustomErrorStatusCode` has been removed info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New enum type `AdminState` with values `AdminStateDisabled`, `AdminStateEnabled` info [Changelog] - New field `ResourceGUID` in struct `AdminPropertiesFormat` info [Changelog] - New field `ResourceGUID` in struct `AdminRuleCollectionPropertiesFormat` info [Changelog] - New field `DefaultPredefinedSSLPolicy` in struct `ApplicationGatewayPropertiesFormat` info [Changelog] - New field `ResourceGUID` in struct `ConnectivityConfigurationProperties` info [Changelog] - New field `ResourceGUID` in struct `DefaultAdminPropertiesFormat` info [Changelog] - New field `ResourceGUID` in struct `GroupProperties` info [Changelog] - New field `ResourceGUID` in struct `ManagerProperties` info [Changelog] - New field `ResourceGUID` in struct `SecurityAdminConfigurationPropertiesFormat` info [Changelog] - New field `AdminState` in struct `VirtualNetworkGatewayPropertiesFormat` info [Changelog] info [Changelog] Total 1 breaking change(s), 12 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-network [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Added Type Alias AdminState info [Changelog] - Interface ActiveDefaultSecurityAdminRule has a new optional parameter resourceGuid info [Changelog] - Interface ActiveSecurityAdminRule has a new optional parameter resourceGuid info [Changelog] - Interface AdminRule has a new optional parameter resourceGuid info [Changelog] - Interface AdminRuleCollection has a new optional parameter resourceGuid info [Changelog] - Interface ApplicationGateway has a new optional parameter defaultPredefinedSslPolicy info [Changelog] - Interface ConfigurationGroup has a new optional parameter resourceGuid info [Changelog] - Interface ConnectivityConfiguration has a new optional parameter resourceGuid info [Changelog] - Interface DefaultAdminRule has a new optional parameter resourceGuid info [Changelog] - Interface EffectiveConnectivityConfiguration has a new optional parameter resourceGuid info [Changelog] - Interface EffectiveDefaultSecurityAdminRule has a new optional parameter resourceGuid info [Changelog] - Interface EffectiveSecurityAdminRule has a new optional parameter resourceGuid info [Changelog] - Interface NetworkGroup has a new optional parameter resourceGuid info [Changelog] - Interface NetworkManager has a new optional parameter resourceGuid info [Changelog] - Interface SecurityAdminConfiguration has a new optional parameter resourceGuid info [Changelog] - Interface VirtualNetworkGateway has a new optional parameter adminState info [Changelog] - Added Enum KnownAdminState info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Class NetworkManagementClient has a new signature info [Changelog] - Enum KnownApplicationGatewayCustomErrorStatusCode no longer has value HttpStatus499
️🔄 azure-resource-manager-schemas inProgress [Detail]
️❌ azure-powershell failed [Detail]
command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json SSL error: syscall failure: Broken pipe Error: SSL error: syscall failure: Broken pipe
❌Az.network.DefaultTag [View full logs]error Fatal error: SSL error: syscall failure: Broken pipe error The following packages are still pending: error Az.network.DefaultTag
Generated ApiView
|
ghost
added
the
JainRah
changed the title
This was referenced Jun 16, 2023
This was referenced Jun 16, 2023
|
@qiaozha - Please help check the JS breaking change. Thanks! |
zedy-wj
added
the
Approved-OkToMerge
raych1
approved these changes
Jun 19, 2023
This was referenced Jun 19, 2023
harryli0108
pushed a commit
to harryli0108/azure-rest-api-specs
that referenced
this pull request
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.