Add Swagger documention for UpgradeDataWarehouse API #2426

vsporeddy · 2018-02-06T00:33:00Z

UpgradeDataWarehouse allows users to perform maintenance updates on their SQL Data Warehouse instances at their own convenience. This change adds the API specifications for this feature.

AutorestCI · 2018-02-06T00:34:43Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#1950

azuresdkciprbot · 2018-02-06T00:39:06Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-02-06T00:39:50Z

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-go)

Command: profileBuilder -s preview -name preview
Finished with return code 127
and output:

/bin/sh: 1: profileBuilder: not found

Fix missing curly brace in databases.json

azuresdkciprbot · 2018-02-06T00:56:15Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-02-06T00:57:13Z

Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-go)

Command: profileBuilder -s preview -name preview
Finished with return code 127
and output:

/bin/sh: 1: profileBuilder: not found

marstr · 2018-02-09T00:36:14Z

@vsporeddy these changes are to an API Version that is in preview. For that reason, you can opt to skip some of the normal review process. However, it would also mean that SDK owners may not generate libraries to target this service.

Is this API Version correctly sorted?

vsporeddy · 2018-02-09T22:34:42Z

@marstr Yes, this is for a preview API version. However I want it to be available in .NET SDK and Azure PowerShell, is that possible?

marstr · 2018-02-13T02:40:01Z

I see, sorry for the confusion! So, we should classify this as belonging in the stable folder, because it is a Swagger that will be built upon by customers. Please make that update, and we'll start the ARM review, etc.

vsporeddy · 2018-02-14T02:01:14Z

Oh no, I meant I was going to make it available in .NET SDK/Azure PowerShell myself. It is still only for 2017-03-01-preview.

marstr · 2018-02-14T23:12:34Z

@vsporeddy says:
I meant I was going to make it available in .NET SDK/Azure PowerShell myself

Ah just for a private preview, or with the intention of shipping to customers? I think there are two things getting confused here:

Whether the API Version is in preview or not (should be denoted by the "-preview" suffix), and speaks to the SLA and long-term availability of that API Version.
Whether or not the Swagger is ready for publication to customers (outside of private preview). This is indicated by whether the API Version is in the preview or stable folder in this repository.

The two aspects are independent of one another. Clearly the API Version is under a more lenient SLA, but should it be considered ready for customers to play with?

ravbhatnagar · 2018-02-15T22:22:19Z

Looks good.

marstr · 2018-02-15T23:32:45Z

KK, well all moot at this point! @vsporeddy are you ready for me to merge this in?

AutorestCI · 2018-02-16T02:51:11Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1258

jaredmoo · 2018-02-16T05:41:45Z

specification/sql/resource-manager/Microsoft.Sql/preview/2017-03-01-preview/databases.json

@@ -480,6 +480,52 @@
          }
        }
      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/databases/{databaseName}/upgradeDataWarehouse": {


missing x-ms-long-running-operation?

jaredmoo

missing x-ms-long-running-operation

marstr · 2018-02-23T00:41:27Z

Just to update this thread, we're currently having some offline conversations about the preview folder. We should respond more adequately tomorrow with more information.

marstr · 2018-02-27T23:40:48Z

Sorry for the delay on this.

After chatting about it internally with @salameer, @johanste, and @lmazuel it seems like some of my statements above had some misinformation. It sounds like we're still committed to publishing bits in the preview folder as public-previews. The only real difference between the stable and preview folders is that SDKs are required to somehow convey to consumers of SDKs generated from Swaggers in the preivew folder that breaking changes may come. Different SDKs will interpret that differently. Python for instance, will release PyPI packages with a suffix to indicate preview status..

lmazuel · 2018-03-09T00:43:06Z

@AutorestCI rebuild azure-sdk-for-python

marstr · 2018-03-09T21:00:41Z

@AutorestCI rebuild azure-sdk-for-go

marstr · 2018-03-12T23:05:41Z

Howdy @vsporeddy, with the context that I layout above, what is the current status of this PR? Is it ready to be in the master branch in the preview folder?

marstr · 2018-03-14T23:14:45Z

Closing this PR as stale. If these changes are still relevant, feel free to have it re-opened or create a new PR. One caveat, I'll be OOF starting Friday the 16th, so if it is re-opened it will need to be reassigned.

AutorestCI · 2018-03-14T23:15:45Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-03-14T23:40:33Z

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-libraries-for-java#292

Venkata Srikar Poreddy added 3 commits February 5, 2018 16:11

Add Swagger documention for UpgradeDataWarehouse API

5ae9dba

UpgradeDataWarehouse allows users to perform maintenance updates on their SQL Data Warehouse instances at their own convenience. This change adds the API specifications for this feature.

Merge remote-tracking branch 'upstream/master'

5369494

Merge remote-tracking branch 'upstream/master'

a9b6990

azuresdkci assigned marstr Feb 6, 2018

AutorestCI mentioned this pull request Feb 6, 2018

[AutoPR sql/resource-manager] Add Swagger documention for UpgradeDataWarehouse API Azure/azure-sdk-for-python#1909

Closed

Fix missing curly brace in databases.json

b37d964

Fix missing curly brace in databases.json

marstr requested review from simongdavies and ravbhatnagar February 13, 2018 02:40

marstr added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 13, 2018

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 15, 2018

marstr approved these changes Feb 15, 2018

View reviewed changes

Venkata Srikar Poreddy added 2 commits February 15, 2018 18:21

Adding to stable folder

09f977a

Fix spacing

f80af83

AutorestCI mentioned this pull request Feb 16, 2018

[AutoPR sql/resource-manager] Add Swagger documention for UpgradeDataWarehouse API Azure/azure-sdk-for-python#1997

Closed

jaredmoo reviewed Feb 16, 2018

View reviewed changes

jaredmoo suggested changes Feb 16, 2018

View reviewed changes

Add x-ms-long-running-operation

5f931c2

jaredmoo approved these changes Feb 16, 2018

View reviewed changes

AutorestCI mentioned this pull request Mar 9, 2018

[AutoPR sql/resource-manager] Add Swagger documention for UpgradeDataWarehouse API Azure/azure-sdk-for-python#2139

Closed

AutorestCI mentioned this pull request Mar 9, 2018

[AutoPR sql/resource-manager] Add Swagger documention for UpgradeDataWarehouse API Azure/azure-sdk-for-go#1232

Closed

marstr closed this Mar 14, 2018

AutorestCI mentioned this pull request Mar 14, 2018

[AutoPR sql/resource-manager] Add Swagger documention for UpgradeDataWarehouse API Azure/azure-libraries-for-java#296

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Swagger documention for UpgradeDataWarehouse API #2426

Add Swagger documention for UpgradeDataWarehouse API #2426

vsporeddy commented Feb 6, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Feb 6, 2018 •

edited

Loading

azuresdkciprbot commented Feb 6, 2018

AutorestCI commented Feb 6, 2018

azuresdkciprbot commented Feb 6, 2018

AutorestCI commented Feb 6, 2018

marstr commented Feb 9, 2018

vsporeddy commented Feb 9, 2018

marstr commented Feb 13, 2018

vsporeddy commented Feb 14, 2018

marstr commented Feb 14, 2018

ravbhatnagar commented Feb 15, 2018

marstr commented Feb 15, 2018

AutorestCI commented Feb 16, 2018 •

edited

Loading

jaredmoo Feb 16, 2018

jaredmoo left a comment

marstr commented Feb 23, 2018

marstr commented Feb 27, 2018

lmazuel commented Mar 9, 2018

marstr commented Mar 9, 2018

marstr commented Mar 12, 2018

marstr commented Mar 14, 2018

AutorestCI commented Mar 14, 2018 •

edited

Loading

AutorestCI commented Mar 14, 2018 •

edited

Loading

Add Swagger documention for UpgradeDataWarehouse API #2426

Add Swagger documention for UpgradeDataWarehouse API #2426

Conversation

vsporeddy commented Feb 6, 2018 • edited by azuresdkci Loading

AutorestCI commented Feb 6, 2018 • edited Loading

Automation for azure-sdk-for-python

azuresdkciprbot commented Feb 6, 2018

AutorestCI commented Feb 6, 2018

azuresdkciprbot commented Feb 6, 2018

AutorestCI commented Feb 6, 2018

marstr commented Feb 9, 2018

vsporeddy commented Feb 9, 2018

marstr commented Feb 13, 2018

vsporeddy commented Feb 14, 2018

marstr commented Feb 14, 2018

ravbhatnagar commented Feb 15, 2018

marstr commented Feb 15, 2018

AutorestCI commented Feb 16, 2018 • edited Loading

Automation for azure-sdk-for-go

jaredmoo Feb 16, 2018

Choose a reason for hiding this comment

jaredmoo left a comment

Choose a reason for hiding this comment

marstr commented Feb 23, 2018

marstr commented Feb 27, 2018

lmazuel commented Mar 9, 2018

marstr commented Mar 9, 2018

marstr commented Mar 12, 2018

marstr commented Mar 14, 2018

AutorestCI commented Mar 14, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Mar 14, 2018 • edited Loading

Automation for azure-libraries-for-java

vsporeddy commented Feb 6, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Feb 6, 2018 •

edited

Loading

AutorestCI commented Feb 16, 2018 •

edited

Loading

AutorestCI commented Mar 14, 2018 •

edited

Loading

AutorestCI commented Mar 14, 2018 •

edited

Loading