Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci-fix.md: clarify prettier TSG #24174

Merged
merged 3 commits into from
May 25, 2023
Merged

Update ci-fix.md: clarify prettier TSG #24174

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56f0c15
Update ci-fix.md: clarify prettier TSG
May 25, 2023
5e0b812
Update ci-fix.md
May 25, 2023
438ed5f
Update ci-fix.md
May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions documentation/ci-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,17 @@ npm install
# Compile TypeScript. Compilation will fail, this is expected. But it will compile 'scripts/prettier-swagger-plugin', which is what we need.
npx tsc

# Run 'prettier --list-different' to understand what is the problem.
# As of 5/25/2023, the prettier version should be 2.1.2
npx prettier --version

# Run 'prettier --check' to verify the problems can be reproduced locally
npx prettier --check **/*.json

# Run 'prettier --list-different' to understand which files have problems.
# Note: there is no way to view the exact problems without actually changing the affected files. See https://github.com/prettier/prettier/issues/6069.
npx prettier --list-different **/*.json

# Run 'prettier --write' to fix the problem.
# Run 'prettier --write' to fix the problems.
npx prettier --write **/*.json
```

Expand Down