Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Search to add version preview/2022-12-01-preview #24161

Merged
merged 1 commit into from
May 25, 2023

Conversation

koyasu221b
Copy link
Member

@koyasu221b koyasu221b commented May 25, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Data Plane API - Pull Request

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document: Support SasToken
  • Previous API Spec Doc:
  • Updated paths:

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

@openapi-workflow-bot
Copy link

Hi, @koyasu221b Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 25, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    search.json 2022-12-01-preview(c7fc187) 2022-12-01-preview(main)
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.2) new version base version
    package-preview-2022-12 package-preview-2022-12(c7fc187) package-preview-2022-12(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
    Location: Search/preview/2022-12-01-preview/search.json#L289
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Search/preview/2022-12-01-preview/search.json#L435
    ⚠️ ErrorResponse The error property in the error response schema should be required.
    Location: Search/preview/2022-12-01-preview/search.json#L435
    ⚠️ ErrorResponse Error schema should define code and message properties as required.
    Location: Search/preview/2022-12-01-preview/search.json#L435
    ⚠️ PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
    Location: Search/preview/2022-12-01-preview/search.json#L442
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Search/preview/2022-12-01-preview/search.json#L483
    ⚠️ ErrorResponse The error property in the error response schema should be required.
    Location: Search/preview/2022-12-01-preview/search.json#L483
    ⚠️ ErrorResponse Error schema should define code and message properties as required.
    Location: Search/preview/2022-12-01-preview/search.json#L483
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Search/preview/2022-12-01-preview/search.json#L543
    ⚠️ ErrorResponse The error property in the error response schema should be required.
    Location: Search/preview/2022-12-01-preview/search.json#L543
    ⚠️ ErrorResponse Error schema should define code and message properties as required.
    Location: Search/preview/2022-12-01-preview/search.json#L543
    ⚠️ PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
    Location: Search/preview/2022-12-01-preview/search.json#L550
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Search/preview/2022-12-01-preview/search.json#L597
    ⚠️ ErrorResponse The error property in the error response schema should be required.
    Location: Search/preview/2022-12-01-preview/search.json#L597
    ⚠️ ErrorResponse Error schema should define code and message properties as required.
    Location: Search/preview/2022-12-01-preview/search.json#L597
    ⚠️ PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
    Location: Search/preview/2022-12-01-preview/search.json#L604
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Search/preview/2022-12-01-preview/search.json#L645
    ⚠️ ErrorResponse The error property in the error response schema should be required.
    Location: Search/preview/2022-12-01-preview/search.json#L645
    ⚠️ ErrorResponse Error schema should define code and message properties as required.
    Location: Search/preview/2022-12-01-preview/search.json#L645
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Search/preview/2022-12-01-preview/search.json#L653
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Search/preview/2022-12-01-preview/search.json#L919
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Search/preview/2022-12-01-preview/search.json#L944
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Search/preview/2022-12-01-preview/search.json#L972
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Search/preview/2022-12-01-preview/search.json#L978
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Search/preview/2022-12-01-preview/search.json#L1001
    ⚠️ PropertyDescription Property should have a description.
    Location: Search/preview/2022-12-01-preview/search.json#L1001
    ⚠️ PropertyDescription Property should have a description.
    Location: Search/preview/2022-12-01-preview/search.json#L1003
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Search/preview/2022-12-01-preview/search.json#L1089
    ⚠️ PropertyDescription Property should have a description.
    Location: Search/preview/2022-12-01-preview/search.json#L1089
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 25, 2023

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 25, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Swagger maps-data-plane-Search https://apiview.dev/Assemblies/Review/0b36d6e966bd4491b01823c95977af3a

    @ghost ghost added the Maps label May 25, 2023
    @koyasu221b koyasu221b marked this pull request as ready for review May 25, 2023 07:04
    @koyasu221b koyasu221b requested a review from a team as a code owner May 25, 2023 07:04
    @koyasu221b koyasu221b requested review from JeffreyRichter and MushMal and removed request for a team May 25, 2023 07:04
    @koyasu221b koyasu221b force-pushed the koyasu221b-maps-Search-2022-12-01-preview branch from 3c521fc to c7fc187 Compare May 25, 2023 07:11
    @tjprescott tjprescott merged commit be63fad into main May 25, 2023
    @tjprescott tjprescott deleted the koyasu221b-maps-Search-2022-12-01-preview branch May 25, 2023 16:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants