[Hub Generated] Publish private branch 'azure-kusto/devCM' #24160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hon image from pipeline if needed
…istUpdater: allow updating while suspended
|
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/12202 |
|
Hi, @michaelshikh07 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| kusto.json | 2023-05-02(94c811b) | 2022-12-29(main) |
| kusto.json | 2023-05-02(94c811b) | 2018-09-07-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 25 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with the latest preview version:
Only 25 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Kusto/clusters/{clusterName}/databases/{databaseName}/eventhubconnections' removed or restructured? Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L984:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Kusto/clusters/{clusterName}/databases/{databaseName}/eventhubConnectionValidation' removed or restructured? Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1032:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Kusto/clusters/{clusterName}/databases/{databaseName}/eventhubconnections/{eventHubConnectionName}' removed or restructured? Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1080:5 |
|
| The new version is missing a definition that was found in the old version. Was 'DatabaseProperties' removed or renamed? New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L4030:3 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1345:3 |
|
| The new version is missing a definition that was found in the old version. Was 'EventHubConnectionValidation' removed or renamed? New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L4030:3 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1345:3 |
|
| The new version is missing a definition that was found in the old version. Was 'DatabaseUpdate' removed or renamed? New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L4030:3 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1345:3 |
|
| The new version is missing a definition that was found in the old version. Was 'EventHubConnectionUpdate' removed or renamed? New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L4030:3 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1345:3 |
|
| The new version is missing a definition that was found in the old version. Was 'EventHubConnection' removed or renamed? New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L4030:3 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1345:3 |
|
| The new version is missing a definition that was found in the old version. Was 'DatabaseCheckNameRequest' removed or renamed? New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L4030:3 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1345:3 |
|
| The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupParameter' removed or renamed? New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L6940:3 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L2065:3 |
|
| The new version is missing a client parameter that was found in the old version. Was 'EventHubConnectionNameParameter' removed or renamed? New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L6940:3 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L2065:3 |
|
| The required parameter 'databaseName' was removed in the new version. Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L496:11 |
|
| The required parameter 'resourceName' was added in the new version. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1087:11 |
|
| The new version adds a response code '202'. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L199:11 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L4055:9 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1367:9 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L53:13 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L53:13 |
|
| The '$ref' property points to different models in the old and new versions. New: common-types/resource-management/v3/types.json#L305:9 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1885:9 |
|
| The '$ref' property points to different models in the old and new versions. New: common-types/resource-management/v3/types.json#L280:11 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L1999:11 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L128:13 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L109:13 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L213:13 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L165:13 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L266:13 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L209:13 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L318:13 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L252:13 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L370:13 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L295:13 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L890:13 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L334:13 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.Kusto/stable/2023-05-02/kusto.json#L929:13 Old: Microsoft.Kusto/preview/2018-09-07-preview/kusto.json#L373:13 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 23 Errors, 1 Warnings failed [Detail]
| compared tags (via openapi-validator v2.1.2) | new version | base version |
|---|---|---|
| package-2023-05 | package-2023-05(94c811b) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L254 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L309 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L361 |
RPC-Async-V1-07 |
|
200 response for a LRO POST operation must have a response schema specified. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L378 |
RPC-Post-V1-03 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L422 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L633 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L787 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L842 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1430 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1566 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1850 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L2176 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L2303 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L2470 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L2591 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L2794 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L3096 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L3149 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L3328 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L3569 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L3714 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L3863 |
RPC-Async-V1-07 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L3924 |
RPC-Async-V1-07 |
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'DatabaseModel'. Consider using the plural form of 'Database' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1594 |
The following errors/warnings exist before current PR submission:
Only 25 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The patch operation body parameter schema should not contains property name. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L156 |
|
The patch operation body parameter schema should not contains property type. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L156 |
|
The patch operation body parameter schema should not contains property location. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L156 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L201 |
|
200 response for a LRO POST operation must have a response schema specified. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L274 |
|
200 response for a LRO POST operation must have a response schema specified. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L326 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L681 |
|
200 response for a LRO POST operation must have a response schema specified. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L743 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L884 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L923 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L959 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1046 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1244 |
|
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1369 |
|
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1369 |
|
A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1369 |
|
The patch operation body parameter schema should not contains property name. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1470 |
|
The patch operation body parameter schema should not contains property type. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1470 |
|
The patch operation body parameter schema should not contains property location. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1470 |
|
Properties of a PATCH request body must not be required, property:kind. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1474 |
|
200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1490 |
|
A 202 response should include an Location response header. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1510 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L1901 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L2051 |
|
The patch operation body parameter schema should not contains property name. Location: Microsoft.Kusto/stable/2023-05-02/kusto.json#L2225 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"code: InvalidResourceType, message: The resource type 'operations' could not be found in the namespace 'Microsoft.Kusto' for api version '2023-05-02'. The supported api-versions are '2017-09-07-privatepreview, 2018-09-07-preview, 2019-01-21, 2019-05-15, 2019-09-07, 2019-11-09, 2020-02-15, 2020-06-14, 2020-09-18, 2021-01-01, 2021-08-27, 2022-02-01, 2022-07-07, 2022-11-11, 2022-12-29'." |
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
michaelshikh07
added
the
DoNotMerge
AzureRestAPISpecReview
added
ARMReview
BreakingChangeReviewRequired
|
Hi @michaelshikh07, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi @michaelshikh07, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced May 25, 2023
kazrael2119
added
Approved-OkToMerge
kazrael2119
added
Approved-LintDiff
Approved-SdkBreakingChange-Go
approve breakingchange, sdk breaking change, and lintdiff, because they are approved in private repo |
|
@michaelshikh07 ,please let me know when you want to merge this pr |
kazrael2119
approved these changes
May 25, 2023
kazrael2119
added
the
ARMSignedOff
|
Hello @kazrael2119, |
tadelesh
deleted the
published/Azure/azure-rest-api-specs-pr/azure-kusto/devCM
branch
This was referenced Jun 8, 2023
lirenhe
pushed a commit
that referenced
this pull request
Jun 8, 2023
tadelesh
pushed a commit
that referenced
this pull request
Jun 24, 2023
harryli0108
pushed a commit
to harryli0108/azure-rest-api-specs
that referenced
this pull request
Jul 28, 2023
* [AutoSync] dad295e34cd Merged PR 7593889: Python pipeline: Re-tag python image from pipeline if needed * [AutoSync] 779e3f273da Merged PR 7983985: NetworkSettingsAllowedFqdnListUpdater: allow updating while suspended * [AutoSync] 8234bea6386 Merged PR 8021356: Add db pagination to may 2023 version * [AutoSync] 3a2bf0e47c8 Merged PR 8120727: Region buildout: Fix specifying RpVmSize * [AutoSync] c87d8729e5a Merged PR 8147686: [Swagger] Fix LintDiff errors * [AutoSync] 5350cd308a9 Merged PR 8166361: Use upper-case values when configuring CORS --------- Co-authored-by: swagger-automation <[email protected]>
harryli0108
pushed a commit
to harryli0108/azure-rest-api-specs
that referenced
this pull request
Jul 28, 2023
…zure#24160)" (Azure#24355) This reverts commit 3ee1392.
harryli0108
pushed a commit
to harryli0108/azure-rest-api-specs
that referenced
this pull request
Jul 28, 2023
…evCM' (Azure#24160)" (Azure#24355)" (Azure#24551) This reverts commit 6c157d4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.