added x-ms-mutability for VulnerabilityAssessmentRecurringScansProper… #24139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @12VamshiKrishna Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| sqlServer.json | 2021-06-01(291f7dc) | 2021-06-01(main) |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.2) | new version | base version |
|---|---|---|
| package-2021-06 | package-2021-06(291f7dc) | package-2021-06(main) |
| package-composite-v2 | package-composite-v2(291f7dc) | package-composite-v2(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L24 |
|
The resource name parameter 'blobAuditingPolicyName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L24 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L24 |
|
The resource name parameter 'blobAuditingPolicyName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L24 |
|
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L81 |
|
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L81 |
|
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L81 |
|
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L81 |
|
Any Put MUST contain 200 and 201 return codes. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L125 |
|
Any Put MUST contain 200 and 201 return codes. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L125 |
|
A 202 response should include an Location response header. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L132 |
|
A 202 response should include an Location response header. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L132 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L156 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L156 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L203 |
|
The resource name parameter 'blobAuditingPolicyName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L203 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L203 |
|
The resource name parameter 'blobAuditingPolicyName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L203 |
|
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L260 |
|
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L260 |
|
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L260 |
|
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L260 |
|
Any Put MUST contain 200 and 201 return codes. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L304 |
|
Any Put MUST contain 200 and 201 return codes. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L304 |
|
A 202 response should include an Location response header. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L311 |
|
A 202 response should include an Location response header. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L311 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L335 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L335 |
|
The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L382 |
|
The resource name parameter 'securityAlertPolicyName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L382 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/synapse/resource-manager/readme.md tag: specification/synapse/resource-manager/readme.md#tag-package-composite-v2 |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1026:22 ExampleUrl: stable/2021-06-01/examples/WorkspaceManagedSqlServerEncryptionProtectorRevalidate.json |
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
…ties in sqlserver
|
Hi @12VamshiKrishna, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced May 24, 2023
ghost
added
the
tadelesh
approved these changes
May 24, 2023
|
ModelValidation is fixed in #24089. |
11 tasks
This was referenced May 24, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.