[Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-03-01 #24110

Liran-E · 2023-05-23T12:47:41Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
  There's an issue with the documentation url.
  When going to this page with api-version 2019-03-01 it built the url with a different API which caused issues.
  This PR is a fix to the url reference
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2023-05-23T12:47:44Z

Swagger Validation Report

️❌BreakingChange: 16 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
AlertRuleRecommendations.json	2023-01-01-preview(be58f06)	2023-01-01-preview(main)
AlertsManagement.json	2019-03-01(be58f06)	2019-03-01(main)

Rule	Message
`❌` 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L272:9 Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L272:9
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) '2018-05-05' from the old version. Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L34:9
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) '2018-05-05' from the old version. Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L64:9
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) '2018-05-05' from the old version. Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L100:9
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) '2018-05-05' from the old version. Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L194:9
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) '2018-05-05' from the old version. Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L230:9
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) '2018-05-05' from the old version. Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L308:9
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) '2018-05-05' from the old version. New: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L391:5 Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L391:5
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) '2019-03-01' from the old version. New: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L34:9
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) '2019-03-01' from the old version. New: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L64:9
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) '2019-03-01' from the old version. New: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L100:9
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) '2019-03-01' from the old version. New: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L194:9
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) '2019-03-01' from the old version. New: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L230:9
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) '2019-03-01' from the old version. New: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L308:9
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) '2019-03-01' from the old version. New: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L391:5 Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L391:5
`❌` 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L272:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.2)	new version	base version
package-2021-04-only	package-2021-04-only(be58f06)	package-2021-04-only(main)
package-2019-03	package-2019-03(be58f06)	package-2019-03(main)
package-2023-03	package-2023-03(be58f06)	package-2023-03(main)
package-2021-08	package-2021-08(be58f06)	package-2021-08(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` MissingDefaultResponse	Operation is missing a default response. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L42
`❌` MissingDefaultResponse	Operation is missing a default response. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L42
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L42
`❌` RequiredDefaultResponse	The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L42
`❌` OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.AlertsManagement/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L45
`❌` OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.AlertsManagement/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L45
`❌` OperationsApiSchemaUsesCommonTypes	Operations API path must follow the schema provided in the common types. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L46
`❌` OperationsApiSchemaUsesCommonTypes	Operations API path must follow the schema provided in the common types. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L46
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L78
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L78
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.AlertsManagement/alerts/{alertId}' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.AlertsManagement/alerts' that has the scope parameter.'. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L96
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.AlertsManagement/alerts/{alertId}/changestate' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.AlertsManagement/alerts' that has the scope parameter.'. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L96
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.AlertsManagement/alerts/{alertId}/history' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.AlertsManagement/alerts' that has the scope parameter.'. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L96
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.AlertsManagement/alertsSummary' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.AlertsManagement/alerts' that has the scope parameter.'. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L96
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.AlertsManagement/alerts/{alertId}' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.AlertsManagement/alerts' that has the scope parameter.'. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L96
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.AlertsManagement/alerts/{alertId}/changestate' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.AlertsManagement/alerts' that has the scope parameter.'. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L96
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.AlertsManagement/alerts/{alertId}/history' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.AlertsManagement/alerts' that has the scope parameter.'. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L96
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.AlertsManagement/alertsSummary' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.AlertsManagement/alerts' that has the scope parameter.'. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L96
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.AlertsManagement/alerts/{alertId}/changestate' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.AlertsManagement/alerts/{alertId}' that has the scope parameter.'. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L186
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.AlertsManagement/alerts/{alertId}/history' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.AlertsManagement/alerts/{alertId}' that has the scope parameter.'. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L186
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.AlertsManagement/alerts/{alertId}/changestate' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.AlertsManagement/alerts/{alertId}' that has the scope parameter.'. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L186
`❌` NoDuplicatePathsForScopeParameter	Path '/{scope}/providers/Microsoft.AlertsManagement/alerts/{alertId}/history' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.AlertsManagement/alerts/{alertId}' that has the scope parameter.'. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L186
`❌` ParametersInPost	newState is a query parameter. Post operation must not contain any query parameter other than api-version. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L230
`❌` ParametersInPost	newState is a query parameter. Post operation must not contain any query parameter other than api-version. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L230
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L286
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L286
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L355
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L355
`❌` XmsParameterLocation	The parameter 'subscriptionId' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L384
`❌` XmsParameterLocation	The parameter 'subscriptionId' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L384

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/alertsmanagement/resource-manager/readme.md tag: specification/alertsmanagement/resource-manager/readme.md#tag-package-2023-03

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2023-05-23T12:47:44Z

Hi, @Liran-E Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2023-05-23T12:47:45Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/alertsmanagement/armalertsmanagement - Approved - 0.9.0

+	Type of `AlertsClientChangeStateOptions.Comment` has been changed from `*string` to `*Comments`
+	Type of `ErrorResponse.Error` has been changed from `*ErrorResponseBody` to `*ErrorDetail`
+	Type of `ErrorResponseAutoGenerated.Error` has been changed from `*ErrorResponseBodyAutoGenerated` to `*ErrorResponseBody`
+	Type of `ErrorResponseAutoGenerated2.Error` has been changed from `*ErrorResponseBodyAutoGenerated2` to `*ErrorResponseBodyAutoGenerated`

❌azure-sdk-for-python-track2 - track2_azure-mgmt-alertsmanagement - Approved - 2.0.0b2

+	Model ResourceAutoGenerated no longer has parameter system_data

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 0cffd39. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:800
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 800 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.AlertsManagement [View full logs] [Release SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 0cffd39. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-alertsmanagement [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group AlertRuleRecommendationsOperations
info	[Changelog]   - Model Resource has a new parameter system_data
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model ResourceAutoGenerated no longer has parameter system_data

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0cffd39. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/alertsmanagement/armalertsmanagement [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `AlertsClientChangeStateOptions.Comment` has been changed from `*string` to `*Comments`
info	[Changelog] - Type of `ErrorResponse.Error` has been changed from `*ErrorResponseBody` to `*ErrorDetail`
info	[Changelog] - Type of `ErrorResponseAutoGenerated.Error` has been changed from `*ErrorResponseBodyAutoGenerated` to `*ErrorResponseBody`
info	[Changelog] - Type of `ErrorResponseAutoGenerated2.Error` has been changed from `*ErrorResponseBodyAutoGenerated2` to `*ErrorResponseBodyAutoGenerated`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `MetricAlertsDisplayUnit` with values `MetricAlertsDisplayUnitBillion`, `MetricAlertsDisplayUnitBillionPerSecond`, `MetricAlertsDisplayUnitBytes`, `MetricAlertsDisplayUnitBytesPerDay`, `MetricAlertsDisplayUnitBytesPerHour`, `MetricAlertsDisplayUnitBytesPerMinute`, `MetricAlertsDisplayUnitBytesPerSecond`, `MetricAlertsDisplayUnitCount`, `MetricAlertsDisplayUnitCountPerDay`, `MetricAlertsDisplayUnitCountPerHour`, `MetricAlertsDisplayUnitCountPerMinute`, `MetricAlertsDisplayUnitCountPerSecond`, `MetricAlertsDisplayUnitDays`, `MetricAlertsDisplayUnitGigabytes`, `MetricAlertsDisplayUnitGigabytesPerSecond`, `MetricAlertsDisplayUnitHours`, `MetricAlertsDisplayUnitKilobytes`, `MetricAlertsDisplayUnitKilobytesPerSecond`, `MetricAlertsDisplayUnitMegabytes`, `MetricAlertsDisplayUnitMegabytesPerSecond`, `MetricAlertsDisplayUnitMicroSeconds`, `MetricAlertsDisplayUnitMilliSeconds`, `MetricAlertsDisplayUnitMillion`, `MetricAlertsDisplayUnitMillionPerSecond`, `MetricAlertsDisplayUnitMinutes`, `MetricAlertsDisplayUnitNone`, `MetricAlertsDisplayUnitPercentage`, `MetricAlertsDisplayUnitPetabytes`, `MetricAlertsDisplayUnitPetabytesPerSecond`, `MetricAlertsDisplayUnitSeconds`, `MetricAlertsDisplayUnitTerabytes`, `MetricAlertsDisplayUnitTerabytesPerSecond`, `MetricAlertsDisplayUnitThousand`, `MetricAlertsDisplayUnitThousandPerSecond`, `MetricAlertsDisplayUnitTrillion`, `MetricAlertsDisplayUnitTrillionPerSecond`
info	[Changelog] - New function `NewAlertRuleRecommendationsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AlertRuleRecommendationsClient, error)`
info	[Changelog] - New function `*AlertRuleRecommendationsClient.NewListByResourcePager(string, *AlertRuleRecommendationsClientListByResourceOptions) *runtime.Pager[AlertRuleRecommendationsClientListByResourceResponse]`
info	[Changelog] - New function `*AlertRuleRecommendationsClient.NewListByTargetTypePager(string, *AlertRuleRecommendationsClientListByTargetTypeOptions) *runtime.Pager[AlertRuleRecommendationsClientListByTargetTypeResponse]`
info	[Changelog] - New function `*ClientFactory.NewAlertRuleRecommendationsClient() *AlertRuleRecommendationsClient`
info	[Changelog] - New function `*ClientFactory.NewPrometheusRuleGroupsClient() *PrometheusRuleGroupsClient`
info	[Changelog] - New function `NewPrometheusRuleGroupsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PrometheusRuleGroupsClient, error)`
info	[Changelog] - New function `*PrometheusRuleGroupsClient.CreateOrUpdate(context.Context, string, string, PrometheusRuleGroupResource, *PrometheusRuleGroupsClientCreateOrUpdateOptions) (PrometheusRuleGroupsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*PrometheusRuleGroupsClient.Delete(context.Context, string, string, *PrometheusRuleGroupsClientDeleteOptions) (PrometheusRuleGroupsClientDeleteResponse, error)`
info	[Changelog] - New function `*PrometheusRuleGroupsClient.Get(context.Context, string, string, *PrometheusRuleGroupsClientGetOptions) (PrometheusRuleGroupsClientGetResponse, error)`
info	[Changelog] - New function `*PrometheusRuleGroupsClient.NewListByResourceGroupPager(string, *PrometheusRuleGroupsClientListByResourceGroupOptions) *runtime.Pager[PrometheusRuleGroupsClientListByResourceGroupResponse]`
info	[Changelog] - New function `*PrometheusRuleGroupsClient.NewListBySubscriptionPager(*PrometheusRuleGroupsClientListBySubscriptionOptions) *runtime.Pager[PrometheusRuleGroupsClientListBySubscriptionResponse]`
info	[Changelog] - New function `*PrometheusRuleGroupsClient.Update(context.Context, string, string, PrometheusRuleGroupResourcePatchParameters, *PrometheusRuleGroupsClientUpdateOptions) (PrometheusRuleGroupsClientUpdateResponse, error)`
info	[Changelog] - New struct `AlertRuleRecommendationProperties`
info	[Changelog] - New struct `AlertRuleRecommendationResource`
info	[Changelog] - New struct `AlertRuleRecommendationsListResponse`
info	[Changelog] - New struct `Comments`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponseAutoGenerated3`
info	[Changelog] - New struct `PrometheusRule`
info	[Changelog] - New struct `PrometheusRuleGroupAction`
info	[Changelog] - New struct `PrometheusRuleGroupProperties`
info	[Changelog] - New struct `PrometheusRuleGroupResource`
info	[Changelog] - New struct `PrometheusRuleGroupResourceCollection`
info	[Changelog] - New struct `PrometheusRuleGroupResourcePatchParameters`
info	[Changelog] - New struct `PrometheusRuleGroupResourcePatchParametersProperties`
info	[Changelog] - New struct `PrometheusRuleResolveConfiguration`
info	[Changelog] - New struct `ProxyResource`
info	[Changelog] - New struct `ResourceAutoGenerated`
info	[Changelog] - New struct `RuleArmTemplate`
info	[Changelog] - New struct `TrackedResource`
info	[Changelog] - New field `SystemData` in struct `Resource`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 88 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 0cffd39. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️alertsmanagement [View full logs]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 0cffd39. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

❌Az.alertsmanagement.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.alertsmanagement.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-23T12:47:46Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/alertsmanagement/armalertsmanagement	https://apiview.dev/Assemblies/Review/57596da6a8974cfeb17247773ce12874

openapi-workflow-bot · 2023-05-23T12:54:39Z

Hi @Liran-E, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

JackTn · 2023-05-24T07:17:01Z

@Liran-E Pls fill in the summary changelog, contribution checklist, ARM API Review Checklist in first comment and check breaking change refer to #24110 (comment). Thanks

JackTn · 2023-05-29T09:15:26Z

@JeffreyRichter Help approve breaking change for this pr ?

JackTn · 2023-05-30T07:29:17Z

@JeffreyRichter Help approve breaking change for this pr ?

JeffreyRichter · 2023-05-30T16:02:39Z

You have to justify these breaks. Azure's policy is to never remove enum values and new enum values must be added to a new api-version.

JackTn · 2023-05-31T06:51:45Z

You have to justify these breaks. Azure's policy is to never remove enum values and new enum values must be added to a new api-version.

@Liran-E pls fix or justify breaking changes

Liran-E · 2023-05-31T07:59:17Z

@JeffreyRichter , @JackTn
It's is not a breaking change as it's a fix to the documentation.
Without this fix, if a user follows the documentation he/she will encounter an error if he uses ResourceId as scope.

JeffreyRichter · 2023-05-31T20:22:42Z

I approved the PR

JackTn · 2023-06-01T03:27:16Z

@tadelesh take a look on this sdk breakingchange for go and help to appoved it, Thanks

JackTn · 2023-06-01T03:27:29Z

@msyyc @tadelesh take a look on this sdk breakingchange for python and help to appoved it, Thanks

JackTn · 2023-06-06T03:12:16Z

@Liran-E need merge now ?

Liran-E · 2023-06-06T07:24:30Z

@JackTn
yes thank you

JackTn · 2023-06-06T08:20:37Z

@msyyc #24110 (comment) take a look on this pr and help to merge it, thanks

…version stable/2019-03-01 (Azure#24110) * change api version to the proper api version * changed reference to common types api-version * changed TargetTypeParameter to type method --------- Co-authored-by: MIDDLEEAST\lienglender <[email protected]>

change api version to the proper api version

e35472e

Liran-E requested review from ofirmanor and orieldar as code owners May 23, 2023 12:47

openapi-assignment-bot bot assigned JackTn May 23, 2023

ghost added the Alerts Management label May 23, 2023

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels May 23, 2023

azure-sdk mentioned this pull request May 23, 2023

[AutoPR sdk/resourcemanager/alertsmanagement/armalertsmanagement] [Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-03-01 azure-sdk/azure-sdk-for-go#5813

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label May 23, 2023

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label May 23, 2023

changed reference to common types api-version

5e9ecb5

JackTn closed this May 30, 2023

JackTn reopened this May 30, 2023

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 31, 2023

msyyc added the Approved-SdkBreakingChange-Python label Jun 2, 2023

tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jun 5, 2023

changed TargetTypeParameter to type method

be58f06

tadelesh approved these changes Jun 6, 2023

View reviewed changes

JackTn added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jun 6, 2023

msyyc merged commit 0cffd39 into main Jun 7, 2023

msyyc deleted the Liran-E-alertsmanagement-Microsoft.AlertsManagement-2019-03-01 branch June 7, 2023 02:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-03-01 #24110

[Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-03-01 #24110

Liran-E commented May 23, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 23, 2023 •

edited

Loading

openapi-workflow-bot bot commented May 23, 2023

openapi-pipeline-app bot commented May 23, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented May 23, 2023 •

edited

Loading

openapi-workflow-bot bot commented May 23, 2023

JackTn commented May 24, 2023

JackTn commented May 29, 2023

JackTn commented May 30, 2023

JeffreyRichter commented May 30, 2023

JackTn commented May 31, 2023

Liran-E commented May 31, 2023

JeffreyRichter commented May 31, 2023

JackTn commented Jun 1, 2023

JackTn commented Jun 1, 2023

JackTn commented Jun 6, 2023

Liran-E commented Jun 6, 2023

JackTn commented Jun 6, 2023 •

edited

Loading

[Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-03-01 #24110

[Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-03-01 #24110

Conversation

Liran-E commented May 23, 2023 • edited Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented May 23, 2023 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented May 23, 2023

openapi-pipeline-app bot commented May 23, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented May 23, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented May 23, 2023

JackTn commented May 24, 2023

JackTn commented May 29, 2023

JackTn commented May 30, 2023

JeffreyRichter commented May 30, 2023

JackTn commented May 31, 2023

Liran-E commented May 31, 2023

JeffreyRichter commented May 31, 2023

JackTn commented Jun 1, 2023

JackTn commented Jun 1, 2023

JackTn commented Jun 6, 2023

Liran-E commented Jun 6, 2023

JackTn commented Jun 6, 2023 • edited Loading

Liran-E commented May 23, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 23, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 23, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 23, 2023 •

edited

Loading

JackTn commented Jun 6, 2023 •

edited

Loading