Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing container service warning and arm-types reference #24044

Merged
merged 11 commits into from
May 24, 2023
Merged

Fixing container service warning and arm-types reference #24044

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ef0781b
Fixing container service warning and arm-types reference
allenjzhang May 18, 2023
ca83b34
Add Fleet.Management to CI pipeline
mikeharder May 18, 2023
0a4508a
Update tspconfig.yaml to align with sample
mikeharder May 18, 2023
6896819
Update specification/containerservice/Fleet.Management/tspconfig.yaml
mikeharder May 19, 2023
82cc31d
Revert "Update specification/containerservice/Fleet.Management/tspcon…
mikeharder May 19, 2023
010c659
Removing last suppression
allenjzhang May 22, 2023
05ec4ae
update arm-types-dir to use absolute path. Need fixing it later
allenjzhang May 23, 2023
557e29f
Update arm-types-dir to correct path
mikeharder May 23, 2023
87ccb2b
Remove arm-types-dir
mikeharder May 23, 2023
9b80ddd
Merge branch 'main' into azhang_FixContainerServiceFleetTypeSpec
mikeharder May 23, 2023
6dd5f91
Remove unnecessary "./" in tspconfig.yaml
mikeharder May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions eng/pipelines/typespec-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ jobs:
Folder: specification/cognitiveservices/OpenAI.Inference
DisplayName: OpenAI.Inference

- template: templates/steps/typespec-ci.yml
parameters:
Folder: specification/containerservice/Fleet.Management
DisplayName: Fleet.Management

- template: templates/steps/typespec-ci.yml
parameters:
Folder: specification/translation/Azure.AI.TextTranslation
Expand Down
10 changes: 1 addition & 9 deletions specification/containerservice/Fleet.Management/fleet.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,7 @@ interface Fleets {
get is ArmResourceRead<Fleet>;

@doc("Creates or updates a Fleet.")
@operationId("Fleets_CreateOrUpdate")
create is ArmResourceCreateOrUpdateAsync<
createOrUpdate is ArmResourceCreateOrUpdateAsync<
Fleet,
BaseParameters<Fleet> &
IfMatchParameters<Fleet> &
Expand All @@ -121,12 +120,6 @@ interface Fleets {
BaseParameters<Fleet> & IfMatchParameters<Fleet>
>;

@extension(
"x-ms-long-running-operation-options",
{
"final-state-via": "location",
}
)
delete is ArmResourceDeleteAsync<
Fleet,
BaseParameters<Fleet> & IfMatchParameters<Fleet>
Expand All @@ -135,7 +128,6 @@ interface Fleets {
@doc("Lists fleets in the specified subscription and resource group.")
listByResourceGroup is ArmResourceListByParent<Fleet>;

@operationId("Fleets_ListBySubscription")
@doc("Lists fleets in the specified subscription.")
listBySubscription is ArmListBySubscription<Fleet>;

Expand Down
7 changes: 4 additions & 3 deletions specification/containerservice/Fleet.Management/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ emit:
- '@azure-tools/typespec-autorest'
options:
'@azure-tools/typespec-autorest':
azure-resource-provider-folder: '{cwd}/../resource-manager'
azure-resource-provider-folder: "./resource-manager"
mikeharder marked this conversation as resolved.
Show resolved Hide resolved
emitter-output-dir: "{project-root}/.."
examples-directory: "./examples"
output-file: "{azure-resource-provider-folder}/{service-name}/fleet/{version-status}/{version}/fleets.json"
examples-directory: '{cwd}/examples'
omit-unreachable-types: true
omit-unreachable-types: true