Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenAI] Update properties back from optional to nullable #24039

Merged
merged 1 commit into from
May 18, 2023
Merged

[OpenAI] Update properties back from optional to nullable #24039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specification/cognitiveservices/OpenAI.Inference/models/chat.completions.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ model ChatChoice {

@doc("The reason that this chat completions choice completed its generated.")
@projectedName("json", "finish_reason")
finishReason?: CompletionsFinishReason;
finishReason: CompletionsFinishReason | null;

@doc("The delta message content for a streaming response.")
@projectedName("json", "delta")
Expand Down
4 changes: 2 additions & 2 deletions specification/cognitiveservices/OpenAI.Inference/models/completions.create.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,11 @@ model Choice {
@doc("The log probabilities model for tokens associated with this completions choice.")
@projectedName("json", "logprobs")
@projectedName("csharp", "LogProbabilityModel")
logprobs?: CompletionsLogProbabilityModel;
logprobs: CompletionsLogProbabilityModel | null;

@doc("Reason for finishing")
@projectedName("json", "finish_reason")
finishReason?: CompletionsFinishReason;
finishReason: CompletionsFinishReason | null;
}

alias NullableFloat = float32 | null;
Expand Down