Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NetAppFiles] Add api version 2022-07-01-preview take 2 #23877

Closed
wants to merge 3 commits into from
Closed

[NetAppFiles] Add api version 2022-07-01-preview take 2 #23877

wants to merge 3 commits into from

Conversation

audunn
Copy link
Member

@audunn audunn commented May 9, 2023 •
edited
Loading

ARM API Information (Control Plane)

This PR is to address a s360 Completeness issue where the public specs whare missing the preview api-verison 2022-07-01-preview.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@audunn audunn requested a review from ArcturusZhang as a code owner May 9, 2023 12:59
@openapi-workflow-bot
Copy link

Hi, @audunn Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 9, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 92 Errors, 228 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    netapp.json 2022-07-01-preview(7f1f81f) 2022-05-01(main)
    netapp.json 2022-07-01-preview(7f1f81f) 2021-04-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SubscriptionId' removed or renamed?
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L7920:3
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L7929:3
    ❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'location' removed or renamed?
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L7920:3
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L7929:3
    ❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ResourceGroup' removed or renamed?
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L7920:3
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L7929:3
    ❌ 1011 - AddingResponseCode The new version adds a response code '200'.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L3623:11
    ❌ 1019 - RemovedEnumValue The new version is removing enum value(s) 'None, UserAssigned, SystemAssigned,UserAssigned' from the old version.
    New: common-types/resource-management/v3/types.json#L214:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L4633:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v3/managedidentity.json#L53:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L4623:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v3/managedidentity.json#L59:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L4628:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v3/managedidentity.json#L21:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L4663:9
    ❌ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v3/managedidentity.json#L27:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L4668:9
    ❌ 1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: common-types/resource-management/v3/types.json#L203:7
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L4622:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'placementRules' renamed or removed?
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L5393:7
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L5378:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'userAssignedIdentities' renamed or removed?
    New: common-types/resource-management/v3/types.json#L203:7
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L4622:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'oldVolumeId' renamed or removed?
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L6114:7
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L6068:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'oldBareMetalTenantId' renamed or removed?
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L6114:7
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L6068:7
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L377:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L377:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L417:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L417:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L455:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L455:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L514:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L511:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L557:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L554:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L619:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L616:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L663:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L660:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L706:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L703:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L747:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L744:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L807:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L804:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L864:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L861:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L907:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L904:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L957:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L954:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L1001:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L998:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L1067:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L1064:9
    ❌ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L1130:9
    Old: Microsoft.NetApp/stable/2022-05-01/netapp.json#L1127:9


    The following breaking changes are detected by comparison with the latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SubscriptionId' removed or renamed?
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L7920:3
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L5192:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'location' removed or renamed?
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L7920:3
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L5192:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ResourceGroup' removed or renamed?
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L7920:3
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L5192:3
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'NetAppResourceRegionInfo_Get' to 'NetAppResource_QueryRegionInfo'. This will impact generated code.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L296:7
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L211:7
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L135:13
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L130:13
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: common-types/resource-management/v3/types.json#L61:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L3033:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: common-types/resource-management/v3/types.json#L61:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L3314:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L5140:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L3351:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: common-types/resource-management/v3/types.json#L61:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L3549:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L5413:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L3615:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L6232:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L4115:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: common-types/resource-management/v3/types.json#L61:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L4432:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L6638:11
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L4535:11
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: common-types/resource-management/v3/types.json#L61:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L4934:9
    ⚠️ 1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L6029:7
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L3983:7
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L48:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L48:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L82:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L77:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L129:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L124:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L176:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L171:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L303:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L218:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L377:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L255:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L4955:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L3259:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L417:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L295:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L455:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L333:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L514:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L389:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L557:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L432:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L663:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L494:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L5133:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L3343:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L706:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L537:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L747:9
    Old: Microsoft.NetApp/preview/2021-04-01-preview/netapp.json#L578:9
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.1) new version base version
    package-netapp-2022-07-01-preview package-netapp-2022-07-01-preview(7f1f81f) default(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.NetApp/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L59
    ❌ ResourceNameRestriction The resource name parameter 'quotaLimitName' should be defined with a 'pattern' restriction.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L255
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L530
    ❌ PatchIdentityProperty The patch operation body parameter schema should contains property 'identity'.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L558
    ❌ UnSupportedPatchProperties The patch operation body parameter schema should not contains property name.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L558
    ❌ UnSupportedPatchProperties The patch operation body parameter schema should not contains property type.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L558
    ❌ UnSupportedPatchProperties The patch operation body parameter schema should not contains property location.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L558
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L587
    ❌ PostOperationAsyncResponseValidation An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L612
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L637
    ❌ CreateOperationAsyncResponseValidation An async PUT operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'azure-async-operation' on 'x-ms-long-running-operation-options'
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L740
    ❌ UnSupportedPatchProperties The patch operation body parameter schema should not contains property name.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L808
    ❌ UnSupportedPatchProperties The patch operation body parameter schema should not contains property type.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L808
    ❌ UnSupportedPatchProperties The patch operation body parameter schema should not contains property location.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L808
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L840
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L882
    ❌ CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L1043
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L1043
    ❌ UnSupportedPatchProperties The patch operation body parameter schema should not contains property name.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L1068
    ❌ UnSupportedPatchProperties The patch operation body parameter schema should not contains property type.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L1068
    ❌ UnSupportedPatchProperties The patch operation body parameter schema should not contains property location.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L1068
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L1103
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L1158
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L1278
    ❌ PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L1297
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L1328
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L1384
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L1440
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L1585
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.NetApp/preview/2022-07-01-preview/netapp.json#L1635
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 9, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️🔄ApiDocPreview inProgress [Detail]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking



    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 5d44006b40b13174c0e246a9ed8f484b202ea616. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.6
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-netapp [View full logs]  [Preview SDK Changes] 
      info	[Changelog]
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 5d44006b40b13174c0e246a9ed8f484b202ea616. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.NetApp [View full logs]  [Preview SDK Changes] 
      info	[Changelog]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 5d44006b40b13174c0e246a9ed8f484b202ea616. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.
    • ️✔️@azure/arm-netapp [View full logs]  [Preview SDK Changes] 
      info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 5d44006b40b13174c0e246a9ed8f484b202ea616. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/netapp/armnetapp [View full logs]  [Preview SDK Changes] 
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 5d44006b40b13174c0e246a9ed8f484b202ea616. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-netapp [View full logs]  [Preview SDK Changes]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 5d44006b40b13174c0e246a9ed8f484b202ea616. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️netapp [View full logs]  [Preview Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • ❌Pipeline Framework Failed [Logs] Generate from 5d44006b40b13174c0e246a9ed8f484b202ea616. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe
    • ❌Az.netapp.DefaultTag [View full logs]  
      error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.netapp.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 9, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Swagger Microsoft.NetApp https://apiview.dev/Assemblies/Review/ef295ee98355433c91ef63d546176dc7
    Go sdk/resourcemanager/netapp/armnetapp There is no API change compared with the previous version
    .Net Azure.ResourceManager.NetApp There is no API change compared with the previous version
    JavaScript @azure/arm-netapp https://apiview.dev/Assemblies/Review/283f71e0fa1445f1b40ec2f109b5c63d
    Java azure-resourcemanager-netapp There is no API change compared with the previous version

    @openapi-workflow-bot openapi-workflow-bot bot added FixS360 ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 9, 2023
    @openapi-workflow-bot
    Copy link

    Hi, @audunn your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @azure-sdk azure-sdk mentioned this pull request May 9, 2023
    Closed
    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-MissingBaseCommit new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager labels May 9, 2023
    @openapi-workflow-bot
    Copy link

    Hi @audunn, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi, @audunn, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    This was referenced May 9, 2023
    Draft
    Closed
    Closed
    Closed
    Closed
    @audunn audunn closed this May 10, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang

    Assignees

    @ankhyk ankhyk

    Labels
    ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-MissingBaseCommit FixS360 new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @audunn @ankhyk @AzureRestAPISpecReview