update samples parameters #23843

kazrael2119 · 2023-05-06T08:36:38Z

openapi-workflow-bot · 2023-05-06T08:36:41Z

Hi, @kazrael2119 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2023-05-06T08:36:42Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️🔄ModelValidation inProgress [Detail]

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-06T08:36:42Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/network/armnetwork - Approved - 3.0.0

+	Field `PeerRouteList` of struct `VirtualHubBgpConnectionsClientListAdvertisedRoutesResponse` has been removed
+	Field `PeerRouteList` of struct `VirtualHubBgpConnectionsClientListLearnedRoutesResponse` has been removed
+	Struct `PeerRouteList` has been removed
+	Type of `EffectiveRouteMapRoute.Prefix` has been changed from `[]*string` to `*string`
+	`LoadBalancerBackendAddressAdminStateDrain` from enum `LoadBalancerBackendAddressAdminState` has been removed

❌azure-sdk-for-js - @azure/arm-network - Approved - 31.0.0

+	Enum KnownLoadBalancerBackendAddressAdminState no longer has value Drain
+	Interface Subnet no longer has parameter applicationGatewayIpConfigurations
+	Type of parameter prefix of interface EffectiveRouteMapRoute is changed from string[] to string

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 3327f12e710d51ee6edec8725acf6fbf200f3b06. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Network [View full logs] [Preview SDK Changes]
- Microsoft.Azure.Management.Network.26.0.0.nupkg
- Microsoft.Azure.Management.Network.26.0.0.symbols.nupkg

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs] Generate from 3327f12e710d51ee6edec8725acf6fbf200f3b06. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.Network [View full logs] [Preview SDK Changes] Breaking Change Detected

Azure.ResourceManager.Network.1.3.0-alpha.20230517.1.nupkg

info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.ArmOperation<Azure.ResourceManager.Network.Models.PeerRouteList> Azure.ResourceManager.Network.BgpConnectionResource.GetLearnedRoutesVirtualHubBgpConnection(Azure.WaitUntil, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Threading.Tasks.Task<Azure.ResourceManager.ArmOperation<Azure.ResourceManager.Network.Models.PeerRouteList>> Azure.ResourceManager.Network.BgpConnectionResource.GetLearnedRoutesVirtualHubBgpConnectionAsync(Azure.WaitUntil, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.ArmOperation Azure.ResourceManager.Network.VirtualHubResource.GetEffectiveVirtualHubRoutes(Azure.WaitUntil, Azure.ResourceManager.Network.Models.EffectiveRoutesContent, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Threading.Tasks.Task<Azure.ResourceManager.ArmOperation> Azure.ResourceManager.Network.VirtualHubResource.GetEffectiveVirtualHubRoutesAsync(Azure.WaitUntil, Azure.ResourceManager.Network.Models.EffectiveRoutesContent, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.ArmOperation Azure.ResourceManager.Network.VirtualHubResource.GetInboundRoutes(Azure.WaitUntil, Azure.ResourceManager.Network.Models.VirtualHubInboundRoutesContent, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Threading.Tasks.Task<Azure.ResourceManager.ArmOperation> Azure.ResourceManager.Network.VirtualHubResource.GetInboundRoutesAsync(Azure.WaitUntil, Azure.ResourceManager.Network.Models.VirtualHubInboundRoutesContent, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.ArmOperation Azure.ResourceManager.Network.VirtualHubResource.GetOutboundRoutes(Azure.WaitUntil, Azure.ResourceManager.Network.Models.VirtualHubOutboundRoutesContent, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Threading.Tasks.Task<Azure.ResourceManager.ArmOperation> Azure.ResourceManager.Network.VirtualHubResource.GetOutboundRoutesAsync(Azure.WaitUntil, Azure.ResourceManager.Network.Models.VirtualHubOutboundRoutesContent, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Network.Models.LoadBalancerBackendAddressAdminState Azure.ResourceManager.Network.Models.LoadBalancerBackendAddressAdminState.Drain.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Network.Models.PeerRouteList' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Network/Debug/netstandard2.0/Azure.ResourceManager.Network.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj::TargetFramework=netstandard2.0]

️🔄 azure-sdk-for-python-track2 inProgress [Detail]

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 3327f12e710d51ee6edec8725acf6fbf200f3b06. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-network-generated [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 3327f12e710d51ee6edec8725acf6fbf200f3b06. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/network/armnetwork [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `EffectiveRouteMapRoute.Prefix` has been changed from `[]*string` to `*string`
info	[Changelog] - `LoadBalancerBackendAddressAdminStateDrain` from enum `LoadBalancerBackendAddressAdminState` has been removed
info	[Changelog] - Struct `PeerRouteList` has been removed
info	[Changelog] - Field `PeerRouteList` of struct `VirtualHubBgpConnectionsClientListAdvertisedRoutesResponse` has been removed
info	[Changelog] - Field `PeerRouteList` of struct `VirtualHubBgpConnectionsClientListLearnedRoutesResponse` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `NetworkInterfaceAuxiliaryModeAcceleratedConnections` added to enum type `NetworkInterfaceAuxiliaryMode`
info	[Changelog] - New value `WebApplicationFirewallRuleTypeRateLimitRule` added to enum type `WebApplicationFirewallRuleType`
info	[Changelog] - New enum type `ApplicationGatewayFirewallRateLimitDuration` with values `ApplicationGatewayFirewallRateLimitDurationFiveMins`, `ApplicationGatewayFirewallRateLimitDurationOneMin`
info	[Changelog] - New enum type `ApplicationGatewayFirewallUserSessionVariable` with values `ApplicationGatewayFirewallUserSessionVariableClientAddr`, `ApplicationGatewayFirewallUserSessionVariableGeoLocation`, `ApplicationGatewayFirewallUserSessionVariableNone`
info	[Changelog] - New enum type `AzureFirewallPacketCaptureFlagsType` with values `AzureFirewallPacketCaptureFlagsTypeAck`, `AzureFirewallPacketCaptureFlagsTypeFin`, `AzureFirewallPacketCaptureFlagsTypePush`, `AzureFirewallPacketCaptureFlagsTypeRst`, `AzureFirewallPacketCaptureFlagsTypeSyn`, `AzureFirewallPacketCaptureFlagsTypeUrg`
info	[Changelog] - New enum type `NetworkInterfaceAuxiliarySKU` with values `NetworkInterfaceAuxiliarySKUA1`, `NetworkInterfaceAuxiliarySKUA2`, `NetworkInterfaceAuxiliarySKUA4`, `NetworkInterfaceAuxiliarySKUA8`, `NetworkInterfaceAuxiliarySKUNone`
info	[Changelog] - New enum type `PublicIPAddressDNSSettingsDomainNameLabelScope` with values `PublicIPAddressDNSSettingsDomainNameLabelScopeNoReuse`, `PublicIPAddressDNSSettingsDomainNameLabelScopeResourceGroupReuse`, `PublicIPAddressDNSSettingsDomainNameLabelScopeSubscriptionReuse`, `PublicIPAddressDNSSettingsDomainNameLabelScopeTenantReuse`
info	[Changelog] - New enum type `ScrubbingRuleEntryMatchOperator` with values `ScrubbingRuleEntryMatchOperatorEquals`, `ScrubbingRuleEntryMatchOperatorEqualsAny`
info	[Changelog] - New enum type `ScrubbingRuleEntryMatchVariable` with values `ScrubbingRuleEntryMatchVariableRequestArgNames`, `ScrubbingRuleEntryMatchVariableRequestCookieNames`, `ScrubbingRuleEntryMatchVariableRequestHeaderNames`, `ScrubbingRuleEntryMatchVariableRequestIPAddress`, `ScrubbingRuleEntryMatchVariableRequestJSONArgNames`, `ScrubbingRuleEntryMatchVariableRequestPostArgNames`
info	[Changelog] - New enum type `ScrubbingRuleEntryState` with values `ScrubbingRuleEntryStateDisabled`, `ScrubbingRuleEntryStateEnabled`
info	[Changelog] - New enum type `WebApplicationFirewallScrubbingState` with values `WebApplicationFirewallScrubbingStateDisabled`, `WebApplicationFirewallScrubbingStateEnabled`
info	[Changelog] - New function `*AzureFirewallsClient.BeginPacketCapture(context.Context, string, string, FirewallPacketCaptureParameters, *AzureFirewallsClientBeginPacketCaptureOptions) (*runtime.Poller[AzureFirewallsClientPacketCaptureResponse], error)`
info	[Changelog] - New function `*ClientFactory.NewVirtualApplianceConnectionsClient() *VirtualApplianceConnectionsClient`
info	[Changelog] - New function `NewVirtualApplianceConnectionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VirtualApplianceConnectionsClient, error)`
info	[Changelog] - New function `*VirtualApplianceConnectionsClient.BeginCreateOrUpdate(context.Context, string, string, string, VirtualApplianceConnection, *VirtualApplianceConnectionsClientBeginCreateOrUpdateOptions) (*runtime.Poller[VirtualApplianceConnectionsClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*VirtualApplianceConnectionsClient.BeginDelete(context.Context, string, string, string, *VirtualApplianceConnectionsClientBeginDeleteOptions) (*runtime.Poller[VirtualApplianceConnectionsClientDeleteResponse], error)`
info	[Changelog] - New function `*VirtualApplianceConnectionsClient.Get(context.Context, string, string, string, *VirtualApplianceConnectionsClientGetOptions) (VirtualApplianceConnectionsClientGetResponse, error)`
info	[Changelog] - New function `*VirtualApplianceConnectionsClient.NewListPager(string, string, *VirtualApplianceConnectionsClientListOptions) *runtime.Pager[VirtualApplianceConnectionsClientListResponse]`
info	[Changelog] - New struct `AzureFirewallPacketCaptureFlags`
info	[Changelog] - New struct `AzureFirewallPacketCaptureRule`
info	[Changelog] - New struct `EffectiveRouteMapRouteList`
info	[Changelog] - New struct `FirewallPacketCaptureParameters`
info	[Changelog] - New struct `FirewallPacketCaptureParametersFormat`
info	[Changelog] - New struct `FirewallPolicyHTTPHeaderToInsert`
info	[Changelog] - New struct `GroupByUserSession`
info	[Changelog] - New struct `GroupByVariable`
info	[Changelog] - New struct `PolicySettingsLogScrubbing`
info	[Changelog] - New struct `PropagatedRouteTableNfv`
info	[Changelog] - New struct `RoutingConfigurationNfv`
info	[Changelog] - New struct `RoutingConfigurationNfvSubResource`
info	[Changelog] - New struct `VirtualApplianceAdditionalNicProperties`
info	[Changelog] - New struct `VirtualApplianceConnection`
info	[Changelog] - New struct `VirtualApplianceConnectionList`
info	[Changelog] - New struct `VirtualApplianceConnectionProperties`
info	[Changelog] - New struct `WebApplicationFirewallScrubbingRules`
info	[Changelog] - New field `HTTPHeadersToInsert` in struct `ApplicationRule`
info	[Changelog] - New field `EnableKerberos` in struct `BastionHostPropertiesFormat`
info	[Changelog] - New field `AuxiliarySKU` in struct `InterfacePropertiesFormat`
info	[Changelog] - New field `FileUploadEnforcement`, `LogScrubbing`, `RequestBodyEnforcement`, `RequestBodyInspectLimitInKB` in struct `PolicySettings`
info	[Changelog] - New field `PrivateEndpointLocation` in struct `PrivateEndpointConnectionProperties`
info	[Changelog] - New field `DomainNameLabelScope` in struct `PublicIPAddressDNSSettings`
info	[Changelog] - New field `InstanceName` in struct `VirtualApplianceNicProperties`
info	[Changelog] - New field `AdditionalNics`, `VirtualApplianceConnections` in struct `VirtualAppliancePropertiesFormat`
info	[Changelog] - New field `Value` in struct `VirtualHubBgpConnectionsClientListAdvertisedRoutesResponse`
info	[Changelog] - New field `Value` in struct `VirtualHubBgpConnectionsClientListLearnedRoutesResponse`
info	[Changelog] - New anonymous field `VirtualHubEffectiveRouteList` in struct `VirtualHubsClientGetEffectiveVirtualHubRoutesResponse`
info	[Changelog] - New anonymous field `EffectiveRouteMapRouteList` in struct `VirtualHubsClientGetInboundRoutesResponse`
info	[Changelog] - New anonymous field `EffectiveRouteMapRouteList` in struct `VirtualHubsClientGetOutboundRoutesResponse`
info	[Changelog] - New field `GroupByUserSession`, `RateLimitDuration`, `RateLimitThreshold` in struct `WebApplicationFirewallCustomRule`
info	[Changelog]
info	[Changelog] Total 6 breaking change(s), 98 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 3327f12e710d51ee6edec8725acf6fbf200f3b06. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-network [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-network-31.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group NetworkVirtualApplianceConnections
info	[Changelog]   - Added operation AzureFirewalls.beginPacketCapture
info	[Changelog]   - Added operation AzureFirewalls.beginPacketCaptureAndWait
info	[Changelog]   - Added Interface AzureFirewallPacketCaptureFlags
info	[Changelog]   - Added Interface AzureFirewallPacketCaptureRule
info	[Changelog]   - Added Interface AzureFirewallsPacketCaptureHeaders
info	[Changelog]   - Added Interface AzureFirewallsPacketCaptureOptionalParams
info	[Changelog]   - Added Interface EffectiveRouteMapRouteList
info	[Changelog]   - Added Interface FirewallPacketCaptureParameters
info	[Changelog]   - Added Interface FirewallPolicyHttpHeaderToInsert
info	[Changelog]   - Added Interface GroupByUserSession
info	[Changelog]   - Added Interface GroupByVariable
info	[Changelog]   - Added Interface NetworkVirtualApplianceConnection
info	[Changelog]   - Added Interface NetworkVirtualApplianceConnectionList
info	[Changelog]   - Added Interface NetworkVirtualApplianceConnectionsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface NetworkVirtualApplianceConnectionsDeleteHeaders
info	[Changelog]   - Added Interface NetworkVirtualApplianceConnectionsDeleteOptionalParams
info	[Changelog]   - Added Interface NetworkVirtualApplianceConnectionsGetOptionalParams
info	[Changelog]   - Added Interface NetworkVirtualApplianceConnectionsListNextOptionalParams
info	[Changelog]   - Added Interface NetworkVirtualApplianceConnectionsListOptionalParams
info	[Changelog]   - Added Interface NetworkVirtualAppliancesCreateOrUpdateHeaders
info	[Changelog]   - Added Interface NetworkVirtualAppliancesDeleteHeaders
info	[Changelog]   - Added Interface PolicySettingsLogScrubbing
info	[Changelog]   - Added Interface PropagatedRouteTableNfv
info	[Changelog]   - Added Interface RoutingConfigurationNfv
info	[Changelog]   - Added Interface RoutingConfigurationNfvSubResource
info	[Changelog]   - Added Interface VirtualApplianceAdditionalNicProperties
info	[Changelog]   - Added Interface WebApplicationFirewallScrubbingRules
info	[Changelog]   - Added Type Alias ApplicationGatewayFirewallRateLimitDuration
info	[Changelog]   - Added Type Alias ApplicationGatewayFirewallUserSessionVariable
info	[Changelog]   - Added Type Alias AzureFirewallPacketCaptureFlagsType
info	[Changelog]   - Added Type Alias AzureFirewallsPacketCaptureResponse
info	[Changelog]   - Added Type Alias NetworkInterfaceAuxiliarySku
info	[Changelog]   - Added Type Alias NetworkVirtualApplianceConnectionsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias NetworkVirtualApplianceConnectionsGetResponse
info	[Changelog]   - Added Type Alias NetworkVirtualApplianceConnectionsListNextResponse
info	[Changelog]   - Added Type Alias NetworkVirtualApplianceConnectionsListResponse
info	[Changelog]   - Added Type Alias PublicIpAddressDnsSettingsDomainNameLabelScope
info	[Changelog]   - Added Type Alias ScrubbingRuleEntryMatchOperator
info	[Changelog]   - Added Type Alias ScrubbingRuleEntryMatchVariable
info	[Changelog]   - Added Type Alias ScrubbingRuleEntryState
info	[Changelog]   - Added Type Alias VirtualHubsGetEffectiveVirtualHubRoutesResponse
info	[Changelog]   - Added Type Alias VirtualHubsGetInboundRoutesResponse
info	[Changelog]   - Added Type Alias VirtualHubsGetOutboundRoutesResponse
info	[Changelog]   - Added Type Alias WebApplicationFirewallScrubbingState
info	[Changelog]   - Interface ApplicationRule has a new optional parameter httpHeadersToInsert
info	[Changelog]   - Interface BastionHost has a new optional parameter enableKerberos
info	[Changelog]   - Interface NetworkInterface has a new optional parameter auxiliarySku
info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter additionalNics
info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter virtualApplianceConnections
info	[Changelog]   - Interface PolicySettings has a new optional parameter fileUploadEnforcement
info	[Changelog]   - Interface PolicySettings has a new optional parameter logScrubbing
info	[Changelog]   - Interface PolicySettings has a new optional parameter requestBodyEnforcement
info	[Changelog]   - Interface PolicySettings has a new optional parameter requestBodyInspectLimitInKB
info	[Changelog]   - Interface PrivateEndpointConnection has a new optional parameter privateEndpointLocation
info	[Changelog]   - Interface PublicIPAddressDnsSettings has a new optional parameter domainNameLabelScope
info	[Changelog]   - Interface Subnet has a new optional parameter applicationGatewayIPConfigurations
info	[Changelog]   - Interface VirtualApplianceNicProperties has a new optional parameter instanceName
info	[Changelog]   - Interface WebApplicationFirewallCustomRule has a new optional parameter groupByUserSession
info	[Changelog]   - Interface WebApplicationFirewallCustomRule has a new optional parameter rateLimitDuration
info	[Changelog]   - Interface WebApplicationFirewallCustomRule has a new optional parameter rateLimitThreshold
info	[Changelog]   - Added Enum KnownApplicationGatewayFirewallRateLimitDuration
info	[Changelog]   - Added Enum KnownApplicationGatewayFirewallUserSessionVariable
info	[Changelog]   - Added Enum KnownAzureFirewallPacketCaptureFlagsType
info	[Changelog]   - Added Enum KnownNetworkInterfaceAuxiliarySku
info	[Changelog]   - Added Enum KnownScrubbingRuleEntryMatchOperator
info	[Changelog]   - Added Enum KnownScrubbingRuleEntryMatchVariable
info	[Changelog]   - Added Enum KnownScrubbingRuleEntryState
info	[Changelog]   - Added Enum KnownWebApplicationFirewallScrubbingState
info	[Changelog]   - Enum KnownNetworkInterfaceAuxiliaryMode has a new value AcceleratedConnections
info	[Changelog]   - Enum KnownWebApplicationFirewallRuleType has a new value RateLimitRule
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface Subnet no longer has parameter applicationGatewayIpConfigurations
info	[Changelog]   - Type of parameter prefix of interface EffectiveRouteMapRoute is changed from string[] to string
info	[Changelog]   - Enum KnownLoadBalancerBackendAddressAdminState no longer has value Drain

️🔄 azure-resource-manager-schemas inProgress [Detail]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from 3327f12e710d51ee6edec8725acf6fbf200f3b06. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

❌Az.network.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.network.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-06T08:36:43Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/network/armnetwork	https://apiview.dev/Assemblies/Review/a1a5471427ed4916a1c49ea42849444e
Java	azure-resourcemanager-network-generated	https://apiview.dev/Assemblies/Review/d9680153de2b45af88b9bd19900220af
.Net	Azure.ResourceManager.Network	https://apiview.dev/Assemblies/Review/10e8b7c0022a4857b4f8d15160534678
JavaScript	@azure/arm-network	https://apiview.dev/Assemblies/Review/0ce7542112134ae7b8969771ef6587c2

openapi-workflow-bot · 2023-05-06T08:45:18Z

Hi @kazrael2119, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

kazrael2119 · 2023-05-06T09:46:30Z

@tadelesh ,please review go sdk breaking change,thanks

kazrael2119 · 2023-05-06T09:50:18Z

Hi @MikhailTryakhov ,please review this pr,thanks

MikhailTryakhov · 2023-05-07T19:56:28Z

@kazrael2119 please don't deliver changes to the main branch directly. Read our official docs: https://microsoft.sharepoint.com/teams/Aznet/_layouts/OneNote.aspx?id=%2Fteams%2FAznet%2FOneNotes%2FNRP%20migrated&wd=target%28Hydra%20%2B%20SDK.one%7C96F7B95B-A378-4CA5-903B-C88F894873EF%2F%5BNEWEST%5D%20Swagger-%3E%20SDK%20-%3E%20PowerShell%20Process%20Overview%7C71B816ED-DAE5-4907-94D8-DE7EE13278A0%2F%29
onenote:https://microsoft.sharepoint.com/teams/Aznet/OneNotes/NRP%20migrated/Hydra%20+%20SDK.one#%5bNEWEST%5d%20Swagger-%3e%20SDK%20-%3e%20PowerShell%20Process%20Overview&section-id={96F7B95B-A378-4CA5-903B-C88F894873EF}&page-id={71B816ED-DAE5-4907-94D8-DE7EE13278A0}&end

kazrael2119 · 2023-05-08T02:30:08Z

@kazrael2119 please don't deliver changes to the main branch directly. Read our official docs: https://microsoft.sharepoint.com/teams/Aznet/_layouts/OneNote.aspx?id=%2Fteams%2FAznet%2FOneNotes%2FNRP%20migrated&wd=target%28Hydra%20%2B%20SDK.one%7C96F7B95B-A378-4CA5-903B-C88F894873EF%2F%5BNEWEST%5D%20Swagger-%3E%20SDK%20-%3E%20PowerShell%20Process%20Overview%7C71B816ED-DAE5-4907-94D8-DE7EE13278A0%2F%29 onenote:https://microsoft.sharepoint.com/teams/Aznet/OneNotes/NRP%20migrated/Hydra%20+%20SDK.one#%5bNEWEST%5d%20Swagger-%3e%20SDK%20-%3e%20PowerShell%20Process%20Overview&section-id={96F7B95B-A378-4CA5-903B-C88F894873EF}&page-id={71B816ED-DAE5-4907-94D8-DE7EE13278A0}&end

Hi @MikhailTryakhov , I 'm from js sdk team, and this pr is created according to this customer feedback:
Azure/azure-sdk-for-js#25699

I also create a pr to fix them in js sdk repo:
Azure/azure-sdk-for-js#25771

but I think that it will be better if I modify them in swagger, If you know the related service owner in network and graphservice, I can give them an issue and they can fix it themselves, thanks

kazrael2119 · 2023-05-22T06:07:34Z

@kazrael2119 please don't deliver changes to the main branch directly. Read our official docs: https://microsoft.sharepoint.com/teams/Aznet/_layouts/OneNote.aspx?id=%2Fteams%2FAznet%2FOneNotes%2FNRP%20migrated&wd=target%28Hydra%20%2B%20SDK.one%7C96F7B95B-A378-4CA5-903B-C88F894873EF%2F%5BNEWEST%5D%20Swagger-%3E%20SDK%20-%3E%20PowerShell%20Process%20Overview%7C71B816ED-DAE5-4907-94D8-DE7EE13278A0%2F%29 onenote:https://microsoft.sharepoint.com/teams/Aznet/OneNotes/NRP%20migrated/Hydra%20+%20SDK.one#%5bNEWEST%5d%20Swagger-%3e%20SDK%20-%3e%20PowerShell%20Process%20Overview&section-id={96F7B95B-A378-4CA5-903B-C88F894873EF}&page-id={71B816ED-DAE5-4907-94D8-DE7EE13278A0}&end

Hi @MikhailTryakhov , I 'm from js sdk team, and this pr is created according to this customer feedback: Azure/azure-sdk-for-js#25700 Azure/azure-sdk-for-js#25699

I also create a pr to fix them in js sdk repo: Azure/azure-sdk-for-js#25771

but I think that it will be better if I modify them in swagger, If you know the related service owner in network and graphservice, I can give them an issue and they can fix it themselves, thanks

Hi @MikhailTryakhov please take a look for this, thanks

ghost · 2023-06-11T16:03:07Z